Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-08 Thread Peter Krempa
On Fri, Sep 08, 2023 at 14:51:14 -0500, Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: > > As I've promised a long time ago I gave your patches some testing in > > regards of cooperation with blockjobs and snapshots. > > > > Since the new version of the patches was not yet

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-08 Thread Jonathon Jongsma
On 7/24/23 8:05 AM, Peter Krempa wrote: As I've promised a long time ago I gave your patches some testing in regards of cooperation with blockjobs and snapshots. Since the new version of the patches was not yet posted on the list I'm replying here including my observations from testing patches

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-04 Thread Stefano Garzarella
On Fri, Sep 01, 2023 at 03:24:11PM -0500, Jonathon Jongsma wrote: On 8/16/23 4:19 PM, Jonathon Jongsma wrote: On 8/8/23 6:00 AM, Stefano Garzarella wrote: On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote: On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: On Wed,

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-01 Thread Jonathon Jongsma
On 8/16/23 4:19 PM, Jonathon Jongsma wrote: On 8/8/23 6:00 AM, Stefano Garzarella wrote: On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote: On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > On 7/24/23 8:05

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-16 Thread Jonathon Jongsma
On 8/8/23 6:00 AM, Stefano Garzarella wrote: On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote: On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: [...] > > > > I've

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-08 Thread Stefano Garzarella
On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote: On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: [...] > > > > I've also noticed that using 'qcow2' format for the

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-07 Thread Peter Krempa
On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: > On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > > On 7/24/23 8:05 AM, Peter Krempa wrote: > > [...] > > > > > > > I've also noticed that using 'qcow2' format for the device doesn't work: > > > > > > error: internal

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-03 Thread Stefano Garzarella
On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: [...] > > > > I've also noticed that using 'qcow2' format for the device doesn't work: > > > > error: internal error: process exited while connecting to monitor: > > 2023-07-24T12:54:15.818631Z

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-02 Thread Jonathon Jongsma
On 7/24/23 8:05 AM, Peter Krempa wrote: As I've promised a long time ago I gave your patches some testing in regards of cooperation with blockjobs and snapshots. Since the new version of the patches was not yet posted on the list I'm replying here including my observations from testing patches

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-07-24 Thread Peter Krempa
As I've promised a long time ago I gave your patches some testing in regards of cooperation with blockjobs and snapshots. Since the new version of the patches was not yet posted on the list I'm replying here including my observations from testing patches from your gitlab branch: On Tue, Jun 06,

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:15:30 -0500, Jonathon Jongsma wrote: > Requires recent qemu with support for the virtio-blk-vhost-vdpa device > and the ability to pass a /dev/fdset/N path for the vdpa path (8.1.0) > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1900770 > --- >

[libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-06-06 Thread Jonathon Jongsma
Requires recent qemu with support for the virtio-blk-vhost-vdpa device and the ability to pass a /dev/fdset/N path for the vdpa path (8.1.0) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1900770 --- src/qemu/qemu_block.c | 20 -- src/qemu/qemu_domain.c