Commit abab5c47f8060eddf0212084a1d70c4b1e3d92dd incorrectly assumed we do not have any files that could be affected by
sc_prohibit_reversed_compare_failure due to the conditional assignment: _test_script_regex ?= \<init\.sh\> so it removed the check. Also remove the leftover assignment of test-lib.sh, since any new code attemptint to use the compare function with reversed arguments should be rejected by review for using shell instead of C or Python. Signed-off-by: Ján Tomko <jto...@redhat.com> --- build-aux/syntax-check.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index b72a5b93d8..cf7a1fa4c6 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -108,8 +108,6 @@ local-check := \ syntax-check: $(local-check) -_test_script_regex = \<test-lib\.sh\> - # Files that should never cause syntax check failures. VC_LIST_ALWAYS_EXCLUDE_REGEX = \ (^(docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ -- 2.31.1