Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-25 Thread Martin Kletzander
On Fri, Jul 14, 2023 at 04:39:39PM +0200, Andrea Bolognani wrote: This logic was necessary when socket activation was introduced in libvirt 5.6.0/5.7.0 in order to guarantee smooth upgrades. These days, even the oldest platform that we target ships a version of libvirtd that implements socket ac

Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 08:44:04AM -0700, Andrea Bolognani wrote: > On Fri, Jul 14, 2023 at 04:25:48PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 14, 2023 at 08:13:11AM -0700, Andrea Bolognani wrote: > > > RHEL 8 got libvirt 6.0.0, which comes with socket activation support, > > > back in 202

Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Andrea Bolognani
On Fri, Jul 14, 2023 at 04:25:48PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 14, 2023 at 08:13:11AM -0700, Andrea Bolognani wrote: > > RHEL 8 got libvirt 6.0.0, which comes with socket activation support, > > back in 2020 with RHEL 8.3. Based on our support policy we only > > consider the late

Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 08:13:11AM -0700, Andrea Bolognani wrote: > On Fri, Jul 14, 2023 at 03:45:11PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 14, 2023 at 04:39:39PM +0200, Andrea Bolognani wrote: > > > This logic was necessary when socket activation was introduced > > > in libvirt 5.6.0/5

Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Andrea Bolognani
On Fri, Jul 14, 2023 at 03:45:11PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 14, 2023 at 04:39:39PM +0200, Andrea Bolognani wrote: > > This logic was necessary when socket activation was introduced > > in libvirt 5.6.0/5.7.0 in order to guarantee smooth upgrades. > > > > These days, even the o

Re: [libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 04:39:39PM +0200, Andrea Bolognani wrote: > This logic was necessary when socket activation was introduced > in libvirt 5.6.0/5.7.0 in order to guarantee smooth upgrades. > > These days, even the oldest platform that we target ships a > version of libvirtd that implements s

[libvirt PATCH 5/8] rpm: Remove custom libvirtd restart logic

2023-07-14 Thread Andrea Bolognani
This logic was necessary when socket activation was introduced in libvirt 5.6.0/5.7.0 in order to guarantee smooth upgrades. These days, even the oldest platform that we target ships a version of libvirtd that implements socket activation, so the additional code is no longer useful and we can trea