Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 05:53:15PM +0200, Peter Krempa wrote: > On Thu, Aug 05, 2021 at 16:48:59 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 05, 2021 at 05:44:15PM +0200, Peter Krempa wrote: > > > On Thu, Aug 05, 2021 at 16:33:57 +0100, Daniel P. Berrangé wrote: > > > > On Thu, Aug 05, 2021

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Peter Krempa
On Thu, Aug 05, 2021 at 16:48:59 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 05, 2021 at 05:44:15PM +0200, Peter Krempa wrote: > > On Thu, Aug 05, 2021 at 16:33:57 +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 05, 2021 at 05:29:24PM +0200, Peter Krempa wrote: [...] > Lock state tracking

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 05:44:15PM +0200, Peter Krempa wrote: > On Thu, Aug 05, 2021 at 16:33:57 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 05, 2021 at 05:29:24PM +0200, Peter Krempa wrote: > > > On Thu, Aug 05, 2021 at 16:11:15 +0100, Daniel P. Berrangé wrote: > > > > On Thu, Aug 05, 2021

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Peter Krempa
On Thu, Aug 05, 2021 at 16:33:57 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 05, 2021 at 05:29:24PM +0200, Peter Krempa wrote: > > On Thu, Aug 05, 2021 at 16:11:15 +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 05, 2021 at 02:58:03PM +0100, Daniel P. Berrangé wrote: > > > > On Thu, Aug 05,

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 05:29:24PM +0200, Peter Krempa wrote: > On Thu, Aug 05, 2021 at 16:11:15 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 05, 2021 at 02:58:03PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 05, 2021 at 03:33:57PM +0200, Tim Wiederhake wrote: > > > > On Thu, 2021-08-05

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Peter Krempa
On Thu, Aug 05, 2021 at 16:11:15 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 05, 2021 at 02:58:03PM +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 05, 2021 at 03:33:57PM +0200, Tim Wiederhake wrote: > > > On Thu, 2021-08-05 at 14:24 +0100, Daniel P. Berrangé wrote: > > > > On Thu, Aug 05,

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 03:43:11PM +0200, Peter Krempa wrote: > On Thu, Aug 05, 2021 at 15:08:50 +0200, Tim Wiederhake wrote: > > `pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock` > > return an error code that is currently ignored. > > > > Add debug information if one of

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 02:58:03PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 05, 2021 at 03:33:57PM +0200, Tim Wiederhake wrote: > > On Thu, 2021-08-05 at 14:24 +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 05, 2021 at 03:08:50PM +0200, Tim Wiederhake wrote: > > > >

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 03:33:57PM +0200, Tim Wiederhake wrote: > On Thu, 2021-08-05 at 14:24 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 05, 2021 at 03:08:50PM +0200, Tim Wiederhake wrote: > > > `pthread_mutex_destroy`, `pthread_mutex_lock` and > > > `pthread_mutex_unlock` > > > return an

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Peter Krempa
On Thu, Aug 05, 2021 at 15:08:50 +0200, Tim Wiederhake wrote: > `pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock` > return an error code that is currently ignored. > > Add debug information if one of these operations failed, e.g. when there > is an attempt to destroy a

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Tim Wiederhake
On Thu, 2021-08-05 at 14:24 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 05, 2021 at 03:08:50PM +0200, Tim Wiederhake wrote: > > `pthread_mutex_destroy`, `pthread_mutex_lock` and > > `pthread_mutex_unlock` > > return an error code that is currently ignored. > > > > Add debug information if one

Re: [libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 03:08:50PM +0200, Tim Wiederhake wrote: > `pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock` > return an error code that is currently ignored. > > Add debug information if one of these operations failed, e.g. when there > is an attempt to destroy a

[libvirt PATCH 6/7] virMutex*: Warn on error

2021-08-05 Thread Tim Wiederhake
`pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock` return an error code that is currently ignored. Add debug information if one of these operations failed, e.g. when there is an attempt to destroy a still locked mutex or unlock and already unlocked mutex. Signed-off-by: Tim