Re: [libvirt PATCH v2 02/17] util: Helper functions to get process info

2021-12-10 Thread Praveen K Paladugu
On 12/3/2021 11:26 AM, Ján Tomko wrote: On a Thursday in 2021, Praveen K Paladugu wrote: Signed-off-by: Praveen K Paladugu It would be helpful to say in the commit message that the functions are being moved, not newly introduced. Fixed in v3 Jano --- src/libvirt_private.syms |   2 +

Re: [libvirt PATCH v2 02/17] util: Helper functions to get process info

2021-12-03 Thread Ján Tomko
On a Thursday in 2021, Praveen K Paladugu wrote: Signed-off-by: Praveen K Paladugu It would be helpful to say in the commit message that the functions are being moved, not newly introduced. Jano --- src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 116

[libvirt PATCH v2 02/17] util: Helper functions to get process info

2021-12-02 Thread Praveen K Paladugu
Signed-off-by: Praveen K Paladugu --- src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 116 ++- src/util/virprocess.c| 108 src/util/virprocess.h| 5 ++ 4 files changed, 120 insertions(+), 111