Re: [libvirt PATCH v2 06/13] util: introduce compat wrappers for Winsock2

2020-01-17 Thread Pavel Hrdina
On Fri, Jan 17, 2020 at 09:38:42AM +, Daniel P. Berrangé wrote: > On Fri, Jan 17, 2020 at 10:27:05AM +0100, Pavel Hrdina wrote: > > On Thu, Jan 16, 2020 at 03:24:41PM +, Daniel P. Berrangé wrote: > > > Windows sockets take a SOCKET HANDLE object instead of a > > > file descriptor. Wrap

Re: [libvirt PATCH v2 06/13] util: introduce compat wrappers for Winsock2

2020-01-17 Thread Daniel P . Berrangé
On Fri, Jan 17, 2020 at 10:27:05AM +0100, Pavel Hrdina wrote: > On Thu, Jan 16, 2020 at 03:24:41PM +, Daniel P. Berrangé wrote: > > Windows sockets take a SOCKET HANDLE object instead of a > > file descriptor. Wrap them in the same way that gnulib > > does so that they use C runtime file

Re: [libvirt PATCH v2 06/13] util: introduce compat wrappers for Winsock2

2020-01-17 Thread Pavel Hrdina
On Thu, Jan 16, 2020 at 03:24:41PM +, Daniel P. Berrangé wrote: > Windows sockets take a SOCKET HANDLE object instead of a > file descriptor. Wrap them in the same way that gnulib > does so that they use C runtime file descriptors. > > While we could in theory use GSocket, it is hard to get >

[libvirt PATCH v2 06/13] util: introduce compat wrappers for Winsock2

2020-01-16 Thread Daniel P . Berrangé
Windows sockets take a SOCKET HANDLE object instead of a file descriptor. Wrap them in the same way that gnulib does so that they use C runtime file descriptors. While we could in theory use GSocket, it is hard to get the exact same semantics libvirt has for its current socket usage. Wrapping the