Re: [libvirt PATCH v2 06/33] systemd: Introduce common templates

2023-09-28 Thread Daniel P . Berrangé
On Thu, Sep 28, 2023 at 06:52:35AM -0500, Andrea Bolognani wrote: > On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote: > > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote: > > > > +++

Re: [libvirt PATCH v2 06/33] systemd: Introduce common templates

2023-09-28 Thread Andrea Bolognani
On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote: > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote: > > > +++ b/scripts/merge-systemd-units.py > > > @@ -0,0 +1,91 @@ > > > +#!/usr/bin/env

Re: [libvirt PATCH v2 06/33] systemd: Introduce common templates

2023-09-28 Thread Andrea Bolognani
On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote: > > +++ b/scripts/merge-systemd-units.py > > @@ -0,0 +1,91 @@ > > +#!/usr/bin/env python3 > > Stick a license header of SPDX tag on this. Done (patch below). >

Re: [libvirt PATCH v2 06/33] systemd: Introduce common templates

2023-09-28 Thread Daniel P . Berrangé
On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote: > We already use templating to generate sockets, which are all > based off libvirtd's. Push the idea further, and extend it to > cover services as well. > > This is more challenging, as the various modular daemons each have > their

[libvirt PATCH v2 06/33] systemd: Introduce common templates

2023-09-27 Thread Andrea Bolognani
We already use templating to generate sockets, which are all based off libvirtd's. Push the idea further, and extend it to cover services as well. This is more challenging, as the various modular daemons each have their own needs in terms of what system services needs to be available before they