Re: [libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

2020-10-26 Thread Andrea Bolognani
On Fri, 2020-07-24 at 18:22 +0200, Andrea Bolognani wrote: > On Fri, 2020-07-24 at 16:14 +0100, Daniel P. Berrangé wrote: > > char * > > +virNetClientSSHHelperCommand(virNetClientProxy proxy, > > + const char *netcatPath, > > + const char

Re: [libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

2020-07-24 Thread Andrea Bolognani
On Fri, 2020-07-24 at 17:28 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 06:22:37PM +0200, Andrea Bolognani wrote: > > I still think that the presence of an explicit 'netcat' parameter in > > the URI should result in switching to proxy=netcat instead of the > > default behavior,

Re: [libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 06:22:37PM +0200, Andrea Bolognani wrote: > On Fri, 2020-07-24 at 16:14 +0100, Daniel P. Berrangé wrote: > > char * > > +virNetClientSSHHelperCommand(virNetClientProxy proxy, > > + const char *netcatPath, > > + const

Re: [libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

2020-07-24 Thread Andrea Bolognani
On Fri, 2020-07-24 at 16:14 +0100, Daniel P. Berrangé wrote: > char * > +virNetClientSSHHelperCommand(virNetClientProxy proxy, > + const char *netcatPath, > + const char *socketPath, > + const char *driverURI, > +

[libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

2020-07-24 Thread Daniel P . Berrangé
This wires up support for using the new virt-ssh-helper binary with the ssh, libssh and libssh2 protocols. The new binary will be used preferentially if it is available in $PATH, otherwise we fall back to traditional netcat. The "proxy" URI parameter can be used to force use of netcat e.g.