Re: [libvirt PATCH v2 12/13] virstoragefile: use virStorageFile prefix for all functions

2021-01-22 Thread Pavel Hrdina
On Fri, Jan 22, 2021 at 10:10:33AM +0100, Peter Krempa wrote: > On Thu, Jan 21, 2021 at 20:34:26 +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > I really hate that these functions are exported. > > If this patch is necessary for the following, then commit it, otherwise > d

Re: [libvirt PATCH v2 12/13] virstoragefile: use virStorageFile prefix for all functions

2021-01-22 Thread Peter Krempa
On Thu, Jan 21, 2021 at 20:34:26 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- I really hate that these functions are exported. If this patch is necessary for the following, then commit it, otherwise drop it. I'll follow up with patches for moving the two functions appropriately

[libvirt PATCH v2 12/13] virstoragefile: use virStorageFile prefix for all functions

2021-01-21 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 4 ++-- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_snapshot.c | 2 +- src/storage_file/storage_source.c | 6 +++--- src/util/virstoragefile.c | 6 +++--- src/util/virstoragefile.h | 4 ++-- 6