Re: [libvirt PATCH v2 2/5] nodedev: Handle NULL command variable

2021-06-23 Thread Boris Fiuczynski
On 6/22/21 9:53 PM, Jonathon Jongsma wrote: In commit 68580a51, I removed the checks for NULL cmd variables because virCommandRun() already handles the case where it is called with a NULL cmd. Unfortunately, it handles this case by raising a generic error which is both unhelpful and overwrites

[libvirt PATCH v2 2/5] nodedev: Handle NULL command variable

2021-06-22 Thread Jonathon Jongsma
In commit 68580a51, I removed the checks for NULL cmd variables because virCommandRun() already handles the case where it is called with a NULL cmd. Unfortunately, it handles this case by raising a generic error which is both unhelpful and overwrites our existing error message. So for example,