Re: [libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

2023-08-25 Thread Shiva
My previous misunderstanding was exactly as you mentioned, to group commits on a file to file basis. Now I have understood what a semantic change should be like, with your provided example. You are not asking for much, your corrections help me a lot in my learning journey and I am very grateful

Re: [libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

2023-08-25 Thread Michal Prívozník
On 8/16/23 20:47, K Shiva Kiran wrote: > - Introduces virNetworkObjGetMetadata() and > virNetworkObjSetMetadata(). > - These functions implement common behaviour that can be reused by > network drivers. > - Introduces virNetworkObjUpdateModificationImpact() among other > helper functions

[libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

2023-08-16 Thread K Shiva Kiran
- Introduces virNetworkObjGetMetadata() and virNetworkObjSetMetadata(). - These functions implement common behaviour that can be reused by network drivers. - Introduces virNetworkObjUpdateModificationImpact() among other helper functions that resolve the live/persistent state of the