Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

2023-04-06 Thread Shiva
On 4/6/23 20:43, Shiva wrote: Now, earlier in this loop (not visible in this limited context though) there's a check for VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK type. I don't think it is special so we have two options:    a) move it into virDomainGraphicsListenDefValidate(), or    b) move

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser virDomainGraphicsListenDef out of Parser

2023-04-06 Thread K Shiva
In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: Koninty Shiva Kiran

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

2023-04-06 Thread Shiva
Now, earlier in this loop (not visible in this limited context though) there's a check for VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK type. I don't think it is special so we have two options: a) move it into virDomainGraphicsListenDefValidate(), or b) move those checks out of

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

2023-04-06 Thread Michal Prívozník
On 4/6/23 14:51, K Shiva wrote: > In an effort to separate the validation steps from the Parse stage, a > part of the validation of virDomainGraphicsListenDef has been moved to > domain_validate.h. > > Signed-off-by: K Shiva Sorry for not raising this earlier, but we tend to use legal names

[libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

2023-04-06 Thread K Shiva
In an effort to separate the validation steps from the Parse stage, a part of the validation of virDomainGraphicsListenDef has been moved to domain_validate.h. Signed-off-by: K Shiva --- This is a v3 of: https://listman.redhat.com/archives/libvir-list/2023-April/239265.html diff to v2: -