Re: [libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

2020-03-27 Thread Daniel P . Berrangé
On Fri, Mar 27, 2020 at 12:51:23PM +0100, Andrea Bolognani wrote: > On Fri, 2020-03-27 at 10:53 +, Daniel P. Berrangé wrote: > > On Thu, Mar 26, 2020 at 06:06:37PM +0100, Andrea Bolognani wrote: > > > On Thu, 2020-03-26 at 12:35 +, Daniel P. Berrangé wrote: > > > > +if

Re: [libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

2020-03-27 Thread Andrea Bolognani
On Fri, 2020-03-27 at 10:53 +, Daniel P. Berrangé wrote: > On Thu, Mar 26, 2020 at 06:06:37PM +0100, Andrea Bolognani wrote: > > On Thu, 2020-03-26 at 12:35 +, Daniel P. Berrangé wrote: > > > +if "localhost" in line: > > > +print(" ❌ FAIL: bad email in %s" %

Re: [libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

2020-03-27 Thread Daniel P . Berrangé
On Thu, Mar 26, 2020 at 06:06:37PM +0100, Andrea Bolognani wrote: > On Thu, 2020-03-26 at 12:35 +, Daniel P. Berrangé wrote: > [...] > > +for sha, subject in commits: > > + > > +msg = subprocess.check_output(["git", "show", "-s", sha], > > +

Re: [libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

2020-03-26 Thread Andrea Bolognani
On Thu, 2020-03-26 at 12:35 +, Daniel P. Berrangé wrote: [...] > +for sha, subject in commits: > + > +msg = subprocess.check_output(["git", "show", "-s", sha], > + universal_newlines=True) > +lines = msg.strip().split("\n") > + > +print(" %s %s" %

[libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

2020-03-26 Thread Daniel P . Berrangé
This introduces a CI job for validating DCO sign-off in every commit message. The CI jobs are not provided any information on what the baseline commit for the branch was. We can't compare against the forked repo's master branch, as there's no guarantee the user is keeping master up2date in their