Re: [libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

2021-03-19 Thread Andrea Bolognani
On Fri, 2021-03-19 at 11:36 +0100, Erik Skultety wrote: > On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote: > > On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > > > As documented at [1], the common practice wrt to private > > > > s/wrt to/with respect to/ > > > > >

Re: [libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

2021-03-19 Thread Erik Skultety
On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote: > On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > > As documented at [1], the common practice wrt to private > > s/wrt to/with respect to/ > > > def parse(self): > > return self.parser.parse_args() > >

Re: [libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

2021-03-18 Thread Erik Skultety
On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote: > On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > > As documented at [1], the common practice wrt to private > > s/wrt to/with respect to/ > > > def parse(self): > > return self.parser.parse_args() > >

Re: [libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

2021-03-18 Thread Andrea Bolognani
On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > As documented at [1], the common practice wrt to private s/wrt to/with respect to/ > def parse(self): > return self.parser.parse_args() Shouldn't this change be applied to Parser.parser... > def run(self): >

[libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

2021-03-18 Thread Erik Skultety
As documented at [1], the common practice wrt to private attributes/methods naming is to prefix them with an underscore. [1] https://docs.python.org/3/tutorial/classes.html#private-variables Signed-off-by: Erik Skultety --- ci/helper | 68 +++