Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Peter Krempa
On Tue, Apr 28, 2020 at 15:27:18 +0200, Michal Privoznik wrote: > On 4/28/20 1:19 PM, Peter Krempa wrote: > > On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: > > > On a Tuesday in 2020, Michal Privoznik wrote: > > > > On 4/27/20 10:22 PM, tobin wrote: > > > > > > > > > Yeah fine with me.

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Michal Privoznik
On 4/28/20 1:19 PM, Peter Krempa wrote: On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: On a Tuesday in 2020, Michal Privoznik wrote: On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState,

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Peter Krempa
On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: > On a Tuesday in 2020, Michal Privoznik wrote: > > On 4/27/20 10:22 PM, tobin wrote: > > > > > Yeah fine with me. Thank You. > > > > > > When it's a positive capability, you don't even need > > > virQEMUCapsProbeQMPTCGState, > > > you can

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Ján Tomko
On a Tuesday in 2020, Michal Privoznik wrote: On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState, you can just add the capability to virQEMUCapsObjectTypes. Yep. I've went with that. This is now

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Michal Privoznik
On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState, you can just add the capability to virQEMUCapsObjectTypes. Yep. I've went with that. This is now pushed. Reviewed-by: Michal Privoznik

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-27 Thread tobin
On 2020-04-27 16:00, Michal Privoznik wrote: On 4/27/20 9:16 PM, tobin wrote: On 2020-04-27 04:15, Michal Privoznik wrote: On 4/24/20 5:52 PM, tobin wrote: On 2020-04-24 11:31, Michal Privoznik wrote: On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-27 Thread Michal Privoznik
On 4/27/20 9:16 PM, tobin wrote: On 2020-04-27 04:15, Michal Privoznik wrote: On 4/24/20 5:52 PM, tobin wrote: On 2020-04-24 11:31, Michal Privoznik wrote: On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-27 Thread tobin
On 2020-04-27 04:15, Michal Privoznik wrote: On 4/24/20 5:52 PM, tobin wrote: On 2020-04-24 11:31, Michal Privoznik wrote: On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-27 Thread Michal Privoznik
On 4/24/20 5:52 PM, tobin wrote: On 2020-04-24 11:31, Michal Privoznik wrote: On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-24 Thread tobin
On 2020-04-24 11:31, Michal Privoznik wrote: On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum ---

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-24 Thread Michal Privoznik
On 4/22/20 11:50 PM, Tobin Feldman-Fitzthum wrote: Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++

[libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-22 Thread Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 15