Re: [libvirt PATCH v6 0/5] Add a PCI/PCIe device VPD Capability

2021-10-19 Thread Dmitrii Shcherbakov
Hi Daniel, > This new XML format looks good to me now > > I've done a high level review and only major issue i've seen is the > memory leaks mentioned on the first patch. Thanks a lot! I'll address those and send out a v7. Best Regards, Dmitrii Shcherbakov LP/oftc: dmitriis > > On Mon, Oct 1

Re: [libvirt PATCH v6 0/5] Add a PCI/PCIe device VPD Capability

2021-10-19 Thread Daniel P . Berrangé
On Mon, Oct 11, 2021 at 05:04:41PM +0300, Dmitrii Shcherbakov wrote: > Add support for deserializing the binary PCI/PCIe VPD format and > exposing VPD resources as XML elements in a new nested capability > of PCI/PCIe devices called 'vpd'. > > The series contains the following incremental changes:

[libvirt PATCH v6 0/5] Add a PCI/PCIe device VPD Capability

2021-10-11 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The series contains the following incremental changes: * The PCI VPD parser module, in-memory resource representation and tests; *