We're passing 'ifaces_count' to virHashCreate as the initial
hash table size just after we've initialized it to zero.
This translates to a default of 256 inside virHashCreateFull.
Instead of this obfuscation, use virHashNew (default of 32),
to make it obvious we don't care about the initial hash size.
Also remove the error handling, since neither of the functions
return any errors after switching to g_new0.
Signed-off-by: Ján Tomko <jto...@redhat.com>
Reviewed-by: Jonathon Jongsma <jjong...@redhat.com>
---
src/qemu/qemu_agent.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index b11f8afde7..a09fb4da2a 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -2129,10 +2129,7 @@ qemuAgentGetInterfaces(qemuAgentPtr agent,
virHashTablePtr ifaces_store = NULL;
/* Hash table to handle the interface alias */
- if (!(ifaces_store = virHashCreate(ifaces_count, NULL))) {
- virHashFree(ifaces_store);
- return -1;
- }
+ ifaces_store = virHashNew(NULL);
if (!(cmd = qemuAgentMakeCommand("guest-network-get-interfaces", NULL)))
goto cleanup;
--
2.26.2
