Re: [libvirt RFC 20/24] qemu_snapshot: prepare data for external snapshot deletion

2022-10-13 Thread Peter Krempa
On Wed, Oct 12, 2022 at 17:19:23 +0200, Pavel Hrdina wrote: > On Tue, Sep 06, 2022 at 12:19:38PM +0200, Peter Krempa wrote: > > On Tue, Aug 23, 2022 at 18:32:23 +0200, Pavel Hrdina wrote: [...] > > > + > > > + > > > +static GPtrArray* > > > +qemuSnapshotDeleteExternalPrepare(virDomainObj *vm, >

Re: [libvirt RFC 20/24] qemu_snapshot: prepare data for external snapshot deletion

2022-10-12 Thread Pavel Hrdina
On Tue, Sep 06, 2022 at 12:19:38PM +0200, Peter Krempa wrote: > On Tue, Aug 23, 2022 at 18:32:23 +0200, Pavel Hrdina wrote: > > In order to save some CPU cycles we will collect all the necessary data > > to delete external snapshot before we even start. They will be later > > used by code that

Re: [libvirt RFC 20/24] qemu_snapshot: prepare data for external snapshot deletion

2022-09-06 Thread Peter Krempa
On Tue, Aug 23, 2022 at 18:32:23 +0200, Pavel Hrdina wrote: > In order to save some CPU cycles we will collect all the necessary data > to delete external snapshot before we even start. They will be later > used by code that deletes the snapshots and updates metadata when > needed. > > With

[libvirt RFC 20/24] qemu_snapshot: prepare data for external snapshot deletion

2022-08-23 Thread Pavel Hrdina
In order to save some CPU cycles we will collect all the necessary data to delete external snapshot before we even start. They will be later used by code that deletes the snapshots and updates metadata when needed. With external snapshots we need data that libvirt gets from running QEMU process