Re: [libvirt RFC 21/24] qemu_snapshot: implement deletion of external snapshot

2022-09-07 Thread Peter Krempa
On Tue, Aug 23, 2022 at 18:32:24 +0200, Pavel Hrdina wrote: > When deleting snapshot we are starting block-commit job over all disks > that are part of the snapshot. > > This operation may fail as it writes data changes to the backing qcow2 > image so we need to wait for all the disks to finish th

[libvirt RFC 21/24] qemu_snapshot: implement deletion of external snapshot

2022-08-23 Thread Pavel Hrdina
When deleting snapshot we are starting block-commit job over all disks that are part of the snapshot. This operation may fail as it writes data changes to the backing qcow2 image so we need to wait for all the disks to finish the operation and wait for correct signal from QEMU. If deleting active