Re: [libvirt RFC 22/24] qemu_snapshot: update metadata when deleting snapshots

2022-10-25 Thread Pavel Hrdina
On Wed, Sep 07, 2022 at 03:06:51PM +0200, Peter Krempa wrote: > On Tue, Aug 23, 2022 at 18:32:25 +0200, Pavel Hrdina wrote: > > With external snapshots we need to modify the metadata bit more then > > what is required for internal snapshots. Mainly the storage source > > location changes with every

Re: [libvirt RFC 22/24] qemu_snapshot: update metadata when deleting snapshots

2022-09-07 Thread Peter Krempa
On Tue, Aug 23, 2022 at 18:32:25 +0200, Pavel Hrdina wrote: > With external snapshots we need to modify the metadata bit more then > what is required for internal snapshots. Mainly the storage source > location changes with every external snapshot. > > This means that if we delete non-leaf snapsho

[libvirt RFC 22/24] qemu_snapshot: update metadata when deleting snapshots

2022-08-23 Thread Pavel Hrdina
With external snapshots we need to modify the metadata bit more then what is required for internal snapshots. Mainly the storage source location changes with every external snapshot. This means that if we delete non-leaf snapshot we need to update all children snapshots and modify the disk sources