Re: [libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-28 Thread Daniel P . Berrangé
On Thu, Apr 28, 2022 at 04:20:13PM +0200, Claudio Fontana wrote: > I actually think I found the problem. It needs to be put explicitly into a > list > of methods that require conn, like NodeSetMemoryParameters. Ah, lucky someone already hit the same problem scenario > > Here is the change: > >

Re: [libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-28 Thread Claudio Fontana
On 4/28/22 11:34 AM, Daniel P. Berrangé wrote: > On Wed, Apr 27, 2022 at 10:56:22PM +0200, Claudio Fontana wrote: >> On 4/27/22 1:00 AM, Jim Fehlig wrote: >>> On 4/26/22 10:47, Claudio Fontana wrote: Signed-off-by: Claudio Fontana --- src/remote/remote_driver.c | 1 + src

Re: [libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-28 Thread Daniel P . Berrangé
On Wed, Apr 27, 2022 at 10:56:22PM +0200, Claudio Fontana wrote: > On 4/27/22 1:00 AM, Jim Fehlig wrote: > > On 4/26/22 10:47, Claudio Fontana wrote: > >> Signed-off-by: Claudio Fontana > >> --- > >> src/remote/remote_driver.c | 1 + > >> src/remote/remote_protocol.x | 14 +- > >>

Re: [libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-27 Thread Claudio Fontana
On 4/27/22 1:00 AM, Jim Fehlig wrote: > On 4/26/22 10:47, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> src/remote/remote_driver.c | 1 + >> src/remote/remote_protocol.x | 14 +- >> src/remote_protocol-structs | 8 >> 3 files changed, 22 insertio

Re: [libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-27 Thread Claudio Fontana
On 4/27/22 1:00 AM, Jim Fehlig wrote: > On 4/26/22 10:47, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> src/remote/remote_driver.c | 1 + >> src/remote/remote_protocol.x | 14 +- >> src/remote_protocol-structs | 8 >> 3 files changed, 22 insertio

[libvirt RFC v3 06/19] remote: Add RPC support for the virDomainRestoreParametersFlags API

2022-04-26 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 8 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 1fc5d4