Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Claudio Fontana
On 5/6/22 1:54 PM, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 01:51:53PM +0200, Claudio Fontana wrote: >> On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: >>> On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: where it can be reused by other helpers. No changes other th

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Daniel P . Berrangé
On Fri, May 06, 2022 at 01:51:53PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Daniel P . Berrangé
On Fri, May 06, 2022 at 01:48:33PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Daniel P . Berrangé
On Fri, May 06, 2022 at 01:29:57PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Claudio Fontana
On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Claudio Fontana
On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Claudio Fontana
On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-06 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > where it can be reused by other helpers. > No changes other than the move. > > Note that this makes iohelper now dependent on -lutil, because unused > (for iohelper) parts of virfile.c contain calls to openpty(3). Needs -lacl too

[libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

2022-05-05 Thread Claudio Fontana
where it can be reused by other helpers. No changes other than the move. Note that this makes iohelper now dependent on -lutil, because unused (for iohelper) parts of virfile.c contain calls to openpty(3). Signed-off-by: Claudio Fontana --- src/util/iohelper.c | 175 ---