Re: Improve default machine type selection

2023-04-14 Thread Jim Fehlig
On 4/14/23 09:24, Andrea Bolognani wrote: On Fri, Apr 14, 2023 at 03:33:21PM +0200, Peter Krempa wrote: On Fri, Apr 14, 2023 at 06:26:02 -0700, Andrea Bolognani wrote: I don't think we rely on default machine types anywhere in the test suite, and even if we were only minor touch-ups would

Re: Improve default machine type selection

2023-04-14 Thread Andrea Bolognani
On Fri, Apr 14, 2023 at 03:33:21PM +0200, Peter Krempa wrote: > On Fri, Apr 14, 2023 at 06:26:02 -0700, Andrea Bolognani wrote: > > I don't think we rely on default machine types anywhere in the test > > suite, and even if we were only minor touch-ups would probably be > > necessary. > > The test

Re: Improve default machine type selection

2023-04-14 Thread Peter Krempa
On Fri, Apr 14, 2023 at 06:26:02 -0700, Andrea Bolognani wrote: > On Thu, Apr 13, 2023 at 08:23:25AM -0600, Jim Fehlig wrote: > > On 4/6/23 08:27, Andrea Bolognani wrote: > > > On Thu, Apr 06, 2023 at 06:10:11AM -0700, Andrea Bolognani wrote: > > > > In conclusion, there currently doesn't seem to

Re: Improve default machine type selection

2023-04-14 Thread Andrea Bolognani
On Thu, Apr 13, 2023 at 08:23:25AM -0600, Jim Fehlig wrote: > On 4/6/23 08:27, Andrea Bolognani wrote: > > On Thu, Apr 06, 2023 at 06:10:11AM -0700, Andrea Bolognani wrote: > > > In conclusion, there currently doesn't seem to exist a way to define > > > a useful integratorcp-based VM in libvirt,

Re: Improve default machine type selection

2023-04-13 Thread Jim Fehlig
On 4/6/23 08:27, Andrea Bolognani wrote: On Thu, Apr 06, 2023 at 06:10:11AM -0700, Andrea Bolognani wrote: In conclusion, there currently doesn't seem to exist a way to define a useful integratorcp-based VM in libvirt, which IMO means we can safely change the default machine type for Arm

Re: Improve default machine type selection

2023-04-06 Thread Andrea Bolognani
On Thu, Apr 06, 2023 at 06:10:11AM -0700, Andrea Bolognani wrote: > In conclusion, there currently doesn't seem to exist a way to define > a useful integratorcp-based VM in libvirt, which IMO means we can > safely change the default machine type for Arm architectures without > any concerns about

Re: Improve default machine type selection

2023-04-06 Thread Peter Krempa
On Thu, Apr 06, 2023 at 06:32:30 -0700, Andrea Bolognani wrote: > On Thu, Apr 06, 2023 at 09:32:28AM +0200, Peter Krempa wrote: > > On Wed, Apr 05, 2023 at 15:19:07 -0600, Jim Fehlig wrote: > > > # virsh create test.xml > > > error: Failed to create domain from test.xml > > > error: internal

Re: Improve default machine type selection

2023-04-06 Thread Andrea Bolognani
On Thu, Apr 06, 2023 at 09:32:28AM +0200, Peter Krempa wrote: > On Wed, Apr 05, 2023 at 15:19:07 -0600, Jim Fehlig wrote: > > # virsh create test.xml > > error: Failed to create domain from test.xml > > error: internal error: process exited while connecting to monitor: > >

Re: Improve default machine type selection

2023-04-06 Thread Andrea Bolognani
On Wed, Apr 05, 2023 at 03:19:07PM -0600, Jim Fehlig wrote: > On 3/16/23 11:56, Jim Fehlig wrote: > > I just did a quick check with libvirt 9.1.0 (qemu is a bit older, at 7.1.0): > > > > # cat test.xml > > > >   test > >   2097152 > >   1 > >   > >     hvm > >     >

Re: Improve default machine type selection

2023-04-06 Thread Peter Krempa
On Thu, Apr 06, 2023 at 09:32:28 +0200, Peter Krempa wrote: > On Wed, Apr 05, 2023 at 15:19:07 -0600, Jim Fehlig wrote: > > On 3/16/23 11:56, Jim Fehlig wrote: [...] > > error: Failed to create domain from test.xml > > error: internal error: process exited while connecting to monitor: > >

Re: Improve default machine type selection

2023-04-06 Thread Peter Krempa
On Wed, Apr 05, 2023 at 15:19:07 -0600, Jim Fehlig wrote: > On 3/16/23 11:56, Jim Fehlig wrote: > > On 3/15/23 08:40, Ján Tomko wrote: > > > On a Monday in 2023, Jim Fehlig wrote: > > > > If an explicit machine type is not specified in the VM config, > > > > the qemu driver will select the first

Re: Improve default machine type selection

2023-04-05 Thread Jim Fehlig
On 3/16/23 11:56, Jim Fehlig wrote: On 3/15/23 08:40, Ján Tomko wrote: On a Monday in 2023, Jim Fehlig wrote: If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See

Re: Improve default machine type selection

2023-03-17 Thread Jim Fehlig
On 3/16/23 11:56, Jim Fehlig wrote: On 3/15/23 08:40, Ján Tomko wrote: On a Monday in 2023, Jim Fehlig wrote: If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See

Re: Improve default machine type selection

2023-03-17 Thread Jim Fehlig
On 3/15/23 08:40, Ján Tomko wrote: On a Monday in 2023, Jim Fehlig wrote: If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See virQEMUCapsGetPreferredMachine

Re: Improve default machine type selection

2023-03-15 Thread Andrea Bolognani
On Wed, Mar 15, 2023 at 03:40:18PM +0100, Ján Tomko wrote: > On a Monday in 2023, Jim Fehlig wrote: > > If an explicit machine type is not specified in the VM config, the qemu > > driver will select the first machine type in the list of machine types > > for the specified accelerator. See

Re: Improve default machine type selection

2023-03-15 Thread Ján Tomko
On a Monday in 2023, Jim Fehlig wrote: If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See virQEMUCapsGetPreferredMachine

Re: Improve default machine type selection

2023-03-15 Thread Jim Fehlig
On 3/14/23 11:24, Andrea Bolognani wrote: On Mon, Mar 13, 2023 at 02:25:01PM -0600, Jim Fehlig wrote: If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See

Re: Improve default machine type selection

2023-03-14 Thread Andrea Bolognani
On Mon, Mar 13, 2023 at 02:25:01PM -0600, Jim Fehlig wrote: > If an explicit machine type is not specified in the VM config, the qemu > driver will select the first machine type in the list of machine types for > the specified accelerator. See virQEMUCapsGetPreferredMachine > >

Improve default machine type selection

2023-03-13 Thread Jim Fehlig
If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See virQEMUCapsGetPreferredMachine https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_capabilities.c#L6133