Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-20 Thread Peter Krempa
On Wed, Apr 20, 2022 at 09:52:34 +0100, Richard W.M. Jones wrote: > On Wed, Apr 20, 2022 at 09:36:29AM +0200, Peter Krempa wrote: > > I'll post patches to address that, but the question is whether we want > > to bother with actually supporting the password authentication or not, > > because the

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-20 Thread Richard W.M. Jones
On Wed, Apr 20, 2022 at 09:36:29AM +0200, Peter Krempa wrote: > I'll post patches to address that, but the question is whether we want > to bother with actually supporting the password authentication or not, > because the simpler approach to fixing the bug is to simply allow it. Did you mean:

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-20 Thread Peter Krempa
On Tue, Apr 19, 2022 at 15:00:58 -0500, Jonathon Jongsma wrote: > On 4/19/22 12:31 PM, Richard W.M. Jones wrote: > > On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > > > Well, As far as I can tell, there is no valid XML for exercising > > > http auth. The schema for http(s)

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-20 Thread Peter Krempa
On Tue, Apr 19, 2022 at 22:30:51 +0100, Richard W.M. Jones wrote: > On Tue, Apr 19, 2022 at 03:00:58PM -0500, Jonathon Jongsma wrote: > > On 4/19/22 12:31 PM, Richard W.M. Jones wrote: [..] > > >Now actual support for protocol='ssh' (as in, the main drive, not only > > >in the backing chain),

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Richard W.M. Jones
On Tue, Apr 19, 2022 at 03:00:58PM -0500, Jonathon Jongsma wrote: > On 4/19/22 12:31 PM, Richard W.M. Jones wrote: > >On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > >>And now I notice that we do not actually have support for 'ssh' > >>network disks in our xml schema either

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Jonathon Jongsma
On 4/19/22 12:31 PM, Richard W.M. Jones wrote: On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: Well, As far as I can tell, there is no valid XML for exercising http auth. The schema for http(s) sources does not include any element [1]. And the schema for the element [2]

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Daniel P . Berrangé
On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > On 4/19/22 9:05 AM, Daniel P. Berrangé wrote: > > On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: > > > As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL > > > is > > > planning to remove

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Richard W.M. Jones
On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > Well, As far as I can tell, there is no valid XML for exercising > http auth. The schema for http(s) sources does not include any > element [1]. And the schema for the element [2] > requires a element with a required 'type'

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Jonathon Jongsma
On 4/19/22 9:05 AM, Daniel P. Berrangé wrote: On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL is planning to remove dependencies on the qemu-block-curl and qemu-block-ssh plugins from the main qemu

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Daniel P . Berrangé
On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: > As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL is > planning to remove dependencies on the qemu-block-curl and qemu-block-ssh > plugins from the main qemu package. This creates issues for libvirt for >

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-15 Thread Richard W.M. Jones
On Fri, Apr 15, 2022 at 10:09:59AM +0100, Richard W.M. Jones wrote: > I agree we should implement creation for ssh disks (not sure if it's > possible or even makes sense for curl). Shouldn't be too difficult. https://listman.redhat.com/archives/libguestfs/2022-April/028680.html Rich. --

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-15 Thread Richard W.M. Jones
On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: > 1. secrets [...] > Fortunately, nbdkit provides a method for reading cookies and > passwords from a file, which should be secure if the file has > permissions set properly. So I'm currently planning to write a file > containing

Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-14 Thread Jonathon Jongsma
As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL is planning to remove dependencies on the qemu-block-curl and qemu-block-ssh plugins from the main qemu package. This creates issues for libvirt for supporting network disk sources. So I've been looking into using nbdkit