Re: Please revert f4be03b3 (libvirtaio: Drop object(*args, **kwargs)) for theoretical reasons

2020-08-28 Thread Philipp Hahn
Hello, Am 20.08.20 um 11:20 schrieb Daniel P. Berrangé: > On Wed, Aug 19, 2020 at 11:32:10PM +0200, Wojtek Porczyk wrote: >> Hi Philipp, >> (Cc: Daniel, because IIUC you reviewed !16 which got this merged), >> >> I'm sorry I didn't notice this earlier, but the commit f4be03b3 dated >> 2020-04-20

Re: Please revert f4be03b3 (libvirtaio: Drop object(*args, **kwargs)) for theoretical reasons

2020-08-20 Thread Daniel P . Berrangé
On Wed, Aug 19, 2020 at 11:32:10PM +0200, Wojtek Porczyk wrote: > Hi Philipp, > (Cc: Daniel, because IIUC you reviewed !16 which got this merged), > > I'm sorry I didn't notice this earlier, but the commit f4be03b3 dated > 2020-04-20 [0] is wrong. The super().__init__(*args, **kwargs) in >

Please revert f4be03b3 (libvirtaio: Drop object(*args, **kwargs)) for theoretical reasons

2020-08-19 Thread Wojtek Porczyk
Hi Philipp, (Cc: Daniel, because IIUC you reviewed !16 which got this merged), I'm sorry I didn't notice this earlier, but the commit f4be03b3 dated 2020-04-20 [0] is wrong. The super().__init__(*args, **kwargs) in Callback.__init__ was there on purpose, because of how Python's inheritance in