Re: [PATCH v3 4/5] conf: add encryption engine property

On Thu, Oct 07, 2021 at 12:41:52 +, Or Ozeri wrote: >But that means changing the input file from using the default engine, to >using "qemu" explicitly. >I was thinking that keeping the input xml unchanged gets a stronger test, >since it also checks that default uses qemu. I

RE: [PATCH v3 4/5] conf: add encryption engine property

.com, idryo...@gmail.com,>to.my.troc...@gmail.com, "Danny Harnik" <dan...@il.ibm.com>>Subject: [EXTERNAL] Re: [PATCH v3 4/5] conf: add encryption engine>property>>On Thu, Oct 07, 2021 at 11:31:42 +, Or Ozeri wrote:>>-"Peter Krempa

Re: [PATCH v3 4/5] conf: add encryption engine property

On Thu, Oct 07, 2021 at 11:31:42 +, Or Ozeri wrote: >-"Peter Krempa" <[1]pkre...@redhat.com> wrote: - >>> diff --git a/tests/qemuxml2xmloutdata/disk-nvme.xml >>b/tests/qemuxml2xmloutdata/disk-nvme.xml >>> deleted file mode 12 >>> index ea9eb267ac..00 >

RE: [PATCH v3 4/5] conf: add encryption engine property

-"Peter Krempa" wrote: ->> diff --git a/tests/qemuxml2xmloutdata/disk-nvme.xml>b/tests/qemuxml2xmloutdata/disk-nvme.xml>> deleted file mode 12>> index ea9eb267ac..00>> --- a/tests/qemuxml2xmloutdata/disk-nvme.xml>> +++ /dev/null>> @@ -1 +0,0 @@>>

Re: [PATCH v3 4/5] conf: add encryption engine property

On Wed, Oct 06, 2021 at 05:18:45 -0500, Or Ozeri wrote: > This commit extends libvirt XML configuration to support a custom encryption > engine. > This means that becomes valid. > The only engine for now is qemu. However, a new engine (librbd) will be added > in an upcoming commit. > If no

Re: [PATCH v3 4/5] conf: add encryption engine property

On Wed, Oct 06, 2021 at 05:18:45 -0500, Or Ozeri wrote: > This commit extends libvirt XML configuration to support a custom encryption > engine. > This means that becomes valid. > The only engine for now is qemu. However, a new engine (librbd) will be added > in an upcoming commit. > If no