RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 17:47 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 17:40:58 +, Thanos Makatos wrote:

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 17:40:58 +, Thanos Makatos wrote: > > > > -Original Message- > > From: Peter Krempa > > Sent: 23 November 2020 16:56 > > To: Thanos Makatos > > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > > > S

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 16:56 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 16:48:55 +, Thanos Makatos wrote:

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 15:20 > To: Daniel P. Berrangé > Cc: Michal Prívozník ; Thanos Makatos > ; Suraj Kasi ; > libvirt-l...@redhat.com; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 23,

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 16:48:55 +, Thanos Makatos wrote: > > On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > > > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > > > > >

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > > As a starting point a trivial way to model this in the XML will > > > > > >

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 15:01:31 +, Daniel Berrange wrote: > On Mon, Nov 23, 2020 at 03:36:42PM +0100, Peter Krempa wrote: > > On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: [...] > > No, the NVMe controller lives on PCIe. Here we are trying to emulate a > > NVMe controller

Re: Libvirt NVME support

2020-11-23 Thread Daniel P . Berrangé
On Mon, Nov 23, 2020 at 03:36:42PM +0100, Peter Krempa wrote: > On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: > > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > > On Wed, Nov 18, 2020 at 09:57:14 +,

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > > > As a separate question, is there any

Re: Libvirt NVME support

2020-11-23 Thread Daniel P . Berrangé
On Mon, Nov 23, 2020 at 03:32:20PM +0100, Michal Prívozník wrote: > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > > > As a separate question, is there any

Re: Libvirt NVME support

2020-11-23 Thread Michal Prívozník
On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: As a separate question, is there any performance benefit of emulating a NVMe controller compared to e.g. virtio-scsi? We

Re: Libvirt NVME support

2020-11-23 Thread Daniel P . Berrangé
On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > As a separate question, is there any performance benefit of emulating a > > > NVMe controller compared to e.g. virtio-scsi? > > > > We haven't measured that yet; I

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > >

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > > > > > > > > > > > > > And then add the storage into it as: > >

Re: Libvirt NVME support

2020-11-23 Thread Peter Krempa
On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > > > > > > > > > And then add the storage into it as: > > > > > > > >

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > > > > > And then add the storage into it as: > > > > > > > > > > > > > > > > 'target dev' is how the device appears in

Re: Libvirt NVME support

2020-11-19 Thread Peter Krempa
On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > And then add the storage into it as: > > > > > > > > > > 'target dev' is how the device appears in the guest, right? It

RE: Libvirt NVME support

2020-11-19 Thread Thanos Makatos
> As a starting point a trivial way to model this in the XML will be: > > > > And then add the storage into it as: > > > > 'target dev' is how the device appears in the guest, right? It should be something like 'nvme0n1'. I'm not sure though this is something that we

Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 20:31:03 +0100, Michal Privoznik wrote: > On 11/18/20 11:24 AM, Peter Krempa wrote: > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: [...] > Would it make sense to relax the current limitation in libvirt and allow > (which is meant for cases where the

Re: Libvirt NVME support

2020-11-18 Thread Michal Privoznik
On 11/18/20 11:24 AM, Peter Krempa wrote: On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: As a separate question, is there any performance benefit of emulating a NVMe controller compared to e.g. virtio-scsi? We haven't measured that yet; I would expect it to be slight faster

Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > As a separate question, is there any performance benefit of emulating a > > NVMe controller compared to e.g. virtio-scsi? > > We haven't measured that yet; I would expect it to be slight faster and/or > more > CPU efficient but

RE: Libvirt NVME support

2020-11-18 Thread Thanos Makatos
> As a separate question, is there any performance benefit of emulating a > NVMe controller compared to e.g. virtio-scsi? We haven't measured that yet; I would expect it to be slight faster and/or more CPU efficient but wouldn't be surprised if it isn't. The main benefit of using NVMe is that we

Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Mon, Nov 16, 2020 at 23:01:00 +, Suraj Kasi wrote: > Hi Peter, > > Just wanted to follow up. As Thanos mentioned that we want a virtual NVMe > controller in the guest for which the support doesn't yet exist in libvirt. > Is it something that would be accepted if we were to implement it?

Re: Libvirt NVME support

2020-11-16 Thread Suraj Kasi
ot; wrote: > -Original Message- > From: Peter Krempa > Sent: 09 November 2020 16:44 > To: Suraj Kasi > Cc: libvirt-l...@redhat.com; Thanos Makatos > ; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 09, 202

RE: Libvirt NVME support

2020-11-09 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 09 November 2020 16:44 > To: Suraj Kasi > Cc: libvirt-l...@redhat.com; Thanos Makatos > ; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 09, 2020 at 16:38:11 +, Suraj Kasi wrote: > &g

Re: Libvirt NVME support

2020-11-09 Thread Peter Krempa
On Mon, Nov 09, 2020 at 16:38:11 +, Suraj Kasi wrote: > Hi, > > We wanted to check if it’s possible to specify a disk’s target as nvme (so > that the disk shows up as a nvme disk to the guest VM). > > Per libvirt documentation it looks like (since Libvirt 6.0.0) we can specify > the disk