Re: [libvirt] [PATCH] qemu: Do not reattach PCI device used by other domain when shutdown

2011-10-12 Thread Eric Blake
On 09/27/2011 12:53 AM, Osier Yang wrote: Apologies on the delayed review. This is some hairy code, and I want to make sure we get it right, so I kind of shelved it knowing it would be a longer review. When failing on starting a domain, it tries to reattach all the PCI devices defined in

Re: [libvirt] [PATCH] qemu: Do not reattach PCI device used by other domain when shutdown

2011-10-12 Thread Osier Yang
于 2011年10月13日 00:41, Eric Blake 写道: On 09/27/2011 12:53 AM, Osier Yang wrote: Apologies on the delayed review. This is some hairy code, and I want to make sure we get it right, so I kind of shelved it knowing it would be a longer review. When failing on starting a domain, it tries to

Re: [libvirt] [PATCH] qemu: Do not reattach PCI device used by other domain when shutdown

2011-10-09 Thread Osier Yang
Anybody could help review this? Thanks Osier 于 2011年09月27日 14:53, Osier Yang 写道: When failing on starting a domain, it tries to reattach all the PCI devices defined in the domain conf, regardless of whether the devices are still used by other domain. This will cause the devices are deleted