Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-29 Thread Daniel P. Berrange
FYI, the data streams patches are now committed Daniel On Fri, Sep 25, 2009 at 09:58:51AM +0200, Daniel Veillard wrote: On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote: The following series of patches introduce support for generic data streams in the libvirt API, the

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-25 Thread Daniel Veillard
On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote: The following series of patches introduce support for generic data streams in the libvirt API, the remote protocol, client daemon. The public API takes the form of a new object virStreamPtr and methods to read/write/close

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-25 Thread Daniel P. Berrange
On Fri, Sep 25, 2009 at 09:58:51AM +0200, Daniel Veillard wrote: On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote: Okay, this is very similar in principle with HTTP pipelining with IMHO the same benefits and the same potential drawbacks. A couple of things to check might

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-21 Thread Chris Lalancette
Daniel P. Berrange wrote: 1) Immediately after starting the stream, I get a virStreamRecv() callback on the destination side. The problem is that this is wrong for migration; there's no data that I can read *from* the destination qemu process which makes any sense. While I could

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-17 Thread Chris Lalancette
Daniel P. Berrange wrote: I still see a safewrite() in the your virStreamWrite() impl in the code currently pushed to gitorious.or, but perhaps you've changed that locally already. The other thing is that if the stream open Yeah, sorry, I just never pushed it up to gitorious. I'll make the

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-17 Thread Daniel P. Berrange
On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote: Daniel P. Berrange wrote: The immediate use case for this data stream code is Chris' QEMU migration patchset. The next use case is to allow serial console access to be tunnelled over libvirtd, eg to make 'virsh console

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-17 Thread Daniel P. Berrange
In looking at your migration patches I realized we could tweak things a little bit to allow the implementation of a new style migration API which does not require the destination virConnectPtr object. More importantly this could be used independantly of the tunnelled migration. So the patch that

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-16 Thread Chris Lalancette
Daniel P. Berrange wrote: On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote: I've uploaded the code that I'm trying out at the moment to: http://gitorious.org/~clalance/libvirt/clalance-staging/commits/tunnelled-migration Dan, can you take a look and make any suggestions about

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2009 at 09:35:21AM +0200, Chris Lalancette wrote: Daniel P. Berrange wrote: On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote: I've uploaded the code that I'm trying out at the moment to:

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-15 Thread Chris Lalancette
Daniel P. Berrange wrote: The immediate use case for this data stream code is Chris' QEMU migration patchset. The next use case is to allow serial console access to be tunnelled over libvirtd, eg to make 'virsh console GUEST' work remotely. This use case is why I included the support for

Re: [libvirt] [PATCH 00/11] Generic data stream handling

2009-09-15 Thread Daniel P. Berrange
On Tue, Sep 15, 2009 at 02:35:02PM +0200, Chris Lalancette wrote: I've uploaded the code that I'm trying out at the moment to: http://gitorious.org/~clalance/libvirt/clalance-staging/commits/tunnelled-migration Dan, can you take a look and make any suggestions about where I might be going