Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2009 at 12:51:24PM -0400, Laine Stump wrote: > From: Laine Stump > > --- > include/libvirt/virterror.h |4 + > src/datatypes.h | 25 ++ > src/driver.h| 60 + > src/libvirt.c | 607 > ++

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 12:51:24PM -0400, Laine Stump wrote: > From: Laine Stump Okay, looks fine too, ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtuali

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-13 Thread Laine Stump
On 05/13/2009 07:29 AM, Daniel Veillard wrote: On Wed, May 13, 2009 at 10:57:13AM +0100, Daniel P. Berrange wrote: On Wed, May 13, 2009 at 11:46:58AM +0200, Daniel Veillard wrote: On Mon, May 11, 2009 at 03:29:42PM -0400, Laine Stump wrote: Yes, tun interfaces too. Since this is

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-13 Thread Daniel Veillard
On Wed, May 13, 2009 at 10:57:13AM +0100, Daniel P. Berrange wrote: > On Wed, May 13, 2009 at 11:46:58AM +0200, Daniel Veillard wrote: > > On Mon, May 11, 2009 at 03:29:42PM -0400, Laine Stump wrote: > > > Yes, tun interfaces too. Since this is binary data rather than a > > > null-terminated stri

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-13 Thread Daniel P. Berrange
On Wed, May 13, 2009 at 11:46:58AM +0200, Daniel Veillard wrote: > On Mon, May 11, 2009 at 03:29:42PM -0400, Laine Stump wrote: > > Yes, tun interfaces too. Since this is binary data rather than a > > null-terminated string, > > we need to decide among the following three choices: > > > > 1) have

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-13 Thread Daniel Veillard
On Mon, May 11, 2009 at 03:29:42PM -0400, Laine Stump wrote: > On 05/11/2009 06:35 AM, Daniel P. Berrange wrote: >> On Fri, May 08, 2009 at 01:52:24PM -0400, Laine Stump wrote: >> >>> From: Laine Stump >>> >>> --- >>> include/libvirt/libvirt.h| 18 ++ >>> include/libvirt/libvirt.h.in |

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-11 Thread Laine Stump
On 05/11/2009 06:35 AM, Daniel P. Berrange wrote: On Fri, May 08, 2009 at 01:52:24PM -0400, Laine Stump wrote: From: Laine Stump --- include/libvirt/libvirt.h| 18 ++ include/libvirt/libvirt.h.in | 18 ++ include/libvirt/virterror.h |4 + src/datatypes.h | 25 ++

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-11 Thread Daniel P. Berrange
On Fri, May 08, 2009 at 01:52:24PM -0400, Laine Stump wrote: > From: Laine Stump > > --- > include/libvirt/libvirt.h| 18 ++ > include/libvirt/libvirt.h.in | 18 ++ > include/libvirt/virterror.h |4 + > src/datatypes.h | 25 ++ > src/driver.h | 60 ++