Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables

2010-10-13 Thread Daniel Veillard
On Wed, Oct 13, 2010 at 10:39:00AM +0530, Nikunj A. Dadhania wrote: > On Tue, 12 Oct 2010 16:54:39 +0200, Daniel Veillard > wrote: > > anyway once cleaned up the patch makes sensei, ACK, but please use > > "make syntax-check" and do not configure out drivers when you are > > developping patches

Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables

2010-10-12 Thread Nikunj A. Dadhania
On Tue, 12 Oct 2010 16:54:39 +0200, Daniel Veillard wrote: > On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote: > > From: Nikunj A. Dadhania > > > > Adding parsing code for memory tunables in the domain xml file > > > > v4: > > * Add memtune in tests/qemuxml2xmltest.c > > * Fix

Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables

2010-10-12 Thread Daniel Veillard
On Tue, Oct 12, 2010 at 09:33:03PM +0200, Matthias Bolte wrote: > 2010/10/12 Daniel Veillard : > > On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote: > >> From: Nikunj A. Dadhania > >> > >> Adding parsing code for memory tunables in the domain xml file > >> > >> v4: > >> * Add mem

Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables

2010-10-12 Thread Matthias Bolte
2010/10/12 Daniel Veillard : > On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote: >> From: Nikunj A. Dadhania >> >> Adding parsing code for memory tunables in the domain xml file >> >> v4: >> * Add memtune in tests/qemuxml2xmltest.c >> * Fix: insert memtune element only when any o

Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables

2010-10-12 Thread Daniel Veillard
On Fri, Oct 08, 2010 at 05:45:23PM +0530, Nikunj A. Dadhania wrote: > From: Nikunj A. Dadhania > > Adding parsing code for memory tunables in the domain xml file > > v4: > * Add memtune in tests/qemuxml2xmltest.c > * Fix: insert memtune element only when any of them is set > > v2: > + Fix typo