Re: Removal of fake-capabilities test from qemuxml2argvtest

2021-04-12 Thread Peter Krempa
On Fri, Apr 09, 2021 at 17:52:59 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 09, 2021 at 05:14:41PM +0200, Peter Krempa wrote: > > Hi, > > > > recently I've got very annoyed that we still have a very large amount of > > tests in qemuxml2argvtest which use DO_TEST or some other fake-caps > > tes

Re: Removal of fake-capabilities test from qemuxml2argvtest

2021-04-09 Thread Daniel P . Berrangé
On Fri, Apr 09, 2021 at 05:14:41PM +0200, Peter Krempa wrote: > Hi, > > recently I've got very annoyed that we still have a very large amount of > tests in qemuxml2argvtest which use DO_TEST or some other fake-caps > test. > > While I can see value of fake-caps test for negative cases (but I'd >

Removal of fake-capabilities test from qemuxml2argvtest

2021-04-09 Thread Peter Krempa
Hi, recently I've got very annoyed that we still have a very large amount of tests in qemuxml2argvtest which use DO_TEST or some other fake-caps test. While I can see value of fake-caps test for negative cases (but I'd prefer actually real-caps with capability masking) I don't think there's much