Re: regression in meson build, AC_PATH_PROG lost

2020-12-02 Thread Olaf Hering
Am Thu, 12 Nov 2020 22:40:02 +0100 schrieb Olaf Hering : > AC_PATH_PROG([PARTED], [parted], [], [$LIBVIRT_SBIN_PATH]) Is there a consensus now how to address this? >From what I understand, using just exec(BASENAME) to search for the binary in >PATH is acceptable. It may result in surprises on

Re: regression in meson build, AC_PATH_PROG lost

2020-11-23 Thread Neal Gompa
On Mon, Nov 23, 2020 at 11:24 AM Andrea Bolognani wrote: > > On Fri, 2020-11-20 at 08:51 -0500, Neal Gompa wrote: > > On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani > > wrote: > > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > > > The way I solved *that* specific problem was to

Re: regression in meson build, AC_PATH_PROG lost

2020-11-23 Thread Andrea Bolognani
On Fri, 2020-11-20 at 19:32 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: > > In my opinion this move would place a significant burden upon > > downstreams and users while taking very little burden away from > > upstream developers because,

Re: regression in meson build, AC_PATH_PROG lost

2020-11-23 Thread Andrea Bolognani
On Fri, 2020-11-20 at 08:51 -0500, Neal Gompa wrote: > On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani wrote: > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > > The way I solved *that* specific problem was to use zfs-fuse at > > > build-time and have runtime work with either

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Martin Kletzander
On Fri, Nov 20, 2020 at 07:32:44PM +0100, Pavel Hrdina wrote: On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > If you did that, then you wouldn't have

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Pavel Hrdina
On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > > If you did that, then you wouldn't have simplified meson.build much > > > while at the same time

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Andrea Bolognani
On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > If you did that, then you wouldn't have simplified meson.build much > > while at the same time you'd have ended up with a far less nuanced > > check that does not catch

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Pavel Hrdina
On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 14:36 +, Daniel P. Berrangé wrote: > > On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > > > Lastly, if we stopped looking for commands at build time we would be > > > enabling features

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Andrea Bolognani
On Fri, 2020-11-20 at 14:36 +, Daniel P. Berrangé wrote: > On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > > Lastly, if we stopped looking for commands at build time we would be > > enabling features that can, in reality, never work: iscsiadm, for > > example, is

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Daniel P . Berrangé
On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 13:58 +0100, Martin Kletzander wrote: > > On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: > > > While I would love the simplification such an approach would yield, > > > I have to point out

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Andrea Bolognani
On Fri, 2020-11-20 at 13:58 +0100, Martin Kletzander wrote: > On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: > > While I would love the simplification such an approach would yield, > > I have to point out that there is at least one advantage to checking > > for the availability

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Neal Gompa
On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani wrote: > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani > > wrote: > > > As another data point, Debian currently carries a patch[1] which > > > allows us to enable the ZFS driver

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Martin Kletzander
On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-20 at 01:19 +0100, Pavel Hrdina wrote: On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > Right now, IMHO, all meson checks for binaries that are not needed at build time > should be removed.

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Martin Kletzander
On Fri, Nov 20, 2020 at 01:19:33AM +0100, Pavel Hrdina wrote: On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: > Am Thu, 19 Nov 2020 22:15:27 +0100 > schrieb Martin Kletzander : > > > Libvirt needs to be able to

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Andrea Bolognani
On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani wrote: > > As another data point, Debian currently carries a patch[1] which > > allows us to enable the ZFS driver without installing the ZFS > > packages in the build environment: this is

Re: regression in meson build, AC_PATH_PROG lost

2020-11-20 Thread Andrea Bolognani
On Fri, 2020-11-20 at 01:19 +0100, Pavel Hrdina wrote: > On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > > Right now, IMHO, all meson checks for binaries that are not needed at build > > time > > should be removed. During runtime we can just use the name of the binary. > >

Re: regression in meson build, AC_PATH_PROG lost

2020-11-19 Thread Pavel Hrdina
On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: > > Am Thu, 19 Nov 2020 22:15:27 +0100 > > schrieb Martin Kletzander : > > > > > Libvirt needs to be able to handle that missing binary at runtime anyway > > > > It

Re: regression in meson build, AC_PATH_PROG lost

2020-11-19 Thread Martin Kletzander
On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: Am Thu, 19 Nov 2020 22:15:27 +0100 schrieb Martin Kletzander : Libvirt needs to be able to handle that missing binary at runtime anyway It also needs to handle an existing binary. Just how is it supposed to handle it? Um... run

Re: regression in meson build, AC_PATH_PROG lost

2020-11-19 Thread Neal Gompa
On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani wrote: > > On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote: > > On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > > > Since meson does not support environment variables it seems the > > > only way to address this is to introduce

Re: regression in meson build, AC_PATH_PROG lost

2020-11-19 Thread Olaf Hering
Am Thu, 19 Nov 2020 22:15:27 +0100 schrieb Martin Kletzander : > Libvirt needs to be able to handle that missing binary at runtime anyway It also needs to handle an existing binary. Just how is it supposed to handle it? Right now with meson it is either a full path, or just the name in case it

Re: regression in meson build, AC_PATH_PROG lost

2020-11-19 Thread Martin Kletzander
On Fri, Nov 13, 2020 at 02:13:38PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote: On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > Since meson does not support environment variables it seems the > only way to address this is to introduce an

Re: regression in meson build, AC_PATH_PROG lost

2020-11-13 Thread Andrea Bolognani
On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote: > On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > > Since meson does not support environment variables it seems the > > only way to address this is to introduce an option in > > meson_options.txt for each runtime executable. > >

Re: regression in meson build, AC_PATH_PROG lost

2020-11-13 Thread Pavel Hrdina
On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > autoconf allows to specify the path to a runtime binary that is not required > during build via an environment variable: > AC_PATH_PROG([PARTED], [parted], [], [$LIBVIRT_SBIN_PATH]) > > meson lacks such essential feature. As a result

regression in meson build, AC_PATH_PROG lost

2020-11-12 Thread Olaf Hering
autoconf allows to specify the path to a runtime binary that is not required during build via an environment variable: AC_PATH_PROG([PARTED], [parted], [], [$LIBVIRT_SBIN_PATH]) meson lacks such essential feature. As a result the package build environment needs to have more packages than