Re: [libvirt] Question about html file in docs

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 09:56:00AM +0900, Atsushi SAKAI wrote: Hi, I think html files in docs directory are redundunt. It is because html file is created by html.in. May I remove these files? No Or are there any reason about staying these files? Because the web site is a CVS checkout

[libvirt] virt-install?

2008-08-13 Thread Jun Koi
Hi, I got the libvirt source code (cvs), and compiled. However, I cannot find the virt-install anywhere. Is it included inside libvirt? Thank you, Jun -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Re: virDomainMemoryPeek for Xen?

2008-08-13 Thread Richard W.M. Jones
On Wed, Aug 13, 2008 at 01:19:42PM +0900, Jun Koi wrote: According to the comment in your driver code for virDomainMemoryPeek, libvirt is not currently supporting Xen. Why is that? As far as I see, Xen is use the same GPL2 version as libvirt. I am thinking about implementing the driver for

Re: [libvirt] Question about html file in docs

2008-08-13 Thread Atsushi SAKAI
Hi, Daniel If I run the make on libvirt, cvs diff outputs large diffs on html. This is because the difference of html and html.in is large. I think it should be fixed. How do you think? Thanks Atsushi SAKAI Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Aug 13, 2008 at 09:56:00AM +0900,

Re: [libvirt] virt-install?

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 04:35:00PM +0900, Jun Koi wrote: Hi, I got the libvirt source code (cvs), and compiled. However, I cannot find the virt-install anywhere. Is it included inside libvirt? No, a companion of virt-manager project see http://virt-manager.org/scmrepo.html to fetch the

Re: [libvirt] virt-install?

2008-08-13 Thread Jun Koi
On Wed, Aug 13, 2008 at 4:43 PM, Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Aug 13, 2008 at 04:35:00PM +0900, Jun Koi wrote: Hi, I got the libvirt source code (cvs), and compiled. However, I cannot find the virt-install anywhere. Is it included inside libvirt? No, a companion of

Re: [libvirt] Question about html file in docs

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 03:34:33AM -0400, Daniel Veillard wrote: On Wed, Aug 13, 2008 at 09:56:00AM +0900, Atsushi SAKAI wrote: Hi, I think html files in docs directory are redundunt. It is because html file is created by html.in. May I remove these files? No Or are there any

Re: [libvirt] Re: virDomainMemoryPeek for Xen?

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 08:33:24AM +0100, Richard W.M. Jones wrote: On Wed, Aug 13, 2008 at 01:19:42PM +0900, Jun Koi wrote: According to the comment in your driver code for virDomainMemoryPeek, libvirt is not currently supporting Xen. Why is that? As far as I see, Xen is use the same GPL2

Re: [libvirt] virt-install?

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 04:59:35PM +0900, Jun Koi wrote: On Wed, Aug 13, 2008 at 4:43 PM, Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Aug 13, 2008 at 04:35:00PM +0900, Jun Koi wrote: Hi, I got the libvirt source code (cvs), and compiled. However, I cannot find the virt-install

[libvirt] [PATCH] get memory in openvz driver

2008-08-13 Thread Evgeniy Sokolov
OpenVZ has several parameters for memory management. All of them can be configured independetly. Patch allow to get configuration of memory from container config and then calculate total usage of memory. It is open question how to manage memory? Index: src/openvz_conf.c

[libvirt] PATCH: 0/5: Enhancing the virExec function

2008-08-13 Thread Daniel P. Berrange
The following series of patches do a bunch of work on the virExec function. Overall this leads to a more robust implementation with better error reporting, and an increased level functionality. This lets us remove all uses of fork/exec in libvirt and replace them with virExec. This was all

Re: [libvirt] PATCH: 1/5: Improved error reporting

2008-08-13 Thread Daniel P. Berrange
There are several system calls in the virExec function for which we don't or can't report errors. This patch does a couple of things to improve the situation. It moves the code for setting non-block/close-exec to before the fork() so we can report errors for it. It removes the 'dom' and 'net'

Re: [libvirt] PATCH: 2/5: Fix signal handler race condition

2008-08-13 Thread Daniel P. Berrange
This is the same patch from yesterday to fix the signal handler race condition. We block signals before doing a fork(), and then in the child reset all signal handlers before finally unblocking all signals. The parent will restore its original signal mask after fork. I've fixed the incorrect

Re: [libvirt] PATCH: 3/5: Allow FD for stdout/err to be passed in

2008-08-13 Thread Daniel P. Berrange
The contract for virExec() currently allows the caller to pass in a NULL for stdout/err parameters in which case the child will be connected to /dev/null, or they can pass in a pointer to an int, in which case the child will be connected to a pair of pipes, and the read end of the pipe is returned

Re: [libvirt] PATCH: 4/5: Support daemonizing child env variables

2008-08-13 Thread Daniel P. Berrange
Some of the existing usage of fork/exec in libvirt is done such that the child process is daemonized. In particular the libvirt_proxy and the auto-spawned libvirtd for qemu:///session. Since we want to switch these to use virExec, we need to suport a daemon mode. This patch removes the two

Re: [libvirt] PATCH: 5/5: Make all code use virExec

2008-08-13 Thread Daniel P. Berrange
This final patch switches over all places which do fork()/exec() to use the new enhanced virExec() code. A fair amount of code is deleted, but that's not the whole story - the new impl is more robust that most of the existing code we're deleting here. bridge.c | 51 +++-

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-13 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 11:58:12PM -0400, Cole Robinson wrote: Daniel Veillard wrote: Fine by me, my only worry is that we are somehow breaking the storage XML format as a result, but I don't think this is widely used at this point (at least with MSDos) and best done earlier than later,

Re: [libvirt] Question about html file in docs

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 04:37:27PM +0900, Atsushi SAKAI wrote: Hi, Daniel If I run the make on libvirt, cvs diff outputs large diffs on html. This is because the difference of html and html.in is large. What kind of diff do you get ? The html output should only be dependant on the html.in

Re: [libvirt] Question about html file in docs

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 09:35:04AM +0100, Daniel P. Berrange wrote: On Wed, Aug 13, 2008 at 03:34:33AM -0400, Daniel Veillard wrote: On Wed, Aug 13, 2008 at 09:56:00AM +0900, Atsushi SAKAI wrote: Hi, I think html files in docs directory are redundunt. It is because html file is

Re: [libvirt] PATCH: 1/7: Removing state from lxc_vm_t

2008-08-13 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 12:25:52PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: This patch does some simple re-factoring of the way the TTYs and control socket are handled to reduce the amount of state stored in the lxc_vm_t structure, in preparation for the

Re: [libvirt] PATCH: 1/7: Removing state from lxc_vm_t

2008-08-13 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 12:50:46PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: This patch does some simple re-factoring of the way the TTYs and control socket are handled to reduce the amount of state stored in the lxc_vm_t structure, in preparation for the

Re: [libvirt] PATCH: 2/7: Re-arrange methods acros LXC source files

2008-08-13 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 07:16:20PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: The lxc_driver.c file contains quite a large amount of code, serving two reasonably well separated purposes. First there is the direct implemntation of each of the libvirt driver

Re: [libvirt] PATCH: 3/7:

2008-08-13 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 11:07:00AM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: diff -r 8093fb566748 src/lxc_conf.c diff -r 8093fb566748 src/lxc_conf.h --- a/src/lxc_conf.hFri Aug 01 14:47:33 2008 +0100 +++ b/src/lxc_conf.hTue Aug 05 12:13:24 2008

Re: [libvirt] [PATCH] Fix size reporting for disk pools without partitions

2008-08-13 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 11:58:23PM -0400, Cole Robinson wrote: The attached patch updates parthelper to print size information for a disk device if it doesn't have any allocated partitions. The current code starts by requesting the first partition, then iterating from there. But if there is

Re: [libvirt] virt-install?

2008-08-13 Thread Jun Koi
On Wed, Aug 13, 2008 at 5:43 PM, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Aug 13, 2008 at 04:59:35PM +0900, Jun Koi wrote: On Wed, Aug 13, 2008 at 4:43 PM, Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Aug 13, 2008 at 04:35:00PM +0900, Jun Koi wrote: Hi, I got the libvirt

Re: [libvirt] Question about html file in docs

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 05:51:25AM -0400, Daniel Veillard wrote: On Wed, Aug 13, 2008 at 04:37:27PM +0900, Atsushi SAKAI wrote: Hi, Daniel If I run the make on libvirt, cvs diff outputs large diffs on html. This is because the difference of html and html.in is large. We investigated

Re: [libvirt] PATCH: 4/7: Convert LXC to new domain APIs

2008-08-13 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 04:39:05PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: The re-architecting of the LXC controller/container process relationship in the previous patch removed the last obstacle to switching over to the generic domain XML routines. So this

Re: [libvirt] [PATCH] check for XHTML1 DTDs availability

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 08:10:36AM -0400, Daniel Veillard wrote: Well apparently the XSL output is post-processed by xmlling --valid --format which then introduce a dependancy on the XHTML1 DTDs . If you don't have them installed locally you will get validation error messages when building

[libvirt] [PATCH] manage number of virtual CPUs

2008-08-13 Thread Evgeniy Sokolov
OpenVZ containers use all CPUs available in system by default. Limitations may be caused only by Linux kernel limitation. There is way to artificially limit number of CPUs. patch add cpu management functionality to OpenVZ driver. Index: openvz_conf.c

Re: [libvirt] [PATCH] check for XHTML1 DTDs availability

2008-08-13 Thread Chris Lalancette
Daniel Veillard wrote: On Wed, Aug 13, 2008 at 08:10:36AM -0400, Daniel Veillard wrote: Well apparently the XSL output is post-processed by xmlling --valid --format which then introduce a dependancy on the XHTML1 DTDs . If you don't have them installed locally you will get validation error

[libvirt] PATCH: 0/4: Make LXC controller a separate binary

2008-08-13 Thread Daniel P. Berrange
Currently libvirt is just forking off a child process to handle the LXC I/O controller. This works OK, but is kinda evil. This series of patches makes it into a fully-fledged exec()able binary. With a tiny bit more work, you could even use this to launch an LXC container standalone without

Re: [libvirt] PATCH: 2/4: Restructure sources files in Makefile.am

2008-08-13 Thread Daniel P. Berrange
Over time we've added lots of general purpose source code files, as wel as making more of the existing ones conditionally compiled. We've done this by adding lots of #ifdef WITH_ macros across the various source files. This is becoming rather a minefield with soo many conditionals sprinkled

Re: [libvirt] PATCH: 1/5: Improved error reporting

2008-08-13 Thread Cole Robinson
Daniel P. Berrange wrote: There are several system calls in the virExec function for which we don't or can't report errors. This patch does a couple of things to improve the situation. It moves the code for setting non-block/close-exec to before the fork() so we can report errors for it. It

Re: [libvirt] PATCH: 3/4: Introduce libvirt_lxc binary

2008-08-13 Thread Daniel P. Berrange
This patch is the important one, switching from an I/O controller which is simply fork'd off libvirtd, to a properly execable libvirt_lxc binary. The libvirtd LXC driver writes the config it wants to launch with to /var/run/libvirt/lxc/NAME.log and invokves libvirt_lxc --name NAME This

Re: [libvirt] PATCH: 4/4: Add pivot_root support to container

2008-08-13 Thread Daniel P. Berrange
This isn't really related to the others, except for the fact that is part of the LXC driver. This is a re-post of the patch I did for adding support for pivot_root() in the container. This allows the entire container FS to be separated from the parent OS. As noted previously this is not currently

Re: [libvirt] PATCH: 1/5: Improved error reporting

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 10:21:59AM -0400, Cole Robinson wrote: Daniel P. Berrange wrote: There are several system calls in the virExec function for which we don't or can't report errors. This patch does a couple of things to improve the situation. It moves the code for setting

[libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2008-08-13 Thread Mark McLoughlin
Hey, Here's a patch that allows libvirt created guests to use KVM's recent GSO support in order to increase the throughput achieved with virtio_net network interfaces. We shouldn't apply this yet - we need the kernel and kvm TUNGETIFF patches to be applied first - so this is just intended as an

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 03:53:27PM +0100, Mark McLoughlin wrote: By enabling this flag on the tap fds we create, we greatly increase the achievable throughput with virtio_net. However, we need to be careful to only set the flag when a) KVM has support for this ABI and b) the value of the

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2008-08-13 Thread Mark McLoughlin
On Wed, 2008-08-13 at 16:01 +0100, Daniel P. Berrange wrote: On Wed, Aug 13, 2008 at 03:53:27PM +0100, Mark McLoughlin wrote: By enabling this flag on the tap fds we create, we greatly increase the achievable throughput with virtio_net. However, we need to be careful to only set the flag

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2008-08-13 Thread Mark McLoughlin
On Wed, 2008-08-13 at 15:53 +0100, Mark McLoughlin wrote: +net-model !strcmp(net-model, virtio)) Should be: +net-model STREQ(net-model, virtio)) Cheers, Mark. -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] PATCH: 2/4: Restructure sources files in Makefile.am

2008-08-13 Thread Daniel Veillard
On Wed, Aug 13, 2008 at 03:17:09PM +0100, Daniel P. Berrange wrote: Over time we've added lots of general purpose source code files, as wel as making more of the existing ones conditionally compiled. We've done this by adding lots of #ifdef WITH_ macros across the various source files.

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2008-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2008 at 04:14:10PM +0100, Mark McLoughlin wrote: On Wed, 2008-08-13 at 16:01 +0100, Daniel P. Berrange wrote: On Wed, Aug 13, 2008 at 03:53:27PM +0100, Mark McLoughlin wrote: By enabling this flag on the tap fds we create, we greatly increase the achievable throughput with

[libvirt] [PATCH] fix minor typo

2008-08-13 Thread John Levon
Fix a typo in the message for the 'dump' command in virsh. Signed-off-by: John Levon [EMAIL PROTECTED] Index: src/virsh.c === RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.157 diff -u -r1.157 virsh.c ---

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-13 Thread Paul Moore
On Tuesday 12 August 2008 5:57:19 am James Morris wrote: On Tue, 12 Aug 2008, Russell Coker wrote: One thing that should be noted is the labelled network benefits. If you had several groups of virtual servers running at different levels and wanted to prevent information leaks then having

Re: [libvirt] PATCH: 3/4: Introduce libvirt_lxc binary

2008-08-13 Thread Dan Smith
DB This patch is the important one, switching from an I/O controller DB which is simply fork'd off libvirtd, to a properly execable DB libvirt_lxc binary. This works for me. The network interfaces aren't cleaned up properly on destroy, and I get an error from the kernel about a reference count

[libvirt] [PATCH] Fix serial console telnet protocol support

2008-08-13 Thread Mark McLoughlin
With e.g.: serial type='tcp' source mode='bind' host='127.0.0.1' service=''/ protocol type='telnet'/ target port='0'/ /serial You currently get: Unknown option: listen qemu: could not open serial device 'telnet:127.0.0.1:,listen' With the telnet protocol, qemu

Re: [libvirt] PATCH: 4/4: Add pivot_root support to container

2008-08-13 Thread Dan Smith
DB +#if 0 DB +ttyfd = open(argv-ttyPath, O_RDWR|O_NOCTTY); DB +if (ttyfd 0) { DB +lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, DB + _(open(%s) failed: %s), argv-ttyPath, strerror(errno)); DB +return -1; DB +} DB +#endif Should this bit be removed? DB

[libvirt] Reusing dumpxml output

2008-08-13 Thread Stefan de Konink
I would like to reuse configurations that have been edited using the libvirt api. For example by attaching interfaces. Now the output that dumpxml generates, is very 'specific' to an active configuration. I am not able to use a stored configuration from an active domain to redefine it after it

Re: [libvirt] [PATCH] check for XHTML1 DTDs availability

2008-08-13 Thread Atsushi SAKAI
Hi, Daniel I need to set http_proxy on my environment. (Sorry, since I need not set http_proxy since I use wget and cvs only) But still stays large diffs on html 6 files. drvqemu.html formatnetwork.html formatstorage.html intro.html news.html remote.html Thanks Atsushi SAKAI Daniel