Re: [libvirt] [PATCH v3 00/12] PCI passthrough support on s390

On Mon, 13 Aug 2018 12:46:16 +0800 Yi Min Zhao wrote: > Is there any comment? I expect comments from all of you. Well, I don't have any objections from my side, but you need the libvirt folks' opinion on this. > > > 在 2018/8/7 下午5:10, Yi Min Zhao 写道: > > Abstract > > > > The PCI repr

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: > Ivan Mishonov wrote: > > > Yes, that makes sense. I'll try to find some time next week to redo my > > code and send another patch. Since my time for working on libvirt is > > very limited can you confirm that the LPC configur

Re: [libvirt] [RFC 0/2] util: introduce timeout mode in virCommandRun/Async and virKModLoad

On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote: > Hi, everyone! > It's possible that the running-time of a command is long than its caller > expected. Perhaps, it's useful to provide timeout mode for virCommandRun or > virCommandRunAsync + virCommandWait. And The caller can restrict the >

Re: [libvirt] [PATCH v3 3/3] storage: add wipeVol to iscsi-direct storage backend

On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote: > From: Clementine Hayat > > Signed-off-by: Clementine Hayat > --- > src/storage/storage_backend_iscsi_direct.c | 121 - > 1 file changed, 120 insertions(+), 1 deletion(-) > > diff --git a/src/storage/storage_backend_iscsi_di

Re: [libvirt] [PATCH v3 2/3] storage: add SetConnection to iscsi-direct backend

On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote: > From: Clementine Hayat > > The code to set the connection and connect using libiscsi will always be > the same. Add function to avoid code duplication. > > Signed-off-by: Clementine Hayat > --- > src/storage/storage_backend_iscsi_direct.c | 38

Re: [libvirt] [PATCH v3 0/3] add wipeVol to iscsi-direct

On 08/13/2018 12:26 AM, c...@lse.epita.fr wrote: > From: Clementine Hayat > > Hello, > > This series of patch is the follow up of: > v1:https://www.redhat.com/archives/libvir-list/2018-August/msg00557.html > v2:https://www.redhat.com/archives/libvir-list/2018-August/msg00570.html > > Best Regar

Re: [libvirt] [PATCH] qemu:Fix snapshot creating with vm xml persistent

On Thu, Aug 09, 2018 at 17:01:49 +0200, Michal Privoznik wrote: > On 08/07/2018 01:46 PM, Bobo Du wrote: > > the vm xml will be existed when the vm is undefined after started. > > blockcommit interface also has the bug with above. > > Step1:prepare a vm，eg:test1,start it and undefined > > Step2: vi

[libvirt] [PATCH] storage: Properly terminate secrets

The virSecretGetSecretString() helper looks up a secret for given pool and returns its value in @secret_value and its length in @secret_value_size. However, the trailing '\0' is not included in either of the variables. This is because usually the value of the secret is passed to some encoder (usual

[libvirt] [PATCH 0/2] Couple of almost trivial memleak fixes

*** NOT PUSHED. PLEASE REVIEW *** Michal Prívozník (2): virnetdevip: Free data.devices in virNetDevIPCheckIPv6Forwarding() too networkStartNetworkVirtual: Don't leak macmap object src/network/bridge_driver.c | 2 ++ src/util/virnetdevip.c | 3 +-- 2 files changed, 3 insertions(+), 2 del

[libvirt] [PATCH 1/2] virnetdevip: Free data.devices in virNetDevIPCheckIPv6Forwarding() too

We are freeing the individual strings (which were filled by virNetDevIPCheckIPv6ForwardingCallback()) but not the array itself. Signed-off-by: Michal Privoznik --- src/util/virnetdevip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virne

[libvirt] [PATCH 2/2] networkStartNetworkVirtual: Don't leak macmap object

When starting network a macmap object is created (which stores MAC -> domain name mappings). However, if something goes wrong (e.g. virNetDevIPCheckIPv6Forwarding() fails) then the object is leaked. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 2 ++ 1 file changed, 2 inserti

Re: [libvirt] [PATCH 1/2] Add API for printing tables.

On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote: > On 08/10/2018 11:11 AM, Simon Kobyda wrote: > > It solves problems with alignment of columns. Width of each column > > is calculated by its biggest cell. Should solve unicode bug. > > In future, it may be implemented in virsh, virt-admin.

Re: [libvirt] [PATCH 1/2] Add API for printing tables.

On 08/13/2018 11:46 AM, Simon Kobyda wrote: > On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote: >> On 08/10/2018 11:11 AM, Simon Kobyda wrote: >>> +static vshTableRowPtr >>> +vshTableRowNew(size_t size, const char *arg, va_list ap) >> >> I know we discussed this in person, but now that I

Re: [libvirt] [PATCH 2/2] networkStartNetworkVirtual: Don't leak macmap object

On Mon, Aug 13, 2018 at 11:21:45AM +0200, Michal Privoznik wrote: > When starting network a macmap object is created (which stores > MAC -> domain name mappings). However, if something goes wrong > (e.g. virNetDevIPCheckIPv6Forwarding() fails) then the object is > leaked. > > Signed-off-by: Michal

Re: [libvirt] [PATCH 1/2] virnetdevip: Free data.devices in virNetDevIPCheckIPv6Forwarding() too

On Mon, Aug 13, 2018 at 11:21:44AM +0200, Michal Privoznik wrote: > We are freeing the individual strings (which were filled by > virNetDevIPCheckIPv6ForwardingCallback()) but not the array > itself. > > Signed-off-by: Michal Privoznik > --- > src/util/virnetdevip.c | 3 +-- > 1 file changed, 1 i

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote: On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: Ivan Mishonov wrote: Yes, that makes sense. I'll try to find some time next week to redo my code and send another patch. Since my time for working on libvirt is very limited

[libvirt] [PATCH] storage: Don't hold storage pool locked during wipeVol

Currently the way virStorageVolWipe() works is it looks up pool containing given volume and hold it locked throughout while API execution. This is suboptimal because wiping a volume means writing data to it which can take ages. And if the whole pool is locked during that operation no other API can

Re: [libvirt] [PATCH v3 07/11] util: netdev: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Thu, Aug 09, 2018 at 09:42:15AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOFREE macro for declaring scalar variables, majority > of the VIR_FREE calls can be dropped, which in turn leads to > getting rid of most of our cleanup sections. >

Re: [libvirt] [PATCH v3 08/11] util: netdev: use VIR_AUTOPTR for aggregate types

On Thu, Aug 09, 2018 at 09:42:16AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our

Re: [libvirt] [PATCH v3 09/11] util: netdevip: use VIR_AUTOPTR for aggregate types

On Thu, Aug 09, 2018 at 09:42:17AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our

Re: [libvirt] [RFC 0/2] util: introduce timeout mode in virCommandRun/Async and virKModLoad

On Monday, August 13, 2018 at 10:02 AM, Daniel P. Berrangé wrote: >On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote: >> Hi, everyone! >> It's possible that the running-time of a command is long than its caller >> expected. Perhaps, it's useful to provide timeout mode for virCommandRun or >>

Re: [libvirt] [PATCH v3 10/11] util: netdevopenvswitch: use VIR_AUTOPTR for aggregate types

On Thu, Aug 09, 2018 at 09:42:18AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our

Re: [libvirt] [PATCH v3 01/11] util: iscsi: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Thu, Aug 09, 2018 at 09:42:09AM +0530, Sukrit Bhatnagar wrote: > Add another usage for VIR_AUTOFREE macro which was left in the > commit ec3e878, thereby dropping a VIR_FREE call and and a cleanup > section. > > Signed-off-by: Sukrit Bhatnagar > --- > src/util/viriscsi.c | 22 ++---

Re: [libvirt] [PATCH v3 02/11] util: netlink: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

On Thu, Aug 09, 2018 at 09:42:10AM +0530, Sukrit Bhatnagar wrote: > Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in > src/util/viralloc.h, define a new wrapper around an existing > cleanup function which will be called when a variable declared > with VIR_AUTOPTR macro goes out of scope. Also

Re: [libvirt] [RFC 0/2] util: introduce timeout mode in virCommandRun/Async and virKModLoad

On Mon, Aug 13, 2018 at 07:37:33PM +0800, shilei.massclo...@gmx.com wrote: > On Monday, August 13, 2018 at 10:02 AM, Daniel P. Berrangé wrote: > >On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote: > >> Hi, everyone! > >> It's possible that the running-time of a command is long than its caller

[libvirt] [PATCH 00/16] Revert Jansson usage

For QEMU, we need a JSON parser that is able to handle its non-compliant JSON usage: https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Unfortunately, this does not seem to be possible with Jansson. Revert back to using yajl, which also lets us get rid of the 'dlopen' hacks and their bugfixes.

[libvirt] [PATCH 01/16] Revert "src: Move DLOPEN_LIBS to libraries introducing the dependency"

This reverts commit 5d40272ea67c74049600e120095d1b42287ed2d2. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- src/Makefile.am | 2 -- src/util/Makefile.inc.am | 1 - tools/Makefile.am

[libvirt] [PATCH 04/16] Revert "util: jsoncompat: Stub out virJSONInitialize when compiling without jansson"

This reverts commit 9e44c2db8ad94d3c20acc1d081538c280af198b4. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- src/util/virjsoncompat.c | 13 + 1 file changed, 1 insertion(+), 12 deletions

[libvirt] [PATCH 02/16] Revert "Fix link errors in tools/nss and tests"

This reverts commit b3d9b08ef797e569b14cfa42d3dceba23c2a5b14. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- tools/Makefile.am | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 05/16] Revert "tests: qemucapsprobe: Fix output after switching to jansson"

This reverts commit 397447f80588438545994a86883792a5999cad15. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- tests/qemucapsprobemock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/qemu

[libvirt] [PATCH 03/16] Revert "remote: daemon: Make sure that JSON symbols are properly loaded at startup"

This reverts commit 3251fc9c9b9639c3fec3181530599415523d671a. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 4 src/remote/remote_daemon.c | 4 2 files changed

[libvirt] [PATCH 07/16] Revert "tests: also skip qemuagenttest with old jansson"

This reverts commit c31146685f5c8558ff88d52d03a68533c9220feb. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- tests/qemuagenttest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[libvirt] [PATCH 15/16] Revert "build: undef WITH_JANSSON for SETUID_RPC_CLIENT"

This reverts commit 93fdc9e0b0cbb2eec32745a868ac4633f0912ad5. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- config-post.h | 1 - 1 file changed, 1 deletion(-) diff --git a/config-post.h b/config-p

[libvirt] [PATCH 06/16] Revert "util: avoid symbol clash between json libraries"

This reverts commit ce3c6ef6843f98d81be5423ece11fad79eaab920. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- libvirt.spec.in | 2 - src/Makefile.am | 8 +- src/util/Makefile.in

[libvirt] [PATCH 09/16] Revert "build: require Jansson if QEMU driver is enabled"

This reverts commit 01ce04375c3348fd683475e5aa5231149ef6a78a. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 3 --- 1 file changed, 3 deletions(-) diff --git a/m4/virt-driv

[libvirt] [dbus PATCH 1/2] configure: Fix quoting

Macro arguments are supposed to be quoted. Signed-off-by: Andrea Bolognani --- configure.ac | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/configure.ac b/configure.ac index 8917b37..22d80dd 100644 --- a/configure.ac +++ b/configure.ac @@ -1,6

[libvirt] [dbus PATCH 2/2] configure: Call PKG_CHECK_MODULES() correctly

Most of the calls where missing the dollar sign when referencing variables, which caused the corresponding version checks to be skipped. Signed-off-by: Andrea Bolognani --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 22

[libvirt] [PATCH 11/16] Revert "Remove virJSONValueNewStringLen"

This reverts commit 8f802c6d8659beb9eb3cab96ba2553e251728337. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 1 + src/util/virjson.c | 22 ++ sr

[libvirt] [PATCH 10/16] Revert "build: switch --with-qemu default from yes to check"

This reverts commit c5ae8e0c2b4b6bb3c667cfadaf65a66c3f4f3d85. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff -

[libvirt] [PATCH 12/16] Revert "build: remove references to WITH_YAJL for SETUID_RPC_CLIENT"

This reverts commit 1caf8441604b58e4a89aa2c09975b8346928c52a. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- config-post.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config-post.h b/confi

[libvirt] [PATCH 16/16] Revert "build: add --with-jansson"

This reverts commit 12b34f094e2f1c7f414f4bb8f880a9d65c8fcd85. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Conflicts: configure.ac: Commit 8aa85e0b introduced LIBVIRT_*_LIBISCSI macros. Signed-off-by: Ján Tomko --- con

[libvirt] [PATCH 08/16] Revert "m4: Introduce STABLE_ORDERING_JANSSON"

This reverts commit 4dd60540007042bfc0087a67f57f3e9f3311a84a. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- m4/virt-jansson.m4 | 3 --- tests/qemublocktest.c| 5 - tests/qemuc

[libvirt] [dbus PATCH 0/2] configure: Various fixes

Andrea Bolognani (2): configure: Fix quoting configure: Call PKG_CHECK_MODULES() correctly configure.ac | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinf

[libvirt] [PATCH 13/16] Revert "Remove functions using yajl"

This reverts commit bf114decb34f21cd225ead6dc4d929d35a8c5fe5. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- src/util/virjson.c | 529 - 1 file ch

[libvirt] [PATCH 14/16] Revert "Switch from yajl to Jansson"

This reverts commit 9cf38263d05ca7f27dbbd9b1a0b48d338d9280e2. Jansson cannot parse QEMU's quirky JSON. Revert back to yajl. https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Signed-off-by: Ján Tomko --- libvirt.spec.in | 4 +- m4/virt-nss.m4

[libvirt] [PATCH] qemu-doc: mark ppc/prep machine as deprecated

40p machine type should be used instead. Signed-off-by: Hervé Poussineau --- qemu-deprecated.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 9920a85adc..9c7ff3fe2d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -21

Re: [libvirt] [Qemu-devel] [PATCH] qemu-doc: mark ppc/prep machine as deprecated

On 10/08/18 23:46, Hervé Poussineau wrote: > 40p machine type should be used instead. > > Signed-off-by: Hervé Poussineau > --- > qemu-deprecated.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 9920a85adc..9c7ff3fe2d 10064

[libvirt] [jenkins-ci PATCH 1/2] projects: Don't build libvirt-dbus on Debian 8

Turns out Debian 8 includes GLib 2.42 whereas libvirt-dbus requires at least GLib 2.44 to build. I had accidentally installed GLib 2.48 from backports on my local Debian 8 guests, which explains how the build could succeed during testing. This reverts commit d9acf6fe3f22b2acf2d849890d1fcfdcc09ef6

[libvirt] [jenkins-ci PATCH 2/2] guests: Don't prepare Debian 8 for libvirt-dbus

We're no longer attempting the build, which was failing anyway, so no point in installing the dependencies. This reverts commit ef2b446ecb77cefa2f041e9ad03124bbc13d22c3. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-debian-8/main.yml | 1 - 1 file changed, 1 deletion(-) diff --g

[libvirt] [jenkins-ci PATCH 0/2] Don't build libvirt-dbus on Debian 8

I thought that it would work, but I was clearly mistaken :/ Andrea Bolognani (2): projects: Don't build libvirt-dbus on Debian 8 guests: Don't prepare Debian 8 for libvirt-dbus guests/host_vars/libvirt-debian-8/main.yml | 1 - projects/libvirt-dbus.yaml | 1 - 2 files changed

Re: [libvirt] [dbus PATCH 1/4] tests: Drop pytest.mark.usefixtures from test_nodedev

On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote: We're already using node_device_create explicitly for all test cases in order to retrieve the result of the fixture, so using pytest.mark.usefixtures as well is pointless. Additionally, we're soon going to add some test cases wher

Re: [libvirt] [PATCH v3 03/11] util: netlink: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Thu, Aug 09, 2018 at 09:42:11AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOFREE macro for declaring scalar variables, majority > of the VIR_FREE calls can be dropped, which in turn leads to > getting rid of most of our cleanup sections. >

Re: [libvirt] [jenkins-ci PATCH 0/2] Don't build libvirt-dbus on Debian 8

On Mon, Aug 13, 2018 at 02:08:30PM +0200, Andrea Bolognani wrote: > I thought that it would work, but I was clearly mistaken :/ > > Andrea Bolognani (2): > projects: Don't build libvirt-dbus on Debian 8 > guests: Don't prepare Debian 8 for libvirt-dbus Reviewed-by: Daniel P. Berrangé Regar

[libvirt] [PATCH] virsh: Add missed fields to pool-define-as item entry

Commit id d45bee449 updated the pool-define-as qualifier descriptions to add some new fields, but neglected to modify the command item list in order to add those fields as well. Signed-off-by: John Ferlan --- Discovered by QE while validating bz1601377. tools/virsh.pod | 4 +++- 1 file change

Re: [libvirt] [PATCH v3 03/11] util: netlink: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Thu, Aug 09, 2018 at 09:42:11AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOFREE macro for declaring scalar variables, majority > of the VIR_FREE calls can be dropped, which in turn leads to > getting rid of most of our cleanup sections. >

Re: [libvirt] [PATCH v3 04/11] util: netlink: use VIR_AUTOPTR for aggregate types

On Thu, Aug 09, 2018 at 09:42:12AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our

Re: [libvirt] [PATCH v3 05/11] util: netdevbridge: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Thu, Aug 09, 2018 at 09:42:13AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOFREE macro for declaring scalar variables, majority > of the VIR_FREE calls can be dropped, which in turn leads to > getting rid of most of our cleanup sections. >

Re: [libvirt] [PATCH v3 06/11] util: netdevbridge: use VIR_AUTOPTR for aggregate types

On Thu, Aug 09, 2018 at 09:42:14AM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOPTR macro for declaring aggregate pointer variables, > majority of the calls to *Free functions can be dropped, which > in turn leads to getting rid of most of our

Re: [libvirt] [PATCH 1/2] Add API for printing tables.

On Mon, 2018-08-13 at 12:01 +0200, Michal Prívozník wrote: > On 08/13/2018 11:46 AM, Simon Kobyda wrote: > > On Fri, 2018-08-10 at 15:40 +0200, Michal Privoznik wrote: > > > On 08/10/2018 11:11 AM, Simon Kobyda wrote: > > > > > > +static vshTableRowPtr > > > > +vshTableRowNew(size_t size, const c

Re: [libvirt] [PATCH 00/16] Revert Jansson usage

On Mon, Aug 13, 2018 at 01:55:10PM +0200, Ján Tomko wrote: For QEMU, we need a JSON parser that is able to handle its non-compliant JSON usage: https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Unfortunately, this does not seem to be possible with Jansson. Revert back to using yajl, which als

Re: [libvirt] [PATCH 00/16] Revert Jansson usage

On Mon, Aug 13, 2018 at 02:54:00PM +0200, Ján Tomko wrote: > On Mon, Aug 13, 2018 at 01:55:10PM +0200, Ján Tomko wrote: > > For QEMU, we need a JSON parser that is able to handle its non-compliant > > JSON usage: > > https://bugzilla.redhat.com/show_bug.cgi?id=1614569 > > > > Unfortunately, this d

Re: [libvirt] [PATCH] spec: Add libvirt-daemon-driver-storage-iscsi-direct

On 08/09/2018 01:44 AM, Cole Robinson wrote: > Signed-off-by: Cole Robinson > --- > libvirt.spec.in | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) ACK Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] esx: Fix build when libcurl debug is enabled

On 08/11/2018 04:39 PM, Marcos Paulo de Souza wrote: > When building libvirt with libcurl debug enabled (with > ESX_VI__CURL__ENABLE_DEBUG_OUTPUT set), the message bellow pops up: > > make[3]: Entering directory '/mnt/data/gitroot/libvirt/src' > CC esx/libvirt_driver_esx_la-esx_vi.lo > esx

Re: [libvirt] [PATCH 00/16] Revert Jansson usage

On Mon, Aug 13, 2018 at 01:58:56PM +0100, Daniel P. Berrangé wrote: On Mon, Aug 13, 2018 at 02:54:00PM +0200, Ján Tomko wrote: On Mon, Aug 13, 2018 at 01:55:10PM +0200, Ján Tomko wrote: > For QEMU, we need a JSON parser that is able to handle its non-compliant > JSON usage: > https://bugzilla.re

Re: [libvirt] [PATCH] esx: Fix nodeGetInfo so cpu model fits inside nodeinfo->model

On 08/12/2018 01:05 PM, Marcos Paulo de Souza wrote: > Commit 6c0d0210cbcd5d647f0d882c07f077d444bc707d changed the behavior of > virStr*cpy* functions, so now the nodeGetInfo call fails. Version 4.1.0 > (default for Fedora 28) works: > > Model: Intel Core i7-4500U CPU @ 1.80G > > Current master t

Re: [libvirt] [PATCH] virsh: Add missed fields to pool-define-as item entry

On 08/13/2018 02:25 PM, John Ferlan wrote: > Commit id d45bee449 updated the pool-define-as qualifier descriptions > to add some new fields, but neglected to modify the command item list > in order to add those fields as well. > > Signed-off-by: John Ferlan > --- > > Discovered by QE while vali

[libvirt] [PATCH] qemu: Prefer nvdimmPath over hugepages for memory-backend-file

If a domain has hugepages configured and we're currently building memory-backend-file for a nvdimm device that domain has we will put hugepages path onto the command line. It should have been nvdimm path configured in the XML. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH] qemu: Prefer nvdimmPath over hugepages for memory-backend-file

On Mon, Aug 13, 2018 at 04:13:31PM +0200, Michal Privoznik wrote: > If a domain has hugepages configured and we're currently building > memory-backend-file for a nvdimm device that domain has we will > put hugepages path onto the command line. It should have been > nvdimm path configured in the XML

Re: [libvirt] [PATCH 00/16] Revert Jansson usage

On 08/13/2018 06:55 AM, Ján Tomko wrote: For QEMU, we need a JSON parser that is able to handle its non-compliant JSON usage: https://bugzilla.redhat.com/show_bug.cgi?id=1614569 QEMU is not non-compliant in its use of JSON. Rather, https://tools.ietf.org/html/rfc7159 states that "This specif

[libvirt] [PATCH] vircgroup: fix MinGW build

Broken by commit <901d2b9c87>. Signed-off-by: Pavel Hrdina --- Pushed under build-breaker rule. src/util/vircgroup.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 0ed83932ac..df38bb77e0 100644 --- a/src/util/vircgroup.c +

[libvirt] [PATCH 3/4] apparmor: allow expected /tmp access patterns

Several cases were found needing /tmp, for example ceph will try to list /tmp and the samba feature of qemu will place things in /tmp/qemu-smb.*. This is sort of safe because: - While /tmp could contain anything it is not recommended to put critical data there anyway - We restrict general acce

[libvirt] [PATCH 1/4] apparmor: allow openGraphicsFD for virt manager >1.4

virt-manager's UI connection will need socket access for openGraphicsFD to work - otherwise users will face a failed connection error when opening the UI view. Depending on the exact versions of libvirt and qemu involved this needs either a rule from qemu to libvirt or vice versa. Signed-off-by:

[libvirt] [PATCH 0/4] Extend apparmor rules for libvirt 4.6

Hi, this is a summary of things I had to touch recently when working on 4.6. The first two patches are re-submissions and modifications of last year which were never totally challenged, but also not pushed yet (I had no permissions yet back then). The first was lost in a discussion about virt-aa-h

[libvirt] [PATCH 2/4] apparmor: add mediation rules for unconfined guests

If a guest runs unconfined , but libvirtd is confined then the peer for signal can only be detected as 'unconfined'. That triggers issues like: apparmor="DENIED" operation="signal" profile="/usr/sbin/libvirtd" pid=22395 comm="libvirtd" requested_mask="send" denied_mask="send" signal=term p

[libvirt] [PATCH 4/4] apparmor: allow to preserve /dev mountpoints into qemu namespaces

Libvirt now tries to preserve all mounts under /dev in qemu namespaces. The old rules only listed a set of known paths but those are no more enough. I found some due to containers like /dev/.lxc/* and such but also /dev/console and /dev/net/tun. Libvirt is correct to do so, but we can no more pre

Re: [libvirt] [PATCH 0/3] conf: qemu: support new Hyper-V enlightenments

On Thu, Aug 09, 2018 at 03:14:18PM +0200, Vitaly Kuznetsov wrote: > Several new Hyper-V enlightenments were recently added to Qemu: > - hv-frequencies > - hv-reenlightenment > - hv-tlbflush > > Support these in libvirt. > > Vitaly Kuznetsov (3): > conf: qemu: add support for Hyper-V frequency M

Re: [libvirt] [PATCH] esx: Fix build when libcurl debug is enabled

On Mon, Aug 13, 2018 at 03:51:51PM +0200, Michal Prívozník wrote: > On 08/11/2018 04:39 PM, Marcos Paulo de Souza wrote: > > When building libvirt with libcurl debug enabled (with > > ESX_VI__CURL__ENABLE_DEBUG_OUTPUT set), the message bellow pops up: > > > > make[3]: Entering directory '/mnt/data

Re: [libvirt] [PATCH] spec: Use %make_install

Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: c690de2ccd5777f163f030bcaf13ec4e69881933.1533051128.git.crobi...@redhat.com Subject: [libvirt] [PATCH] spec: Use %make_install === TEST SCRIPT BEGIN === #!/

Re: [libvirt] [PATCH] qemu_migration: Avoid writing to freed memory

Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 7824152ee221199b352c0753db3eefaa5ec9dbb7.1533222453.git.jdene...@redhat.com Subject: [libvirt] [PATCH] qemu_migration: Avoid writing to freed memory === TES

Re: [libvirt] [PATCH] rpm: simplify applying of patches

Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180803093532.16922-1-berra...@redhat.com Subject: [libvirt] [PATCH] rpm: simplify applying of patches === TEST SCRIPT BEGIN === #!/bin/bash # Testing scrip

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

Ivan Mishonov wrote: > On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote: > > > On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: > >>Ivan Mishonov wrote: > >> > >>> Yes, that makes sense. I'll try to find some time next week to redo my > >>> code and send another patch. Sin

[libvirt] [PATCH v2 0/3] conf: standardize naming

on vir*ObjListExport call stack Anya Harter (3): conf: rename structs used by Export function conf: rename Export Callback functions conf: rename Match functions src/conf/virinterfaceobj.c | 16 +--- src/conf/virnetworkobj.c| 24 --- src/conf/virnodedev

[libvirt] [PATCH v2 3/3] conf: rename Match functions

name match functions to be the vir prefix and interface name followed by ObjMatch ex. for virNetworkObjListExport, the match function is named virNetworkObjMatch Signed-off-by: Anya Harter --- src/conf/virnetworkobj.c| 8 src/conf/virnodedeviceobj.c | 6 +++--- src/con

[libvirt] [PATCH v2 2/3] conf: rename Export Callback functions

name functions to be the name of the export function followed by Callback ex. for virInterfaceObjListExport, the callback function is named virInterfaceObjListExportCallback Signed-off-by: Anya Harter --- src/conf/virinterfaceobj.c | 8 src/conf/virnetworkobj.c | 8

[libvirt] [PATCH v2 1/3] conf: rename structs used by Export function

name structs to be the name of the Export function followed by Data also tweak definitions to follow standard struct definition pattern ex. for virInterfaceObjListExport, the struct is defined as follows: typedef struct _virInterfaceObjListExportData virInterfaceObjListExportData;

[libvirt] [PATCHv2 00/62] qemu: Add support for -blockdev

In this version everything except blockjobs should work properly. Similarly to the previous posting, the block job support is not part of this posting yet so blockjobs will not work. Changes to v1: - Added support for floppies via -device so they work with blockdev - fixed return value from the n

[libvirt] [PATCHv2 12/62] qemu: monitor: Allow using 'qdev' instead of 'device' for getting disk throttling

The 'device' field reported by 'query-block' is empty when -blockdev is used. Add an argument which will allow matching disk by using the qdev id so we can use this code with -blockdev. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor.c | 8 +-

[libvirt] [PATCHv2 04/62] qemu: monitor: Remove unsupported function check for 'block_resize'

QEMU supports 'block_resize' since 0.14 so we don't need to do explicit checking. Additionally the caller did not use the different value at all. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/

[libvirt] [PATCHv2 07/62] Revert "qemu: monitor: Add the 'query-nodes' argument for query-blockstats"

Turns out that 'query-nodes' is not what we want and the 'query-blockstats' command was in fact buggy. Revert the new field since it's not needed. This reverts commit 50edca1331298bfcb2622e8fe588d493aff9ab68. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c| 2 +- src/qemu/qemu_mon

[libvirt] [PATCHv2 01/62] qemu: process: Fix alias for disk-tray-moved event

Currently we'd report the alias of the drive which is backing the cdrom rather than the device itself: $ virsh event ds tray-change --loop event 'tray-change' for domain ds disk drive-ide0-0-1: opened event 'tray-change' for domain ds disk drive-ide0-0-1: closed Report the disk device alias as

[libvirt] [PATCHv2 03/62] qemu: Improve errors in qemuDomainBlockResize

Remove the pointless "empty path" check and use a better error message if the disk was not found. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d4a2379e48..4f

[libvirt] [PATCHv2 02/62] tests: qemumonitorjson: Simplify debugging of 'blockInfo' test

Print the differences in case when the expected data does not match. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index e9b2632655..3a0

[libvirt] [PATCHv2 10/62] qemu: monitor: Reuse qemuMonitorJSONQueryBlock in qemuMonitorJSONBlockIoThrottleInfo

The wrapper executes the command and does error detection so there's no need to open-code all of those things. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 37 + 1 file changed, 5 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_mon

[libvirt] [PATCHv2 15/62] tests: qemuxml2argv: Fork CAPS_LATEST test cases for 'blockdev'

The blockdev support will change existing approach to add disks to VMs so all tests using the DO_TEST_CAPS_LATEST approach which have any disks need to be forked so that the changes can be applied. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-aio.x86_64-2.12.0.args | 37 ++

[libvirt] [PATCHv2 11/62] qemu: monitor: Allow using 'id' instead of 'device' for 'block_set_io_throttle'

The 'device' argument matches only the legacy drive alias. For blockdev we need to set the throttling for a QOM id and thus we'll need to use the 'id' field. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor.c | 8 +--- src/qemu/qemu_monitor.h

[libvirt] [PATCHv2 16/62] tests: qemu: Add test data for backing chains and indexes

Add test data for nested backing chains with/without indexes (used in status XMLs) which will excercise blockdev and the related work. Signed-off-by: Peter Krempa --- .../disk-backing-chains-index.x86_64-2.12.0.args | 1 + .../disk-backing-chains-index.x86_64-latest.args | 1 + .../qemux

[libvirt] [PATCHv2 18/62] util: virqemu: Simplify debugging if building QOM object with missing args

Print the values so it's simpler to debug. Signed-off-by: Peter Krempa --- src/util/virqemu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virqemu.c b/src/util/virqemu.c index bc788538af..13ad7410b4 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@

[libvirt] [PATCHv2 05/62] qemu: monitor: Remove useless 'locked' property from struct qemuDomainDiskInfo

We don't use it for anything useful so it does not make much sense to extract it. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.h | 1 - src/qemu/qemu_monitor_json.c | 7 --- tests/qemumonitorjsontest.c | 1 - 3 files changed, 9 deletions(-) diff --git a/src/qemu/qemu_domain.h

[libvirt] [PATCHv2 06/62] tests: qemucapabilities: Update capability data for qemu 3.0.0

The diff contains changes from the change of the JSON library reformatting as well as dropping of the preconfig state and adding of the 'qdev' field to output of 'query-blockstats'. Signed-off-by: Peter Krempa --- .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 591 +++-- te

[libvirt] [PATCHv2 08/62] qemu: hotplug: consolidate media change code paths

Use qemuDomainAttachDeviceDiskLive to change the media in qemuDomainChangeDiskLive as the former function already does all the necessary steps to prepare the new medium. This also allows us to turn qemuDomainChangeEjectableMedia static. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c |

  1   2   >