On Mon, Mar 25, 2019 at 10:59:24 +0100, Andrea Bolognani wrote:
> ldconfig needs to be called after installing or uninstalling
> shared libraries.
>
> For a very long time, libvirt didn't have a separate package
> containing just the shared libraries, and so it shipped them
> in the same one as
Time to actually issue the QMP transactions that start and
stop backup commands (for now, just pull mode, not push).
Starting a job has to kick off several pre-req steps, then
a transaction, and additionally spawn an NBD server for pull
mode; ending a job as well as failing partway through
Complete wiring up incremental backup, by adding in support for
creating a checkpoint at the same time as a backup (make the
transaction have a few more steps) as well as exposing the dirty
bitmap for a prior backup over NBD (requires creating a temporary
bitmap, merging all appropriate bitmaps
On Tue, Mar 26, 2019 at 05:32:58PM +0100, Fabiano Fidêncio wrote:
> The new dependencies are:
> - python3
> - python3-lxml
> - python3-pytest
> - python3-requests
>
> xmllint has been removed in favour of a own crafted test using
> python3-lxml
>
> Signed-off-by: Fabiano Fidêncio
> ---
>
On Wed, Mar 27, 2019 at 05:10:32AM -0500, Eric Blake wrote:
> The qemu driver already had a full-blown virDomainMomentObjPtr to
> check against, and the test driver ought to have one since we get
> better error checking that the user passed in a valid object. Removes
> a helper function added in
Presumably the $SUBJECT means this should be squashed into an
earlier patch.
On Wed, Mar 27, 2019 at 05:10:42AM -0500, Eric Blake wrote:
> ---
> src/conf/checkpoint_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/checkpoint_conf.c
On Wed, Mar 27, 2019 at 05:07:14AM -0500, Eric Blake wrote:
> Use the common base class virDomainMoment for iterator callbacks
> related to snapshots from the qemu code, so that when checkpoint
> operations are introduced, they can share the same callbacks.
>
> Simplify the code for
On 3/26/19 8:51 AM, Daniel Veillard wrote:
> It's time to get a new release out. Simplest would be to enter freeze
> tomorrow, then we can plan an RC2 by Friday, and if everything looks
> good have the release on time next Monday.
Not sure what time you are planning on starting the freeze, but
On Wed, Mar 27, 2019 at 05:07:13AM -0500, Eric Blake wrote:
> Doing so can simplify some callers.
>
> Signed-off-by: Eric Blake
> ---
> src/conf/virdomainsnapshotobjlist.h | 2 +-
> src/conf/snapshot_conf.c| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by:
On Wed, Mar 27, 2019 at 05:07:12AM -0500, Eric Blake wrote:
> The qemu driver already had a full-blown virDomainMomentObjPtr to
> check against, and the test driver ought to have one since we get
> better error checking that the user passed in a valid object. Removes
> a helper function added in
On 3/27/19 11:31 AM, Daniel P. Berrangé wrote:
The mock fopen() function will abort if "/proc/mounts" is
requested with "r" permissions and VIR_CGROUP_MOCK_FILENAME
env var is not set.
Unfortunately this is triggering by the libselinux library
constructor when it tries to read /proc/mounts to
On Wed, Feb 13, 2019 at 15:03:44 -0500, John Ferlan wrote:
>
>
> On 2/8/19 10:08 AM, Jiri Denemark wrote:
> > This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
> > will ask the hypervisor to use multiple parallel connections for
> > migrating a domain. The number of
On Wed, Mar 27, 2019 at 10:07:16AM +0100, Andrea Bolognani wrote:
> On Mon, 2019-03-18 at 11:03 +0100, Andrea Bolognani wrote:
> > We didn't add this until now because i686 cross-compilation
> > requires special care and lcitool was known to produce broken
> > Dockerfiles, but that's been fixed as
Signed-off-by: Jiri Denemark
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 83e965e0f3..2067830848 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -104,6 +104,18 @@
E.g. controller type='xenbus'
On Wed, 2019-03-27 at 09:17 +, Daniel P. Berrangé wrote:
> On Wed, Mar 27, 2019 at 10:07:16AM +0100, Andrea Bolognani wrote:
> > On Mon, 2019-03-18 at 11:03 +0100, Andrea Bolognani wrote:
> > > We didn't add this until now because i686 cross-compilation
> > > requires special care and lcitool
Introduce a few new public APIs related to incremental backups. This
builds on the previous notion of a checkpoint (without an existing
checkpoint, the new API is a full backup, differing from
virDomainBlockCopy in the point of time chosen and in operation on
multiple disks at once); and also
The qemu driver already had a full-blown virDomainMomentObjPtr to
check against, and the test driver ought to have one since we get
better error checking that the user passed in a valid object. Removes
a helper function added in commit commit 4819f54b.
Signed-off-by: Eric Blake
---
Use the common base class virDomainMoment for iterator callbacks
related to snapshots from the qemu code, so that when checkpoint
operations are introduced, they can share the same callbacks.
Simplify the code for qemuDomainSnapshotCurrent by better utilizing
virDomainMoment helpers.
Doing so can simplify some callers.
Signed-off-by: Eric Blake
---
src/conf/virdomainsnapshotobjlist.h | 2 +-
src/conf/snapshot_conf.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/virdomainsnapshotobjlist.h
b/src/conf/virdomainsnapshotobjlist.h
On Wed, Mar 27, 2019 at 05:10:37AM -0500, Eric Blake wrote:
> Introduce a bunch of new public APIs related to backup checkpoints.
> Checkpoints are modeled heavily after virDomainSnapshotPtr (both
> represent a point in time of the guest), although a snapshot exists
> with the intent of rolling
On Wed, Mar 27, 2019 at 05:10:51 -0500, Eric Blake wrote:
> Still needs to actually kick off the right QMP commands, but at
> least allows validation of backup XML, including the fact that
> a backup job can survive a libvirtd restart. Atomically creating
> a checkpoint alongside the backup still
On Wed, Mar 27, 2019 at 12:55:18PM +0100, Michal Privoznik wrote:
> On 3/27/19 11:31 AM, Daniel P. Berrangé wrote:
> > The mock fopen() function will abort if "/proc/mounts" is
> > requested with "r" permissions and VIR_CGROUP_MOCK_FILENAME
> > env var is not set.
> >
> > Unfortunately this is
On Wed, Mar 27, 2019 at 07:14:09 -0500, Eric Blake wrote:
> On 3/27/19 7:05 AM, Peter Krempa wrote:
> > On Wed, Mar 27, 2019 at 05:10:45 -0500, Eric Blake wrote:
> >> Accept XML describing a generic block job, and output it again as
> >> needed. This may still need a few tweaks to match the
On Wed, Feb 13, 2019 at 15:03:58 -0500, John Ferlan wrote:
>
>
> On 2/8/19 10:08 AM, Jiri Denemark wrote:
> > The VIR_MIGRATE_PARALLEL flag is implemented using QEMU's multifd
> > migration capability and the corresponding multifd-channels migration
> > parameter.
> >
> > Signed-off-by: Jiri
There is one specific caller (testInfoSetArgs() in
qemuxml2argvtest.c) which expect the va_list argument to change
after returning from the virQEMUCapsSetVAList() function.
However, since we are passing plain va_list this is not
guaranteed. The man page of stdarg(3) says:
If ap is passed to a
Create a new file for managing a list of checkpoint objects, borrowing
heavily from existing virDomainSnapshotObjList paradigms.
Note that while checkpoints definitely have a use case for multiple
children to a single parent (create a base snapshot, create a child
snapshot, revert to the base,
Now that various new API have been added, it is worth a landing page
that gives an overview of capturing various pieces of guest state, and
which APIs are best suited to which tasks.
Signed-off-by: Eric Blake
Reviewed-by: John Ferlan
Reviewed-by: Daniel P. Berrangé
---
docs/docs.html.in
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in time. Add some basic testing of round trip
XML handling through
Creating a checkpoint does not modify guest-visible state,
but does modify host resources. Rather than reuse existing
domain:write, domain:block_write, or domain:snapshot access
controls, it seems better to introduce a new access control
specific to tasks related to checkpoints and incremental
Prepare for new backup APIs by describing the XML that will represent
a backup. The XML resembles snapshots and checkpoints in being able
to select actions for a set of disks, but has other differences. It
can support both push model (the hypervisor does the backup directly
into the destination
Introduce a bunch of new public APIs related to backup checkpoints.
Checkpoints are modeled heavily after virDomainSnapshotPtr (both
represent a point in time of the guest), although a snapshot exists
with the intent of rolling back to that state, while a checkpoint
exists to make it possible to
Introduce a bunch of new virsh commands for managing checkpoints
in isolation. More commands are needed for performing incremental
backups, but these commands were easy to implement by modeling
heavily after virsh-snapshot.c (no need for checkpoint-revert,
and checkpoint-list was a lot easier
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, and about the capitalization of
virDomainSnapshotCreateXML2(), at which point the remote driver code
for backups can be generated.
Signed-off-by: Eric Blake
---
src/remote/remote_daemon_dispatch.c | 22 ++-
Accept XML describing a generic block job, and output it again as
needed. This may still need a few tweaks to match the documented XML
and RNG schema.
Signed-off-by: Eric Blake
---
src/conf/backup_conf.h | 96 +++
src/conf/virconftypes.h | 3 +
src/conf/Makefile.inc.am | 2 +
Introduce a few more new virsh commands for performing backup jobs, as
well as creating a checkpoint atomically with a snapshot.
At this time, I did not opt for a convenience command
'backup-begin-as' that cobbles together appropriate XML from the
user's command line arguments, but that may be a
Still needs to actually kick off the right QMP commands, but at
least allows validation of backup XML, including the fact that
a backup job can survive a libvirtd restart. Atomically creating
a checkpoint alongside the backup still needs implementing.
Signed-off-by: Eric Blake
---
A lot of this work heavily copies from the existing snapshot
APIs. The interaction with qemu during create/delete still
needs to be implemented, but this takes care of all the libvirt
metadata (saving and restoring XML, and tracking the relations
between multiple checkpoints).
Signed-off-by:
Time to actually issue the QMP transactions that create and
delete persistent checkpoints. For create, we only need one
transaction: inside, we visit all disks affected by the
checkpoint, and create a new enabled bitmap, as well as
disabling the bitmap of the parent checkpoint (if any). For
Add some monitor commands to be used during backup/checkpoint
operations:
- another facet to query-block for learning bitmap size
- new export and bitmap parameters to nbd-server-add
- new block-dirty-bitmap-{add,enable,disable,merge} functions
Also add two capabilities for testing that they are
Update the code to support push backups; for now, the destination file
still has to be local, although the XML could be extended into
supporting remote destinations (where we will have to use the full
power of blockdev-add). This also touches up the event handling to
inform the user when the job
Prepare for new checkpoint APIs by describing the XML that will
represent a checkpoint. The checkpoint XML is modeled heavily after
virDomainSnapshotPtr. (See the docs for more details).
Add testsuite coverage for some minimal uses of the XML (bare minimum,
the sample from html, and a full
---
src/conf/checkpoint_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c
index 3dd2acf886..01497a79f6 100644
--- a/src/conf/checkpoint_conf.c
+++ b/src/conf/checkpoint_conf.c
@@ -615,7 +615,7 @@
On Wed, Mar 27, 2019 at 05:10:36AM -0500, Eric Blake wrote:
> Prepare for new backup APIs by describing the XML that will represent
> a backup. The XML resembles snapshots and checkpoints in being able
> to select actions for a set of disks, but has other differences. It
> can support both push
On Wed, 2019-03-27 at 10:50 +0100, Michal Privoznik wrote:
> There is one specific caller (testInfoSetArgs() in
> qemuxml2argvtest.c) which expect the va_list argument to change
s/ / /
> after returning from the virQEMUCapsSetVAList() function.
> However, since we are passing plain va_list
The mock fopen() function will abort if "/proc/mounts" is
requested with "r" permissions and VIR_CGROUP_MOCK_FILENAME
env var is not set.
Unfortunately this is triggering by the libselinux library
constructor when it tries to read /proc/mounts to find out
if selinuxfs is mounted in an unusual
There are 2 examples of use of which uses a 'type'
attribute rather than 'format' as documented in the XML schema:
default
qcow
luks
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
On Wed, Mar 27, 2019 at 05:10:43AM -0500, Eric Blake wrote:
> Creating a checkpoint does not modify guest-visible state,
> but does modify host resources. Rather than reuse existing
> domain:write, domain:block_write, or domain:snapshot access
> controls, it seems better to introduce a new access
On Wed, Mar 27, 2019 at 05:10:34AM -0500, Eric Blake wrote:
> Use the common base class virDomainMoment for iterator callbacks
> related to snapshots from the qemu code, so that when checkpoint
> operations are introduced, they can share the same callbacks.
>
> Simplify the code for
On Wed, Mar 27, 2019 at 05:10:49 -0500, Eric Blake wrote:
> A lot of this work heavily copies from the existing snapshot
> APIs. The interaction with qemu during create/delete still
> needs to be implemented, but this takes care of all the libvirt
> metadata (saving and restoring XML, and
ping
On 13.02.2019 19:55, John Ferlan wrote:
>
>
> On 2/8/19 2:52 AM, Nikolay Shirokovskiy wrote:
>> Patches 1 and 2 are already Reviewed-by: John. Patch 3 needs Peter comments.
>>
>
> Right - feel free to add my :
>
> Reviewed-by: John Ferlan
>
> to the first 2 patches for sure.
>
> To
On Wed, Mar 27, 2019 at 05:10:45 -0500, Eric Blake wrote:
> Accept XML describing a generic block job, and output it again as
> needed. This may still need a few tweaks to match the documented XML
> and RNG schema.
>
> Signed-off-by: Eric Blake
> ---
> src/conf/backup_conf.h | 96 +++
>
On Tue, Mar 26, 2019 at 05:32:59PM +0100, Fabiano Fidêncio wrote:
> osinfo-db tests are Python3 only.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/playbooks/build/projects/osinfo-db.yml | 13 +
> jenkins/projects/osinfo-db.yaml | 9 +
> 2 files changed,
On Wed, 2019-03-27 at 10:38 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> docs/news.xml | 12
> 1 file changed, 12 insertions(+)
Thanks for taking the time to update the release notes! :)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat /
On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote:
> This also adjusts the argument name which should be 'isListen' in both
> cases rather than 'listen'.
>
> Signed-off-by: Christophe Fergeau
> ---
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- really fix 'boolen' typo
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
There are 2 examples of use of which uses a 'type'
attribute rather than 'format' as documented in the XML schema:
default
qcow
luks
On Wed, Mar 27, 2019 at 05:10:44AM -0500, Eric Blake wrote:
> The remote code generator had to be taught about the new
> virDomainCheckpointPtr type, and about the capitalization of
> virDomainSnapshotCreateXML2(), at which point the remote driver code
> for backups can be generated.
>
>
On Wed, Mar 27, 2019 at 05:10:38AM -0500, Eric Blake wrote:
> Introduce a few new public APIs related to incremental backups. This
> builds on the previous notion of a checkpoint (without an existing
> checkpoint, the new API is a full backup, differing from
> virDomainBlockCopy in the point of
On Wed, Mar 27, 2019 at 05:10:32AM -0500, Eric Blake wrote:
The qemu driver already had a full-blown virDomainMomentObjPtr to
check against, and the test driver ought to have one since we get
better error checking that the user passed in a valid object. Removes
a helper function added in commit
On Wed, Mar 27, 2019 at 01:02:07PM +0100, Andrea Bolognani wrote:
> On Wed, 2019-03-27 at 10:50 +0100, Michal Privoznik wrote:
> > There is one specific caller (testInfoSetArgs() in
> > qemuxml2argvtest.c) which expect the va_list argument to change
>
> s/ / /
>
> > after returning from the
Copies heavily from existing virDomainSnapshot handling, regarding
what special cases the generator has to be taught and what overrides
need to be written.
Signed-off-by: Eric Blake
---
Python counterparts to my incremental backup patches. An earlier
version was already reviewed by Dan; the
On Wed, Mar 27, 2019 at 12:13:41PM +0100, Pino Toscano wrote:
> On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote:
> > This also adjusts the argument name which should be 'isListen' in both
> > cases rather than 'listen'.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> >
On Tue, Mar 26, 2019 at 13:14:48 -0500, Eric Blake wrote:
> On 3/26/19 12:41 PM, Peter Krempa wrote:
> > On Tue, Mar 26, 2019 at 01:13:44 -0500, Eric Blake wrote:
> >> I'm fairly confident that these API are ready to go (that is, I've got
> >> qemu code in the wings to implement these API for the
On Wed, Mar 27, 2019 at 05:10:52 -0500, Eric Blake wrote:
> Time to actually issue the QMP transactions that start and
> stop backup commands (for now, just pull mode, not push).
> Starting a job has to kick off several pre-req steps, then
> a transaction, and additionally spawn an NBD server for
On 3/27/19 7:05 AM, Peter Krempa wrote:
> On Wed, Mar 27, 2019 at 05:10:45 -0500, Eric Blake wrote:
>> Accept XML describing a generic block job, and output it again as
>> needed. This may still need a few tweaks to match the documented XML
>> and RNG schema.
>>
>> Signed-off-by: Eric Blake
>>
Use the common base class virDomainMoment for iterator callbacks
related to snapshots from the qemu code, so that when checkpoint
operations are introduced, they can share the same callbacks.
Simplify the code for qemuDomainSnapshotCurrent by better utilizing
virDomainMoment helpers.
I've finished rebasing my earlier v4/v5 patches on top of cleanups
earlier in the series (v6 didn't include the second half of the
series). I've pushed a tag backup-v7 to both my libvirt.git and
libvirt-python.git repos to match:
https://repo.or.cz/libvirt/ericb.git/shortlog/refs/tags/backup-v7
Doing so can simplify some callers.
Signed-off-by: Eric Blake
---
src/conf/virdomainsnapshotobjlist.h | 2 +-
src/conf/snapshot_conf.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/virdomainsnapshotobjlist.h
b/src/conf/virdomainsnapshotobjlist.h
The qemu driver already had a full-blown virDomainMomentObjPtr to
check against, and the test driver ought to have one since we get
better error checking that the user passed in a valid object. Removes
a helper function added in commit commit 4819f54b.
Signed-off-by: Eric Blake
---
On Tue, Mar 26, 2019 at 8:14 AM Eric Blake wrote:
...
>
> + pull
> +
> +
> +
> +
>
...
> +
> +
> + unix
> +
> +
> +
On 3/27/19 6:29 AM, Daniel P. Berrangé wrote:
>
> Presumably the $SUBJECT means this should be squashed into an
> earlier patch.
Yeah, 10/23.
>
> On Wed, Mar 27, 2019 at 05:10:42AM -0500, Eric Blake wrote:
>> ---
>> src/conf/checkpoint_conf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1
On Mon, 2019-03-18 at 11:03 +0100, Andrea Bolognani wrote:
> We didn't add this until now because i686 cross-compilation
> requires special care and lcitool was known to produce broken
> Dockerfiles, but that's been fixed as of libvirt-jenkins-ci
> commit f72d09153905 so we can finally go ahead
On 3/27/19 5:16 AM, Nir Soffer wrote:
> On Tue, Mar 26, 2019 at 8:14 AM Eric Blake wrote:
> We are trying to use backup_v5a from:
> https://repo.or.cz/libvirt/ericb.git
> And when we start a backup with this xml:
>
>
> socket="/var/run/vdsm/nbd/4f594cec-1a27-43fd-acf8-3283cacd6347.sock"
>
On Wed, Mar 27, 2019 at 05:10:33AM -0500, Eric Blake wrote:
> Doing so can simplify some callers.
>
> Signed-off-by: Eric Blake
> ---
> src/conf/virdomainsnapshotobjlist.h | 2 +-
> src/conf/snapshot_conf.c| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by:
On 3/27/19 6:36 AM, Daniel P. Berrangé wrote:
> On Wed, Mar 27, 2019 at 05:10:44AM -0500, Eric Blake wrote:
>> The remote code generator had to be taught about the new
>> virDomainCheckpointPtr type, and about the capitalization of
>> virDomainSnapshotCreateXML2(), at which point the remote driver
On 3/27/19 5:10 AM, Eric Blake wrote:
> Doing so can simplify some callers.
>
> Signed-off-by: Eric Blake
> ---
> src/conf/virdomainsnapshotobjlist.h | 2 +-
> src/conf/snapshot_conf.c| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Peter reported that at -O2, this makes
On Wed, Mar 27, 2019 at 05:10:49AM -0500, Eric Blake wrote:
A lot of this work heavily copies from the existing snapshot
APIs. The interaction with qemu during create/delete still
needs to be implemented, but this takes care of all the libvirt
metadata (saving and restoring XML, and tracking
On Wed, Mar 27, 2019 at 05:10:47 -0500, Eric Blake wrote:
> Introduce a few more new virsh commands for performing backup jobs, as
> well as creating a checkpoint atomically with a snapshot.
>
> At this time, I did not opt for a convenience command
> 'backup-begin-as' that cobbles together
On 3/25/19 9:04 AM, Bjoern Walk wrote:
This patch series introduces the ability to save additional information
for the domain state and exposes this information in virsh domstate.
For example in the case of QEMU guest panic events, we can provide additional
information like the crash reason or
On 3/25/19 9:04 AM, Bjoern Walk wrote:
> Add a new parameter to virsh domstate, --info, to report additional
> information for the domain state, e.g. for a QEMU guest running a S390
> domain:
>
> virsh # domstate --info guest-1
> crashed (panicked: s390: core='0'
On 3/25/19 9:04 AM, Bjoern Walk wrote:
Implement the API function virDomainGetStateParams for the remote driver
and wire up the remote protocol.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/remote/remote_daemon_dispatch.c | 50 +
On 3/25/19 9:04 AM, Bjoern Walk wrote:
Let's store additional state information in the hypervisor-specific
private data to virDomainObj. For now, just consider panic state in QEMU
domains for which additional information is available from the guest
crash event handler.
Reviewed-by: Boris
Michal Privoznik [2019-03-27, 02:05PM +0100]:
> I like the general idea, but some cleanups are needed IMO.
Fair enough. I will send the next rebased version then after the
release.
>
> Michal
>
Thanks for the review.
signature.asc
Description: PGP signature
--
libvir-list mailing list
On 3/27/19 6:38 AM, Ján Tomko wrote:
> On Wed, Mar 27, 2019 at 05:10:32AM -0500, Eric Blake wrote:
>> The qemu driver already had a full-blown virDomainMomentObjPtr to
>> check against, and the test driver ought to have one since we get
>> better error checking that the user passed in a valid
We currently support Debian 8 (oldstable) along with Debian 9
(stable), but not without some compromises:
* the libvirt-dbus, libvirt-ocaml and virt-manager projects do not
support the platform at all because it ships outdated versions of
some core components;
* on the CI side of
On 3/27/19 2:19 PM, Bjoern Walk wrote:
Michal Privoznik [2019-03-27, 02:05PM +0100]:
On 3/25/19 9:04 AM, Bjoern Walk wrote:
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 5c4dd412..e0962014 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@
On 3/27/19 7:00 AM, Eric Blake wrote:
> On 3/27/19 6:29 AM, Daniel P. Berrangé wrote:
>>
>> Presumably the $SUBJECT means this should be squashed into an
>> earlier patch.
>
> Yeah, 10/23.
>
>>
>> On Wed, Mar 27, 2019 at 05:10:42AM -0500, Eric Blake wrote:
>>> ---
>>> src/conf/checkpoint_conf.c
On 3/27/19 9:29 AM, Ján Tomko wrote:
> On Wed, Mar 27, 2019 at 05:10:46AM -0500, Eric Blake wrote:
>> Introduce a bunch of new virsh commands for managing checkpoints
>> in isolation. More commands are needed for performing incremental
>> backups, but these commands were easy to implement by
On Wed, Mar 27, 2019 at 13:18:17 +0100, Peter Krempa wrote:
> On Wed, Mar 27, 2019 at 07:14:09 -0500, Eric Blake wrote:
> > On 3/27/19 7:05 AM, Peter Krempa wrote:
> > > On Wed, Mar 27, 2019 at 05:10:45 -0500, Eric Blake wrote:
> > >> Accept XML describing a generic block job, and output it again
On 3/27/19 12:57 PM, Daniel P. Berrangé wrote:
On Wed, Mar 27, 2019 at 12:55:18PM +0100, Michal Privoznik wrote:
On 3/27/19 11:31 AM, Daniel P. Berrangé wrote:
The mock fopen() function will abort if "/proc/mounts" is
requested with "r" permissions and VIR_CGROUP_MOCK_FILENAME
env var is not
For pinned vcpus, vcpupin will report inaccurate affinity values on machines
with high core counts (256 cores in my case). The problem is produced as
follows:
$ virsh vcpupin myguest 0 4
$ virsh vcpupin myguest 0
VCPU CPU Affinity
---
0 4,192,194,196-197
On Wed, Mar 27, 2019 at 07:06:32AM -0500, Eric Blake wrote:
> On 3/27/19 6:36 AM, Daniel P. Berrangé wrote:
> > On Wed, Mar 27, 2019 at 05:10:44AM -0500, Eric Blake wrote:
> >> The remote code generator had to be taught about the new
> >> virDomainCheckpointPtr type, and about the capitalization
On Wed, Mar 27, 2019 at 05:10:49 -0500, Eric Blake wrote:
> A lot of this work heavily copies from the existing snapshot
> APIs. The interaction with qemu during create/delete still
> needs to be implemented, but this takes care of all the libvirt
> metadata (saving and restoring XML, and
On 3/27/19 9:01 AM, Ján Tomko wrote:
> On Wed, Mar 27, 2019 at 05:10:40AM -0500, Eric Blake wrote:
>> Add a new file checkpoint_conf.c that performs the translation to and
>> from new XML describing a checkpoint. The code shares a common base
>> class with snapshots, since a checkpoint similarly
On Wed, Mar 27, 2019 at 12:21:25PM +0100, Christophe Fergeau wrote:
There are 2 examples of use of which uses a 'type'
attribute rather than 'format' as documented in the XML schema:
default
qcow
luks
Michal Privoznik [2019-03-27, 02:05PM +0100]:
> On 3/25/19 9:04 AM, Bjoern Walk wrote:
> > @@ -14069,6 +14072,39 @@
> > qemuDomainStatePanicInfoFormatMsg(qemuDomainStatePanicInfoPtr info)
> > }
> > +void
> > +qemuDomainStatePanicInfoSet(virDomainObjPtr vm,
> > +
On Wed, Mar 27, 2019 at 05:10:40AM -0500, Eric Blake wrote:
Add a new file checkpoint_conf.c that performs the translation to and
from new XML describing a checkpoint. The code shares a common base
class with snapshots, since a checkpoint similarly represents the
domain state at a moment in
On 3/27/19 10:02 AM, Daniel P. Berrangé wrote:
> On Sat, Mar 23, 2019 at 11:02:03PM -0500, Eric Blake wrote:
>> Had this been in place earlier, I would have avoided the bugs in
>> commit 0baf6945 and 55c2ab3e. Writing the test required me to extend
>> the power of virsh - creating enough snapshots
Please use --cover-letter for series with two or more patches for neater
alignment of e-mails.
On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote:
This also adjusts the argument name which should be 'isListen' in both
cases rather than 'listen'.
Signed-off-by: Christophe
1 - 100 of 135 matches
Mail list logo
