Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-12 Thread Jim Meyering
Atsushi SAKAI [EMAIL PROTECTED] wrote: Hi, Jim and Dan How about this? src/domain_conf.c|1 + src/domain_conf.h|6 +++--- src/network_conf.c |1 + src/qemu_driver.c| 32 src/util.c |4 ++-- src/virsh.c

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-12 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 05:59:56PM +0200, Guido Günther wrote: Hi, On Fri, Aug 08, 2008 at 10:34:00AM -0400, Daniel Veillard wrote: [..snip..] I think the only thing missing is extending the descrition in the documentation would you mind adding a description in formatdomain.html(.in)

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Casey Schaufler
James Morris wrote: On Sun, 10 Aug 2008, Casey Schaufler wrote: 1.1 Rationale With increased use of virtualization, one security benefit of physically separated systems -- strong isolation -- is reduced, This issue can always be readily resolved by going back to physically

RE: [libvirt] Qemu Monitor

2008-08-12 Thread Duzenbury, Rich
Nope, the monitor is redirected so that libvirt can send commands to it directly. Hi, How are we to ask the monitor to eject a CD-ROM? Thank you. Regards, Rich -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Russell Coker
On Monday 11 August 2008 19:31, James Morris [EMAIL PROTECTED] wrote: I suspect you misunderstood an important aspect of this in that we are targeting Linux-based virtualization, where the VMs are running inside Linux processes. In this case, the isolation depends on DAC in the host, and the

Re: [libvirt] [PATCH] Fix python error reporting for some storage operations

2008-08-12 Thread Daniel Veillard
On Mon, Aug 11, 2008 at 03:58:55PM -0400, Cole Robinson wrote: In the python bindings, all vir* classes expect to be passed a virConnect object when instantiated. Before the storage stuff, these classes were only instantiated in virConnect methods, so the generator is hardcoded to pass 'self'

Re: [libvirt] PATCH: 3/7:

2008-08-12 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... [ Nice long explanation. ] It'd be great to put that in the code. lxc_conf.c | 195 lxc_conf.h | 12 lxc_container.c | 39 +-- lxc_container.h |8 lxc_controller.c | 349 +++-

Re: [libvirt] [PATCH] Implement vol delete for disk pools

2008-08-12 Thread Daniel Veillard
On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote: The patch below implements virStorageVolDelete for volumes on a disk pool. The only interesting thing here is that parted wants a partition number to delete, so we need to peel off the end of the volume's target path which will

Re: [libvirt] Qemu Monitor

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 10:52:59AM -0500, Duzenbury, Rich wrote: Nope, the monitor is redirected so that libvirt can send commands to it directly. Hi, How are we to ask the monitor to eject a CD-ROM? Use the 'virsh attach-disk' command - it you give it the name of an existing CDROM

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-12 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 03:17:52PM -0400, David Lively wrote: Hi Folks - This small patch is a proposed prerequisite for the storage pool discovery patch I submitted last week. Daniel B proposed having storage pool discovery return a bunch of XML storage source elements, rather than

Re: [libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 03:57:46PM +1000, Russell Coker wrote: On Monday 11 August 2008 19:31, James Morris [EMAIL PROTECTED] wrote: I think that Casey's idea is that if someone breaks the VM separation then you lose it all. For separation based on UML there are obvious benefits to having

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread James Morris
On Tue, 12 Aug 2008, Russell Coker wrote: having different labels for processes and files so that if someone cracks the UML kernel then they end up with just a regular user access on the Linux host. Which of course they could then try to crack with any of the usual local-root exploits.

Re: [libvirt] [PATCH] Implement vol delete for disk pools

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote: The patch below implements virStorageVolDelete for volumes on a disk pool. The only interesting thing here is that parted wants a partition number to delete, so we need to peel off the end of the volume's target path which will

Re: [libvirt] [PATCH] Fix python error reporting for some storage operations

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 03:58:55PM -0400, Cole Robinson wrote: In the python bindings, all vir* classes expect to be passed a virConnect object when instantiated. Before the storage stuff, these classes were only instantiated in virConnect methods, so the generator is hardcoded to pass 'self'

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically s/dos/msdos/ Hi Cole, This definitely needs to be fixed. FYI, dos

[libvirt] Announcement of a companion project the UnifiedSessionsManager

2008-08-12 Thread acue
Hello, I would like to announce the unifiedSessionsManager(GPL3, including the claimed inventions), which is based for Xen on the virsh-tool, but basically uses a different approach. I guess it could be a quite usable companion of libvirt for advanced usage and enhanced customizabelity of the

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 12:17:48PM +1000, James Morris wrote: 4. Design Considerations 4.1 Consensus in preliminary discussion appears to be that adding MAC to libvirt will be the most effective approach. Support may then be extended to virsh, virt-manager, oVirt

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread James Morris
On Tue, 12 Aug 2008, Daniel P. Berrange wrote: Do we instead add the info the udev rules, so when /dev is populated at boot time by udev the device nodes get the desired initial labelling ? Or do we manually chcon() the device at the time we boot the VM ?

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote: On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically

Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

2008-08-12 Thread Daniel Veillard
On Mon, Aug 11, 2008 at 09:53:48AM -0400, Cole Robinson wrote: Daniel P. Berrange wrote: On Sun, Aug 10, 2008 at 10:40:30PM -0400, Cole Robinson wrote: Trying to 'build' a disk pool uses 'parted mklabel' which can prompt for confirmation. Patch adds the '--script' option to remove the

[libvirt] virDomainInterfaceStats why is there a size?

2008-08-12 Thread Stefan de Konink
Another simple question, what is the reasoning about the size field in this call. I would really be a happy boy if anyone said: if you put in path == NULL, it will fill your stats structure up to size interfaces. ...but since this is not the case (yet) what is the reason behind it? Stefan --

[libvirt] PATCH: Block reset signals when fork/exec'ing children

2008-08-12 Thread Daniel P. Berrange
The LXC patches identified a race condition between fork/exec'ing child processes and signal handlers. The process using libvirt can have setup arbitrary signal handlers. In the libvirtd case we have one attached to SIGCHILD, and the handler writes to a pipe which is then processeed in the main

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 09:20:41AM -0400, Daniel J Walsh wrote: James Morris wrote: On Tue, 12 Aug 2008, Daniel P. Berrange wrote: Do we instead add the info the udev rules, so when /dev is populated at boot time by udev the device nodes get the desired initial

RE: [libvirt] Qemu Monitor

2008-08-12 Thread Duzenbury, Rich
-Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 12, 2008 4:14 AM To: Duzenbury, Rich Cc: libvir-list@redhat.com Subject: Re: [libvirt] Qemu Monitor On Mon, Aug 11, 2008 at 10:52:59AM -0500, Duzenbury, Rich wrote: Nope, the monitor is

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel J Walsh
James Morris wrote: On Tue, 12 Aug 2008, Daniel P. Berrange wrote: Do we instead add the info the udev rules, so when /dev is populated at boot time by udev the device nodes get the desired initial labelling ? Or do we manually chcon() the device at the

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel J Walsh
Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:20:41AM -0400, Daniel J Walsh wrote: James Morris wrote: On Tue, 12 Aug 2008, Daniel P. Berrange wrote: Do we instead add the info the udev rules, so when /dev is populated at boot time by udev the device nodes get the

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 09:54:23AM -0400, Daniel J Walsh wrote: Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:20:41AM -0400, Daniel J Walsh wrote: The experimenting I have done has been around labeling of the virt_image and the process with mcs labels to prevent one process from

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel J Walsh
Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:54:23AM -0400, Daniel J Walsh wrote: Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:20:41AM -0400, Daniel J Walsh wrote: The experimenting I have done has been around labeling of the virt_image and the process with mcs labels to

Re: [libvirt] [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 10:16:35AM -0400, Daniel J Walsh wrote: Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:54:23AM -0400, Daniel J Walsh wrote: Daniel P. Berrange wrote: On Tue, Aug 12, 2008 at 09:20:41AM -0400, Daniel J Walsh wrote: The experimenting I have done has been around

Re: [libvirt] PATCH: 4/7: Convert LXC to new domain APIs

2008-08-12 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: The re-architecting of the LXC controller/container process relationship in the previous patch removed the last obstacle to switching over to the generic domain XML routines. So this patch switches the driver over. First the vast majority of

Re: [libvirt] static ip address

2008-08-12 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 09:32:06PM +0200, Olivier Deckmyn wrote: On Sun, Aug 3, 2008 at 7:04 PM, Mads Chr. Olesen [EMAIL PROTECTED] wrote: lør, 02 08 2008 kl. 23:13 +0200, skrev Olivier Deckmyn: I would like to be able to choose on a way or another the ip of each of my VM. As far as I

Re: [libvirt] static ip address

2008-08-12 Thread Olivier Deckmyn
On Tue, Aug 12, 2008 at 5:17 PM, Daniel Veillard [EMAIL PROTECTED]wrote: On Fri, Aug 08, 2008 at 09:32:06PM +0200, Olivier Deckmyn wrote: On Sun, Aug 3, 2008 at 7:04 PM, Mads Chr. Olesen [EMAIL PROTECTED] wrote: lør, 02 08 2008 kl. 23:13 +0200, skrev Olivier Deckmyn: I would like to

[libvirt] [PATCH] rewrite virFileLinkPointsTo

2008-08-12 Thread Jim Meyering
I've rewritten virFileLinkPointsTo to be a lot simpler, and more importantly, it has far fewer failure points. If anyone wants to preserve the original behavior that makes it fail when the first parameter does not specify a symlink, I can add that. The only difference in behavior would be when

Re: [libvirt] [PATCH] rewrite virFileLinkPointsTo

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 07:18:00PM +0200, Jim Meyering wrote: I've rewritten virFileLinkPointsTo to be a lot simpler, and more importantly, it has far fewer failure points. If anyone wants to preserve the original behavior that makes it fail when the first parameter does not specify a

Re: [libvirt] [PATCH] rewrite virFileLinkPointsTo

2008-08-12 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Aug 12, 2008 at 07:18:00PM +0200, Jim Meyering wrote: I've rewritten virFileLinkPointsTo to be a lot simpler, and more importantly, it has far fewer failure points. If anyone wants to preserve the original behavior that makes it fail when

Re: [libvirt] [PATCH] rewrite virFileLinkPointsTo

2008-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2008 at 07:29:20PM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Aug 12, 2008 at 07:18:00PM +0200, Jim Meyering wrote: I've rewritten virFileLinkPointsTo to be a lot simpler, and more importantly, it has far fewer failure points. If

Re: [libvirt] PATCH: Block reset signals when fork/exec'ing children

2008-08-12 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: The LXC patches identified a race condition between fork/exec'ing child processes and signal handlers. Looks fine modulo a few details: diff -r 1dbfb08d365d src/util.c ... @@ -104,9 +109,23 @@ _virExec(virConnectPtr conn, const char

[libvirt] [PATCH] static ip address

2008-08-12 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 06:49:59PM +0200, Olivier Deckmyn wrote: On Tue, Aug 12, 2008 at 5:17 PM, Daniel Veillard [EMAIL PROTECTED]wrote: That said I'm working on a new version of the patch which would be adequate [...] Once again, if I can do anything to help, I will. Then please try the

Re: [libvirt] [PATCH] static ip address

2008-08-12 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 03:39:28PM -0400, Daniel Veillard wrote: On Tue, Aug 12, 2008 at 06:49:59PM +0200, Olivier Deckmyn wrote: On Tue, Aug 12, 2008 at 5:17 PM, Daniel Veillard [EMAIL PROTECTED]wrote: That said I'm working on a new version of the patch which would be adequate [...]

Re: [libvirt] [PATCH] static ip address

2008-08-12 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 03:39:28PM -0400, Daniel Veillard wrote: On Tue, Aug 12, 2008 at 06:49:59PM +0200, Olivier Deckmyn wrote: On Tue, Aug 12, 2008 at 5:17 PM, Daniel Veillard [EMAIL PROTECTED]wrote: That said I'm working on a new version of the patch which would be adequate [...]

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-12 Thread David Lutterkort
On Fri, 2008-08-08 at 16:22 +0200, Chris Lalancette wrote: Jim Meyering wrote: diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c --- a/ext/libvirt/_libvirt.c Thu Jul 17 15:24:26 2008 -0700 +++ b/ext/libvirt/_libvirt.c Fri Aug 08 06:04:56 2008 -0400 @@ -637,16 +637,51 @@ VALUE

[libvirt] Question about html file in docs

2008-08-12 Thread Atsushi SAKAI
Hi, I think html files in docs directory are redundunt. It is because html file is created by html.in. May I remove these files? Or are there any reason about staying these files? Thanks Atsushi SAKAI -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] [PATCH] Implement vol delete for disk pools

2008-08-12 Thread Cole Robinson
Daniel P. Berrange wrote: On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote: The patch below implements virStorageVolDelete for volumes on a disk pool. The only interesting thing here is that parted wants a partition number to delete, so we need to peel off the end of the

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Cole Robinson
Daniel Veillard wrote: On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote: On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead

[libvirt] [PATCH] Fix size reporting for disk pools without partitions

2008-08-12 Thread Cole Robinson
The attached patch updates parthelper to print size information for a disk device if it doesn't have any allocated partitions. The current code starts by requesting the first partition, then iterating from there. But if there is no first partition, that whole info reporting thing never happens :)

[libvirt] [PATCH] Ignore specified target path when creating logical vol

2008-08-12 Thread Cole Robinson
Specifying a target path when creating a storage volume has no effect, since volumes only really use the pool's target path and 'name' field to establish the volume's target. Logical volumes expect a target path to be passed, and it can only cause problems. The attached patch erases the passed