Re: [libvirt] [PATCH]: virAsprintf cleanup v2

2009-01-06 Thread Daniel Veillard
On Mon, Dec 22, 2008 at 10:02:17PM +0100, Guido Günther wrote: Hi, new version attached. It adds your suggestions and also uses virAsprintf in the new src/logging.c. Oops, my fault ! Thanks for fixing this :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] [PATCH] Make mntent.h specific to the FS storage backend

2009-01-06 Thread Daniel Veillard
On Sat, Dec 20, 2008 at 08:48:04AM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1229789393 28800 # Node ID c433c57ef39b2c343653910df84130c8849a7c11 # Parent 100de621beed6e146b239df3691bd426090955b4 Make mntent.h specific to the FS storage backend

[libvirt] [PATCH] avoid syntax-check (po-check) failure due to FP match on gettext.m4

2009-01-06 Thread Jim Meyering
spotted by Dan Berrange and the autobuilder http://builder.virt-manager.org/logs/modules/libvirt--devel-build-output.log From ee91ab81dbd458078df39ef52e22e9a489d5cc72 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 6 Jan 2009 10:42:29 +0100 Subject: [PATCH] avoid

Re: [libvirt] [PATCH] Fix !SASL qemud compile

2009-01-06 Thread Daniel Veillard
On Mon, Dec 22, 2008 at 01:07:33PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1229980020 28800 # Node ID 4fbf7139ca42757d771f03578e91038bf28a5e0e # Parent fd97ec8e5799120ebf5ea9ed73d681c6d1386970 Fix !SASL qemud compile Replace qemudLog() with

Re: [libvirt] [PATCH] avoid syntax-check (po-check) failure due to FP match on gettext.m4

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 10:44:41AM +0100, Jim Meyering wrote: spotted by Dan Berrange and the autobuilder http://builder.virt-manager.org/logs/modules/libvirt--devel-build-output.log From ee91ab81dbd458078df39ef52e22e9a489d5cc72 Mon Sep 17 00:00:00 2001 From: Jim Meyering

Re: [libvirt] Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Tom Brown
I've not tried it, but the likely problem is that you'll need to turn on XenD's UNIX server config option in /etc/xen/xend-config.sxp http://libvirt.org/drvxen.html Thanks for this - this sounds like the most likely issue. The problem is that Citrix seems to move things around

Re: [libvirt] [PATCH] avoid syntax-check (po-check) failure due to FP match on gettext.m4

2009-01-06 Thread Daniel Veillard
On Tue, Jan 06, 2009 at 09:46:03AM +, Daniel P. Berrange wrote: On Tue, Jan 06, 2009 at 10:44:41AM +0100, Jim Meyering wrote: spotted by Dan Berrange and the autobuilder http://builder.virt-manager.org/logs/modules/libvirt--devel-build-output.log From

Re: [libvirt] Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 10:41:40AM +, Tom Brown wrote: I've not tried it, but the likely problem is that you'll need to turn on XenD's UNIX server config option in /etc/xen/xend-config.sxp http://libvirt.org/drvxen.html Thanks for this - this sounds like the most likely

[libvirt] [PATCH] dist: distribute all libvirt_*.syms files, ...

2009-01-06 Thread Jim Meyering
Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally. Here's the fix: From 272938681646e3aeefe5d9b13fab312a47e5d862 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 6 Jan 2009 12:09:40 +0100 Subject: [PATCH] dist: distribute all

[libvirt] Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Gerhardus.Geldenhuis
Hi I hope me replying this way does not break anyone's mail sorting, I only now subscribed to the list. Thanks for this - this sounds like the most likely issue. The problem is that Citrix seems to move things around somewhat as that config file does not exist. There is a xensource

[libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Gerhardus.Geldenhuis
No it does not use xend. -Original Message- From: David Edmondson [mailto:d...@dme.org] On Behalf Of David Edmondson Sent: 06 January 2009 11:53 To: Gerhardus Geldenhuis (GTA-LON) Cc: libvir-list@redhat.com Subject: Re: Libvirt - Xen Enterprise - Koan There's an assumption that

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 11:57:34AM -, gerhardus.geldenh...@gta-travel.com wrote: No it does not use xend. That's pretty much game over then. Someone will have to write a new libvirt driver specifically for XenEnterprise to get it to work. Daniel -- |: Red Hat, Engineering, London -o-

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Tom Brown
Daniel P. Berrange wrote: On Tue, Jan 06, 2009 at 11:57:34AM -, gerhardus.geldenh...@gta-travel.com wrote: No it does not use xend. # ps auxwww | grep xen root21 0.0 0.0 0 0 ?S2008 0:00 [xenwatch] root22 0.0 0.0 0 0 ?

[libvirt] Re: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread David Edmondson
There's an assumption that XenEnterprise actually uses xend. Is that the case? ('ps' might tell you) dme. -- David Edmondson, Sun Microsystems, http://dme.org -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

RE: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Gerhardus.Geldenhuis
Damm, Well at least a conclusive answer. I am assuming it would be relatively big undertaking to write a new driver? Regards -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list- boun...@redhat.com] On Behalf Of Daniel P. Berrange Sent: 06 January 2009 12:00

Re: [libvirt] [PATCH] save state as string

2009-01-06 Thread Daniel Veillard
On Mon, Dec 29, 2008 at 03:44:54PM +0100, Guido Günther wrote: Hi, current domstatus code saves the domain as number, attached patch safes it as string which looks a bit nicer. [...] @@ -1414,7 +1416,9 @@ qemudDomainStatusFormat(virConnectPtr conn, char *config_xml = NULL, *xml = NULL;

Re: [libvirt] [PATCH] split out logfile opening

2009-01-06 Thread Daniel Veillard
On Mon, Jan 05, 2009 at 07:52:26AM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: attached patch splits out the qemu logfile opening into a separate function which makes the code a bit more readable and I'll need this for the libvirtd restart code. ... +static int

Re: [libvirt] [PATCH] dist: distribute all libvirt_*.syms files, ...

2009-01-06 Thread Daniel Veillard
On Tue, Jan 06, 2009 at 12:11:42PM +0100, Jim Meyering wrote: Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally. Yes we need all the remaining sym files to be embedded in the distribution, +1 thanks, Daniel -- Daniel Veillard | libxml Gnome XML

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Daniel Veillard
On Tue, Jan 06, 2009 at 12:08:14PM -, gerhardus.geldenh...@gta-travel.com wrote: Damm, Well at least a conclusive answer. I am assuming it would be relatively big undertaking to write a new driver? No idea, look at other drivers, some are simple enough, others are more complex. But

Re: [libvirt] PATCH: Fix Windows / mingw32 build

2009-01-06 Thread Daniel Veillard
On Tue, Jan 06, 2009 at 12:48:00PM +, Daniel P. Berrange wrote: There are a number of problems breaking the windows / mingw build currently. - Use of 'close' without importing unistd.h - Use of non-existant localtime_r oops :-) - ERROR macro from logging.h clashes with a symbol

Re: [libvirt] PATCH: Fix Windows / mingw32 build

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 03:41:49PM +0100, Daniel Veillard wrote: On Tue, Jan 06, 2009 at 12:48:00PM +, Daniel P. Berrange wrote: There are a number of problems breaking the windows / mingw build currently. - Use of 'close' without importing unistd.h - Use of non-existant

Re: [libvirt] [PATCH] dist: distribute all libvirt_*.syms files, ...

2009-01-06 Thread Jim Meyering
Daniel Veillard veill...@redhat.com wrote: On Tue, Jan 06, 2009 at 12:11:42PM +0100, Jim Meyering wrote: Some of the new libvirt_*.syms files were included in EXTRA_DIST only conditionally. Yes we need all the remaining sym files to be embedded in the distribution, +1 Thanks. committed.

[libvirt] [PATCH] fix make dist (from scratch) failure

2009-01-06 Thread Jim Meyering
Daniel Veillard noticed that make dist would fail when run from a clean source directory, due to our attempt to distribute a no-longer-generated file. I've committed this: From 97e99d702dbb15176177bfd2055632ee6fdb6491 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 6

Re: [libvirt] PATCH: Fix Windows / mingw32 build

2009-01-06 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: There are a number of problems breaking the windows / mingw build currently. - Use of 'close' without importing unistd.h - Use of non-existant localtime_r - ERROR macro from logging.h clashes with a symbol imported from windows.h So this

Re: [libvirt] [PATCH] save state as string

2009-01-06 Thread Guido Günther
On Tue, Jan 06, 2009 at 03:27:52PM +0100, Daniel Veillard wrote: On Mon, Dec 29, 2008 at 03:44:54PM +0100, Guido Günther wrote: Hi, current domstatus code saves the domain as number, attached patch safes it as string which looks a bit nicer. [...] @@ -1414,7 +1416,9 @@

Re: [libvirt] [PATCH] split out logfile opening

2009-01-06 Thread Guido Günther
On Tue, Jan 06, 2009 at 03:28:59PM +0100, Daniel Veillard wrote: On Mon, Jan 05, 2009 at 07:52:26AM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: attached patch splits out the qemu logfile opening into a separate function which makes the code a bit more readable and

Re: [libvirt] [PATCH] split out logfile opening

2009-01-06 Thread Jim Meyering
Guido Günther a...@sigxcpu.org wrote: On Tue, Jan 06, 2009 at 03:28:59PM +0100, Daniel Veillard wrote: On Mon, Jan 05, 2009 at 07:52:26AM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: attached patch splits out the qemu logfile opening into a separate function which

Re: [libvirt] 5 minor cleanups

2009-01-06 Thread Guido Günther
On Mon, Jan 05, 2009 at 08:00:56AM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: these accumulated over time. O.k. to apply? Those all look fine. From 35569e95febc37818998cd1834099090a3cf852d Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?=

Re: [PATCH] virKillProcess [was Re: [libvirt] [PATCH 2/5] daemonize qemu processes]

2009-01-06 Thread Guido Günther
On Mon, Jan 05, 2009 at 09:58:06AM +, Daniel P. Berrange wrote: On Mon, Dec 29, 2008 at 03:36:15PM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 02:22:42PM +0100, Daniel Veillard wrote: On Mon, Dec 15, 2008 at 11:21:20AM +, Daniel P. Berrange wrote: On Fri, Dec 12, 2008 at

Re: [libvirt] [PATCH] save state as string

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 04:38:50PM +0100, Guido G?nther wrote: On Tue, Jan 06, 2009 at 03:27:52PM +0100, Daniel Veillard wrote: On Mon, Dec 29, 2008 at 03:44:54PM +0100, Guido Günther wrote: Hi, current domstatus code saves the domain as number, attached patch safes it as string which

Re: [libvirt] [PATCH] fix make dist (from scratch) failure

2009-01-06 Thread John Levon
On Tue, Jan 06, 2009 at 04:25:32PM +0100, Jim Meyering wrote: I've committed this: Thanks, and sorry for getting this wrong. regards john -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] PATCH: Fix Windows / mingw32 build

2009-01-06 Thread Daniel P. Berrange
On Tue, Jan 06, 2009 at 04:38:12PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: There are a number of problems breaking the windows / mingw build currently. - Use of 'close' without importing unistd.h - Use of non-existant localtime_r - ERROR macro from

Re: [libvirt] PATCH: Fix Windows / mingw32 build

2009-01-06 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 06, 2009 at 04:38:12PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: There are a number of problems breaking the windows / mingw build currently. - Use of 'close'

[libvirt] PATCH: Implement virKill for Windows

2009-01-06 Thread Daniel P. Berrange
The addition of virKill to src/util.c breaks Windows build which lacks the kill() function. Now we technically don't have any code which runs virKill when built on Windows, but after the 2 weeks holiday I'm very motivated so wrote a basic implement of virKill() which is a starting point for Win32

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Michael DeHaan
Daniel Veillard wrote: On Tue, Jan 06, 2009 at 12:08:14PM -, gerhardus.geldenh...@gta-travel.com wrote: Damm, Well at least a conclusive answer. I am assuming it would be relatively big undertaking to write a new driver? No idea, look at other drivers, some are simple enough,

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-06 Thread Atsushi SAKAI
Hello, Just one question. How about using XenAPI for XenEnterprise? I am not familiar with XenEnterprise. But It should have some API for a developer. Thanks Atsushi SAKAI Daniel Veillard veill...@redhat.com wrote: On Tue, Jan 06, 2009 at 12:08:14PM -,