On Sat, May 02, 2009 at 07:48:50PM +0200, jens wrote:
> Hello,
>
> I tried to migrate a kvm domain to a second identical machine with the
> command:
> virsh migrate --live dom1 qemu+ssh://second.machine.org/system which
> leads me to an unresponsive virsh on the second machine - 'virsh list'
> jus
On Sun, May 03, 2009 at 09:21:20PM +0200, Felix Schwarz wrote:
> So how can I use USB pass through? Could this be Windows-related? Judging from
> all the other threads (like [1]) it should be really easy to use.
Yes, it usually is. I had problems with older KVM as well. Try updating
to 84 or 85.
Ch
In this case we reference def with is NULL. O.k. to apply?
Cheers,
-- Guido
>From ff82eb24e50b4f80769bd932ca739e8a2539edb4 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Mon, 4 May 2009 21:29:15 +0200
Subject: [PATCH 1/2] don't crash with def == NULL
happens when calling l
Hi,
attached patch makes it easier to detect bogus paths when
creating/removing pidfiles. O.k. to apply?
Cheers,
-- Guido
>From f79fcd99b28e36cbb80bd91ac52109148eafa814 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Mon, 4 May 2009 21:31:57 +0200
Subject: [PATCH] return EIN
On Tue, May 05, 2009 at 10:38:12AM +0100, Daniel P. Berrange wrote:
> On Mon, May 04, 2009 at 09:40:33PM +0200, Guido G?nther wrote:
> > Hi,
> > attached patch makes it easier to detect bogus paths when
> > creating/removing pidfiles. O.k. to apply?
>
> ACK
Applied.
-- Guido
--
Libvir-list maili
On Tue, May 05, 2009 at 10:37:49AM +0100, Daniel P. Berrange wrote:
> On Mon, May 04, 2009 at 09:39:04PM +0200, Guido G?nther wrote:
> > In this case we reference def with is NULL. O.k. to apply?
> > Cheers,
>
> ACK, but what code would call libvirt_lx without args ?
No code but a human being (me
Hi,
virsh fails with:
10:47:37.104: debug : do_open:922 : no name, allowing driver auto-select
10:47:37.104: debug : do_open:930 : trying driver 0 (Test) ...
10:47:37.104: debug : do_open:936 : driver 0 Test returned DECLINED
10:47:37.104: debug : do_open:930 : trying driver 1 (OPENVZ) ...
10:47:3
Hi,
not having set up pfuncs already results in a core dump. O.k. to
apply?
Cheers,
-- Guido
>From f01472982e8a00c98937a6f4a41c59a061a9ed98 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Thu, 7 May 2009 10:31:21 +0200
Subject: [PATCH] don't crash if init fails early
---
s
On Thu, May 07, 2009 at 11:25:49AM +0200, Pritesh Kothari wrote:
> On Thursday 07 May 2009 10:52:15 Guido Günther wrote:
> > Hi,
> > not having set up pfuncs already results in a core dump. O.k. to
> > apply?
>
> ACK,
Applied now.
-- Guido
--
Libvir-list mailing
On Thu, May 07, 2009 at 10:25:34AM +0100, Daniel P. Berrange wrote:
> On Thu, May 07, 2009 at 11:19:01AM +0200, Pritesh Kothari wrote:
> > On Thursday 07 May 2009 10:50:54 Guido Günther wrote:
> > > Hi,
> > > virsh fails with:
> > >
> > > 10:47:37
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
> The patches we just applied for the VirtualBox open method still were
> not quite right. It would return VIR_DRV_OPEN_DECLINED when uri==NULL,
> but before doing so it would have set conn->uri to vbox:///session. So
> even thou
On Thu, Jun 18, 2009 at 12:20:40PM -0400, Jim Paris wrote:
> Daniel P. Berrange wrote:
> > We close the socket to the 'nc' process here so in theory it should
> > be getting a HUP event from poll or EOF from read, etc and then
> > exiting. Ominously though I see several patches to Fedora's 'nc'
> >
On Wed, Jul 01, 2009 at 10:58:57PM +0100, Andreas Sommer wrote:
> I'm still experimenting around with the vTPM patch, and I want to
> install my version of libvirt on a Debian system - not in my $HOME
> directory but on the default paths. I followed the autogen command below
> and also did "m
Hi,
in current git make distcheck currently fails on me with:
make[5]: Entering directory
`/var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib'
/bin/sh ../../../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I../../../gnulib/lib -I../.. -I../../intl -g -O2 -M
Hi,
attached patch makes the path to the xen userspace tools configurable.
Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/.
We don't have the amd64 libs in /usr/lib64/xen either so we can use:
./configure --with-xen-tools=/usr/lib/xen-defaults
--with-xen-tools64=/usr/lib/xe
On Tue, Jul 07, 2009 at 06:02:20PM +0100, Daniel P. Berrange wrote:
> On Tue, Jul 07, 2009 at 01:16:02PM +0200, Guido G?nther wrote:
> > Hi,
> > attached patch makes the path to the xen userspace tools configurable.
> > Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/.
> > We
Hi,
the python example imports pygtk but uses gtk.main() so it fails to
work. Attached patch fixes this.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Wed, 22 Jul 2009 12:00:47 +0200
Subject: [PATCH] use gtk instead of pygtk
the example uses gtk.* everywhere else
---
examples/e
Hi,
the python example is lacking the details argument in the callback. This
makes the example fail due to the wrong number of arguments.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Wed, 22 Jul 2009 12:01:36 +0200
Subject: [PATCH] add missing details argument
---
examples/even
Hi,
attached patch updates the console docs a bit. O.k. to apply?
Cheers,
-- Guido
>From 204361a3f015601e389f9ab83a2590906cb44581 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?=
Date: Thu, 23 Jul 2009 09:39:22 +0200
Subject: [PATCH] document tcp listen and raw wire option
---
do
Hi,
attached patch looks for the DMI information in /sys/class since older
kernels (e.g. 2.6.26) have it there.
Cheers,
-- Guido
From: =?UTF-8?q?Guido=20G=C3=BCnther?=
Date: Thu, 7 Jan 2010 10:13:51 +0100
Subject: [PATCH] Also look for dmi information in /sys/class
older kernels such as 2.6.26 h
On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote:
> Looks safe to me, assuming the kernel information are exported in the
> same way,
Yes, it seems to be the same. Pushed now.
Cheers,
-- Guido
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/lis
On Mon, Jan 11, 2010 at 04:15:45PM -0500, Dave Allan wrote:
> On 01/11/2010 06:53 AM, Guido Günther wrote:
> >On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote:
> >> Looks safe to me, assuming the kernel information are exported in the
> >> same way,
On Sat, Jan 16, 2010 at 06:24:28PM +0100, Marc Haber wrote:
> Hi,
>
> On Fri, Jan 15, 2010 at 03:13:25PM +0100, Marc Haber wrote:
> > $ dpkg --list *kvm*
> > Desired=Unknown/Install/Remove/Purge/Hold
> > |
> > Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
> > |/ Err
On Sun, Jan 17, 2010 at 01:27:21PM +0100, Matthias Bolte wrote:
> 2010/1/17 Guido Günther :
> > On Sat, Jan 16, 2010 at 06:24:28PM +0100, Marc Haber wrote:
> >> Hi,
> >>
> >> On Fri, Jan 15, 2010 at 03:13:25PM +0100, Marc Haber wrote:
> >> > $
Hi,
Debian's (and therefore likely the derivatives') kernel headers are
lacking the typdef for sa_family_t in linux/socket.h so the
compilation of the macvtap check fails. Additionally including
sockaddr.h fixes this and doesn't hurt the other cases where there's
also a typedef in socket.h since th
Hi Matthias,
On Mon, Mar 08, 2010 at 08:28:07PM +0100, Matthias Bolte wrote:
> 2010/3/8 Dimitris Kalogeras :
> > Hi *,
> >
> > Apologies for cross posting.
> > I have installed the the libvirt and virt-toolss in an ubuntu karmic
> > 9.10. I am trying to access-manage an ESX 3.5i via ssh protocol.
>
Hi,
virsh dominfo domain crashes with:
#0 strlen () at ../sysdeps/i386/i486/strlen.S:69
#1 0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940,
secmodel=0xb5676ede) at qemu/qemu_driver.c:4911
#2 0xb7eb5623 in virNodeGetSecurityModel (conn=0x8133940, secmodel=0x0) at
libvirt.c:5118
#3 0x
Hi,
kvm 72 uses "info migration" instead of "info migrate":
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574272
It's not only that, the output format of these commands differs too so
that "virsh save" breaks. Stefan suggested the attached improved error
message.
Cheers,
-- Guido
>From cbb911
On Fri, Mar 19, 2010 at 06:19:02PM +0100, Guido Günther wrote:
> Hi,
> kvm 72 uses "info migration" instead of "info migrate":
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574272
>
> It's not only that, the output format of these commands differ
On Fri, Mar 19, 2010 at 04:21:43PM -0400, Ric Foster wrote:
>
>
> https://bugzilla.redhat.com/show_bug.cgi?id=526913
>
>
> Will this bug get fixed? I had hoped the using CLVM would keep the
> guest disk image from getting corrupted if a running guest was
> inadvertently started on another clus
On Thu, Mar 18, 2010 at 02:48:46PM +0100, Daniel Veillard wrote:
> On Wed, Mar 17, 2010 at 09:11:07PM +0100, Guido Günther wrote:
> > Hi,
> >
> > virsh dominfo domain crashes with:
> >
> > #0 strlen () at ../sysdeps/i386/i486/strlen.S:69
> > #1 0x0808
Hi,
On Tue, Apr 06, 2010 at 12:50:31PM +, Frederik Himpe wrote:
> I updated my system from libvirt 0.7.1 to 0.7.7, one of my qemu-kvm VMs
> was not starting anymore, with this error:
>
> LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin HOME=/ TMPDIR=/tmp
> QEMU_AUDIO_DRV=none /usr/bin/qemu-kvm -S
On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote:
> On 04/19/2010 10:16 AM, Guido Günther wrote:
[..snip..]
> since the former is O(1) while the latter is nominally O(n) in the
Good point. New patch attached.
-- Guido
>From 6dc897319fd6ff6863895ffac01e5a38ba911abd Mon Sep 17
On Tue, Apr 20, 2010 at 02:20:05PM -0600, Eric Blake wrote:
> On 04/20/2010 02:18 PM, Guido Günther wrote:
> > On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote:
> >> On 04/19/2010 10:16 AM, Guido Günther wrote:
> > [..snip..]
> >> since the former is O(1
Hi Daniel.
On Mon, Mar 03, 2008 at 10:13:12AM -0500, Daniel Veillard wrote:
> It was really time for a new release, quite a lot of patches had accumulated
> since the previous one ! Available at
> ftp://libvirt.org/libvirt
Cool thing! Unfortunatley this release breaks kvm/qemu bridged
networ
On Fri, Mar 07, 2008 at 04:23:13PM +0100, Guido Günther wrote:
> Hi Daniel.
> On Mon, Mar 03, 2008 at 10:13:12AM -0500, Daniel Veillard wrote:
> > It was really time for a new release, quite a lot of patches had
> > accumulated
> > since the previous one ! A
__virErrorMsg is a mix of tabs and spaces which makes it a bit
hard to read. This patch cleans this up. Please apply.
-- Guido
---
src/virterror.c | 318 +++---
1 files changed, 159 insertions(+), 159 deletions(-)
diff --git a/src/virterror.c b/s
This patch marks the error messages in qemu_driver.c as translatable,
some of them were marked as such already. Please apply.
-- Guido
---
src/qemu_driver.c | 200 ++--
1 files changed, 100 insertions(+), 100 deletions(-)
diff --git a/src/qemu_dr
Most of the error messages don't pass a final newline. Strip the ones
that still do so for consistency. Please apply.
-- Guido
---
src/qemu_driver.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driv
HI Daniel,
On Mon, Mar 24, 2008 at 03:56:07AM -0400, Daniel Veillard wrote:
> Hum, could you send those kind of patches as attachments in the future ?
> Basically assuming spaces/tabs are correctly preserved in an email body is
> taking unecessary risks. Also having a name for the patch and being
On Tue, Mar 25, 2008 at 06:26:02AM -0400, Daniel Veillard wrote:
> To me the patch I got replaced all tabs instead of using tabs for
> indenting of 2 levels. I also have
What the other libvirt code I mentioned does is: it uses spaces
everywhere and no tabs. You can't mix tab with space indentatio
Hi Felix,
On Wed, Mar 26, 2008 at 02:52:14PM +0100, Felix Krohn wrote:
> Since I was using the version from etch-backports
> (http://packages.qa.debian.org/libv/libvirt.html) I don't think so.
The version on backports.org doesn't even have xen support enabled due
to the missing libxen in Debian Len
On Wed, Mar 26, 2008 at 02:23:05PM +, Richard W.M. Jones wrote:
> Currently (libvirt 0.4.0-6) the logic is:
There's a 0.4.1 package in exprimental but the autobuilder didn't pick
it up yet so it's only available on ppc:
http://packages.debian.org/experimental/libvirt-bin
I'll move that one
...this makes things just a bit more readable.
-- Guido
---
src/virterror.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/virterror.c b/src/virterror.c
index 1e39be4..1463129 100644
--- a/src/virterror.c
+++ b/src/virterror.c
@@ -19,7 +19,9 @@
#include "internal
Hi,
when trying to undefine a running qemu domain the domain name gets
corrupted:
$ ./virsh undefine system1
Name: /�em1
libvir: QEMU error /�em1: internal error cannot delete active domain
error: Failed to undefine domain system1
the reaseon is that in qemud/remote.c the domain is freed after f
...and here's the patch attached again. It seems mailman stripped the
attachment and the original mail into two parts because of the git
headers.
-- Guido
---
src/virterror.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/src/virterror.c b/src/virterror.c
i
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote:
> 1) If libvirtd is running as root, main() will try to change the group
> ownership of /var/run/libvirt to one specified by unix_sock_gid.
> 2) Default permissions on /var/run/libvirt are now 0750
How does this match with the defaul
On Thu, Jul 31, 2014 at 12:01:03PM -0400, Daniel Veillard wrote:
>Is available, it is tagged in git and signed rpms are available
> at the usual place:
>ftp://libvrt.org/libvirt/
>
> I'm travelling/meeting busy so I hadn't had time this time to run
> my usual testing, so please really giv
This fixes compilation on kFreeBSD which otherwise fails like
CC util/libvirt_util_la-virprocess.lo
In file included from /usr/include/sys/cpuset.h:35:0,
from util/virprocess.c:43:
/usr/include/sys/_cpuset.h:49:43: error: 'NBBY' undeclared here (not in
a function)
long _
Otherwise we fail like
libvirt version: 1.2.7, package: 6 (root 2014-08-08-16:09:22 bogon)
virAuditOpen:62 : Unable to initialize audit layer: Protocol not supported
virFileGetDefaultHugepageSize:2958 : internal error: Unable to parse
/proc/meminfo
virStateInitialize:749 : Initialization
On Mon, Aug 11, 2014 at 11:17:10AM +0200, Michal Privoznik wrote:
> On 10.08.2014 13:51, Guido Günther wrote:
> >Otherwise we fail like
> >
> > libvirt version: 1.2.7, package: 6 (root 2014-08-08-16:09:22 bogon)
> > virAuditOpen:62 : Unable to initialize audit la
This fixes compilation on kFreeBSD which otherwise fails like
CC util/libvirt_util_la-virprocess.lo
In file included from /usr/include/sys/cpuset.h:35:0,
from util/virprocess.c:43:
/usr/include/sys/_cpuset.h:49:43: error: 'NBBY' undeclared here (not in
a function)
long _
This tries to address
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688778
were libvirt autodetected vbox:///session and it wasn't listed in the
manpage.
---
tools/virsh.pod | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 26b1d79..afaca5b 100
On Mon, Aug 11, 2014 at 02:13:15PM -0600, Eric Blake wrote:
> On 08/11/2014 02:04 PM, Guido Günther wrote:
> > This tries to address
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688778
> >
> > were libvirt autodetected vbox:///session and it
On Mon, Aug 11, 2014 at 10:55:47AM -0600, Eric Blake wrote:
> On 08/11/2014 04:23 AM, Guido Günther wrote:
> > This fixes compilation on kFreeBSD which otherwise fails like
> >
> > CC util/libvirt_util_la-virprocess.lo
> > In file included from /us
On Mon, Aug 11, 2014 at 11:17:10AM +0200, Michal Privoznik wrote:
> On 10.08.2014 13:51, Guido Günther wrote:
> >Otherwise we fail like
> >
> > libvirt version: 1.2.7, package: 6 (root 2014-08-08-16:09:22 bogon)
> > virAuditOpen:62 : Unable to initialize audit la
Hi,
On Wed, Sep 03, 2014 at 11:07:20PM -0400, Hongbin Lu wrote:
[..snip..]
> +
> +if (virAsprintf(uri_out, "tcp://%s", hostname) < 0)
> +goto error;
Since OpenVZ tunnels over ssh shouldn't this be something like ssh://
?
Cheers,
-- Guido
--
libvir-list mailing list
libvir-list@redha
On Fri, Aug 29, 2014 at 12:03:24PM +0200, Daniel Veillard wrote:
> On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote:
> > On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard
> > wrote:
> > > So I tagged 1.2.8-rc1 in git and made tarball and signed rpms
> >
> > Can you please sign
On Thu, Sep 11, 2014 at 02:45:41PM +1000, Blair Bethwaite wrote:
> Hi Michael!
>
> On 11 September 2014 14:13, Michael Chapman wrote:
> > Why is RBD is handled specially in this function? The current logic is that
> > an RBD-backed disk is safe to be migrated even if it's got caching enabled,
> >
to ACK this from a libvirt point of view
since I've lost a bit track over the different migration protocols.
Cheers,
-- Guido
>
> Best regards,
> Hongbin
>
>
> On Thu, Sep 4, 2014 at 1:42 AM, Guido Günther wrote:
>
> > Hi,
> > On Wed, Sep 03,
On Wed, Sep 17, 2014 at 04:24:07PM -0600, Eric Blake wrote:
> Any objections to retiring the v0.9.6-maint branch? After all, we have
> already retired the v0.9.11-maint branch
> (http://libvirt.org/git/?p=libvirt.git;a=commit;h=cd0d348ed), and the
> only activity on v0.9.6-maint since 0.9.6.4 was
On Sun, Jun 28, 2015 at 01:00:01PM +0800, Daniel Veillard wrote:
>
> Following discussions on Friday, I applied the patches to deactivate
> the subset of Admin APIs and revert from 1.3.0 to 1.2.17. I then tagged
> in git and pushed signed tarballs and rpms to the usual place:
>
> ftp://libvir
On Tue, Jun 30, 2015 at 03:00:09PM +0800, Daniel Veillard wrote:
> On Mon, Jun 29, 2015 at 10:34:55PM +0200, Guido Günther wrote:
> > On Sun, Jun 28, 2015 at 01:00:01PM +0800, Daniel Veillard wrote:
> > >
> > > Following discussions on Friday, I applied the patc
This fixes
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
---
This is only catched by Debian Wheezy's gcc 4.7.2, Jessi
Hi,
On Thu, Jul 09, 2015 at 07:28:34PM +0200, Peter Krempa wrote:
> On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
> > This fixes
> >
> > CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
> > qemu/qemu_conf.c: In function 'qemuRemoveSharedDevi
On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote:
[..snip..]
> +def get_url(server, path, headers):
> +url = "https://"; + server + path
> +debug(" Fetching %s..." % url)
> +
> +req = urllib2.Request(url=url)
This does not seem to do any certificate validation (just i
On Fri, Jul 31, 2015 at 09:42:16AM +0100, Daniel P. Berrange wrote:
> On Fri, Jul 31, 2015 at 09:15:13AM +0200, Guido Günther wrote:
> > On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote:
> > [..snip..]
> > > +def get_url(server, path, headers):
> > >
When running the test suite using "unshare -n" we might have IPv6 but no
configured addresses. Due to AI_ADDRCONFIG getaddrinfo then fails with
EAI_NONAME which we should then treat as IPv6 unavailable.
---
src/rpc/virnetsocket.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Otherwise we're leaking some 30+ symbols like
virAdmConnectClass
virAdmConnectNew
virConnectClass
virConnectCloseCallbackDataClass
virDomainClass
...
I marked the one symbol needed by the deamon as
LIBVIRT_ADMIN_PRIVATE_ for now.
---
There's likely a better solution for xdr_adm
On Tue, Aug 11, 2015 at 01:22:39PM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 11, 2015 at 01:46:44PM +0200, Guido Günther wrote:
> > When running the test suite using "unshare -n" we might have IPv6 but no
> > configured addresses. Due to AI_ADDRCONFIG ge
On Tue, Aug 11, 2015 at 06:38:32PM +0600, Dmitriy Slachshyov wrote:
[..snip..]
> 9) SSH test 1...
> libvirt: XML-RPC error : End of file while reading data: libvirt: error :
> cannot execute binary ssh: Permission denied: Input/output erro
On Wed, Aug 12, 2015 at 10:37:30AM +0200, Martin Kletzander wrote:
> On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote:
> >Otherwise we're leaking some 30+ symbols like
> >
> > virAdmConnectClass
> > virAdmConnectNew
>
&
On Wed, Aug 12, 2015 at 11:15:58AM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote:
> > Otherwise we're leaking some 30+ symbols like
> >
> >virAdmConnectClass
> >virAdmC
On Wed, Aug 12, 2015 at 01:07:46PM +0100, Daniel P. Berrange wrote:
> On Wed, Aug 12, 2015 at 01:49:46PM +0200, Guido Günther wrote:
> > On Wed, Aug 12, 2015 at 11:15:58AM +0100, Daniel P. Berrange wrote:
> > > On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote:
>
RedHat and Debian based distros use different locations
Reference: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790935
---
configure.ac | 3 +++
src/qemu/qemu_conf.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 46c80ce..96585
Otherwise the error is just
error: Failed to create domain from test1.xml
error: failed to retrieve file descriptor for interface: Transport endpoint
is not connected
since we don't get a sensible error after the fork.
---
src/qemu/qemu_command.c | 6 ++
1 file changed, 6 insertions
On Thu, Aug 13, 2015 at 03:59:53PM +0200, Martin Kletzander wrote:
> On Thu, Aug 13, 2015 at 02:42:44PM +0200, Guido Günther wrote:
> >Otherwise the error is just
> >
> > error: Failed to create domain from test1.xml
> > error: failed to retrieve file descript
On Fri, Jul 10, 2015 at 11:05:42AM +0800, Daniel Veillard wrote:
> On Thu, Jul 09, 2015 at 02:00:10PM -0700, Peter Kieser wrote:
[..snip..]
> > >
> > >Daniel
> > >
> > http://libvirt.org/git/?p=libvirt.git;a=commit;h=1310b1358cdf9c8acba6e0e85feb869241e59faa
> >
> > I had to revert this commit to g
Since we're linking this into libvirtd we need some symbols to be public
but not part of the public API so mark them as
LIBVIRT_ADMIN_PRIVATE_ as we do with libvirt.
Making all other symbols local makes sure we don't accidentally leak
unwanted ones.
---
configure.ac | 2 +-
src
This makes it consistent with the other FLAGS in this file and reduced
clutter in the diff when adding new entries.
---
daemon/Makefile.am | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemon/Makefile.am b/daemon/Makefile.am
index 59bc4d4..be1b5a9 100644
--- a/daemon/
We're using the %.html.tmp for all html files now so drop the unused one
and rather make sure the needed directory exists.
This fixes build failures as described in
https://www.redhat.com/archives/libvir-list/2015-August/msg00603.html
---
configure.ac | 1 +
docs/Makefile.am | 9
On Thu, Aug 20, 2015 at 02:46:18AM +0200, Michal Privoznik wrote:
> On 19.08.2015 14:39, Guido Günther wrote:
> > Since we're linking this into libvirtd we need some symbols to be public
> > but not part of the public API so mark them as
> > LIBVIRT_ADMIN_PRIV
On Thu, Aug 20, 2015 at 03:12:36AM +0200, Michal Privoznik wrote:
> On 19.08.2015 14:40, Guido Günther wrote:
> > We're using the %.html.tmp for all html files now so drop the unused one
> > and rather make sure the needed directory exists.
> >
> > This fixe
Hi,
On Thu, Aug 20, 2015 at 11:19:48AM -0700, Martin Kletzander wrote:
> Commit a2c5d16a70a6161449c687be74db2813b362cf5e switched to generating
> libvirt_admin.syms, but forgot to add the generated file into
> .gitignore, hence causing tree pollution post-build.
I've been building in a separte bui
Hi,
On Thu, Aug 20, 2015 at 10:58:59AM -0700, Peter Kieser wrote:
> Some UEFI firmwares may want to use a non-volatile memory to store some
> variables.
> If AppArmor is enabled, and NVRAM store file is set currently virt-aa-helper
> does
> not add the NVRAM store file to the template. Add this fil
First check overrides, then read only files then restricted access
itself.
as proposed by Martin Kletzander
---
src/security/virt-aa-helper.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
inde
From: intrigeri
We forbid access to /usr/share/, but (at least on Debian-based systems)
the Open Virtual Machine Firmware files needed for booting UEFI virtual
machines in QEMU live in /usr/share/ovmf/. Therefore, we need to add
that directory to the list of read only paths.
A similar patch was
Hi,
On Fri, Aug 21, 2015 at 11:44:11AM +0200, intrigeri wrote:
> Hi,
>
> this patchset breaks the test suite for me once applied on top of the
> debian/experimental branch (while the test suite passes fine without
> these patches there). Sorry, no time to look into it further today.
I can reprodu
---
src/security/virt-aa-helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 4ce1e7a..178569e 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -107,12 +107,14 @@ vah_usage(void)
From: intrigeri
We forbid access to /usr/share/, but (at least on Debian-based systems)
the Open Virtual Machine Firmware files needed for booting UEFI virtual
machines in QEMU live in /usr/share/ovmf/. Therefore, we need to add
that directory to the list of read only paths.
A similar patch was
First check overrides, then read only files then restricted access
itself.
This allows us to mark files for read only access whose parents were
already restricted for read write.
Based on a proposal by Martin Kletzander
---
src/security/virt-aa-helper.c | 29 ++---
1 file
. The
tests pass here and I've added an additional patch checking the new file.
Cheers,
-- Guido
Guido Günther (2):
virt-aa-helper: document --probing and --dry-run
virt-aa-helper: Simplify restriction logic
intrigeri (1):
virt-aa-helper: allow access to /usr/share/ovmf/
src/sec
While a zero allocation in safezero should be fine it isn't when we use
posix_fallocate which returns EINVAL on a zero allocation.
While we could skip the zero allocation in safezero_posix_fallocate it's
an optimization to do it for all allocations.
This fixes vm installation via virtinst for me
While a zero allocation in safezero should be fine it isn't when we use
posix_fallocate which returns EINVAL on a zero allocation.
While we could skip the zero allocation in safezero_posix_fallocate it's
an optimization to do it for all allocations.
This fixes vm installation via virtinst for me
Hi,
On Mon, Aug 24, 2015 at 11:47:48AM +0200, Martin Kletzander wrote:
> On Mon, Aug 24, 2015 at 11:01:34AM +0200, intrigeri wrote:
> >Hi,
> >
> >Martin Kletzander wrote (21 Aug 2015 21:44:49 GMT) :
> >>I have no way to check for the virt-aa-helper test, so limited ACK
> >>from me.
> >
> >I've appl
Hi,
On Mon, Aug 24, 2015 at 01:27:42PM +0200, Martin Kletzander wrote:
> On Mon, Aug 24, 2015 at 12:55:22PM +0200, Guido Günther wrote:
> >While a zero allocation in safezero should be fine it isn't when we use
> >posix_fallocate which returns EINVAL on a zero allocation.
&
Remove unused variable, tag unused parameter and adjust return type.
introduced by 3f48345f7ec0c44b8ce2371cab454d2118f830b4
CC security/libvirt_security_manager_la-security_selinux.lo
security/security_selinux.c: In function 'virSecuritySELinuxDomainSetDirLabel':
security/security_selinux.c:2
On Mon, Aug 24, 2015 at 02:52:14PM +0200, Martin Kletzander wrote:
> On Mon, Aug 24, 2015 at 02:14:37PM +0200, Guido Günther wrote:
> >Remove unused variable, tag unused parameter and adjust return type.
> >
> >introduced by 3f48345f7ec0c44b8ce2371cab454d2118f830b4
&
Hi,
On Wed, Aug 26, 2015 at 03:53:43PM +0100, Daniel P. Berrange wrote:
> Older versions of glibc don't provide the setns() syscall
> function wrapper, so we must define it ourselves to prevent
> build failure on old distros.
>
> Signed-off-by: Daniel P. Berrange
>
> Pushed as a RHEL-6 build-bre
f1f68ca33 moved the monitor socket to a per domain directory. Adjust the
path accordingly.
---
It'd be nice to have this in 1.2.19 since it unbreaks starting qemu based
domains.
src/security/virt-aa-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/virt-aa
201 - 300 of 1147 matches
Mail list logo
