Re: [libvirt] ANNOUNCE: libvirt 1.0.5.6 maintenance release

2013-10-02 Thread Guido Günther
On Wed, Oct 02, 2013 at 10:59:03AM +0200, Christophe Fergeau wrote: On Mon, Sep 23, 2013 at 01:36:40PM -0400, Cole Robinson wrote: I basically do: - quick smoke test to make sure libvirt and virsh are working: -- stop system libvirtd -- sudo ./daemon/libvirt -- sudo ./tools/virsh

[libvirt] [PATCH] Also undef WITH_GNUTLS_GCRYPT

2013-10-22 Thread Guido Günther
If we disallow gnutls we need to disallow gcrypt to since WITH_GNUTLS_GCRYPT only works with WITH_GNUTLS per configure.ac. Othwise we fail to build .libs/libvirt_setuid_rpc_client_la-libvirt.o like: libvirt.c:314:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type static

[libvirt] [PATCH] virt-login-shell: also build virAtomic.h

2013-11-05 Thread Guido Günther
Needed for architectures that don't use gcc atomic ops but pthread. This fixes the armel build that otherwise breaks like: CCLD virt-login-shell ../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-virobject.o): In function `virClassNew':

Re: [libvirt] [PATCH] virt-login-shell: also build virAtomic.h

2013-11-05 Thread Guido Günther
On Tue, Nov 05, 2013 at 09:01:29AM -0700, Eric Blake wrote: On 11/05/2013 08:44 AM, Guido Günther wrote: Needed for architectures that don't use gcc atomic ops but pthread. This fixes the armel build that otherwise breaks like: CCLD virt-login-shell ../src/.libs/libvirt-setuid

Re: [libvirt] [PATCH]docs: fix a typo in formatnwfilter

2013-11-06 Thread Guido Günther
On Wed, Nov 06, 2013 at 03:38:00PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/fragement/fragment Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- docs/formatnwfilter.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH] Don't depend on syslog.service

2013-11-11 Thread Guido Günther
Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it. References: http://www.freedesktop.org/wiki/Software/systemd/syslog/ http://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-target.html

[libvirt] [PATCH] Only determine GuestCPU features if required

2013-11-11 Thread Guido Günther
There's no need to probe CPU features if we don't need them later. Debian Wheezy's QEMU 1.1.2 lacks the feature-word option so this unbreaks starting domains that got broken by d94b7817719b064849818b9ba6c37e403b7c003c like error: internal error: unable to execute QEMU command 'qom-get':

Re: [libvirt] [PATCH 1/2] qemu: Change return type of qemuMonitorGetGuestCPU()

2013-11-12 Thread Guido Günther
On Tue, Nov 12, 2013 at 10:04:09AM +0100, Peter Krempa wrote: To allow returning more granullar errors, change the error type to an integer. --- src/qemu/qemu_monitor.c | 19 --- src/qemu/qemu_monitor.h | 5 +++-- src/qemu/qemu_monitor_json.c | 26

Re: [libvirt] [PATCH 2/2] qemu: Check for presence of device and properities when getting CPUID

2013-11-12 Thread Guido Günther
On Tue, Nov 12, 2013 at 10:04:33AM +0100, Peter Krempa wrote: The QOM path in qemu that contains the CPUID registers of a running VM may not be present (introduced in QEMU 1.5). Since commit d94b7817719 we have a regression with QEMU that don't support reporting of the CPUID register state

Re: [libvirt] [PATCH libvirt-python 00/14] Split the python binding out

2013-11-13 Thread Guido Günther
On Tue, Nov 12, 2013 at 06:21:43PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This patch series is a followup to https://www.redhat.com/archives/libvir-list/2013-September/msg00413.html I do like this much more than the version from September since it

Re: [libvirt] [PATCH] Don't depend on syslog.service

2013-11-19 Thread Guido Günther
On Mon, Nov 11, 2013 at 10:02:18AM +0100, Guido Günther wrote: Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it. References: http://www.freedesktop.org/wiki/Software/systemd/syslog/ http

Re: [libvirt] [PATCH] Don't depend on syslog.service

2013-11-19 Thread Guido Günther
On Tue, Nov 19, 2013 at 03:14:44PM -0500, Cole Robinson wrote: On 11/11/2013 04:02 AM, Guido Günther wrote: Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it. References: http

[libvirt] [PATCH] Define SANLK_INQ_WAIT if missing in headers

2012-12-13 Thread Guido Günther
so we can build with older sanlock (like 2.2) --- I've applied this to the current Debian builds since we're lagging a bit regarding sanlock but it might make sense to also support this upstream. Cheers, -- Guido src/locking/lock_driver_sanlock.c |3 +++ 1 file changed, 3 insertions(+)

[libvirt] [PATCH] Require SANLK_INQ_WAIT for inq_lockspace support

2012-12-13 Thread Guido Günther
since compilation breaks otherwise with older libsanlock. --- Hi Daniel, does this make more sense then? Cheers, -- Guido configure.ac | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index bf32f95..1936982 100644 --- a/configure.ac

Re: [libvirt] [PATCH] Require SANLK_INQ_WAIT for inq_lockspace support

2012-12-14 Thread Guido Günther
On Thu, Dec 13, 2012 at 03:55:21PM -0700, Eric Blake wrote: On 12/13/2012 03:48 PM, Guido Günther wrote: since compilation breaks otherwise with older libsanlock. --- Hi Daniel, does this make more sense then? Cheers, -- Guido I'm not Daniel, but it looks right to me. ACK

[libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

2012-12-19 Thread Guido Günther
Hi, it seems one of these commits 5411e7e176dcbb65591cb97ec128b5fd0f365805 473011334ccd93e8efbb67f2561f1d4e54d212ae 392c192240566d9e167d2b5a1022092d8f7e045c broke make check as seen on http://honk.sigxcpu.org:8001/job/libvirt-check/417/console output attached. I can't look into this in

Re: [libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

2012-12-19 Thread Guido Günther
On Wed, Dec 19, 2012 at 11:04:38AM +, Daniel P. Berrange wrote: On Wed, Dec 19, 2012 at 09:59:45AM +, Daniel P. Berrange wrote: On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote: Hi, it seems one of these commits 5411e7e176dcbb65591cb97ec128b5fd0f365805

Re: [libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

2012-12-25 Thread Guido Günther
On Wed, Dec 19, 2012 at 02:22:23PM -0700, Eric Blake wrote: On 12/19/2012 01:43 PM, Guido Günther wrote: With the fixes I just pushed, I hope this should be working now. I tested with everything configure option except AppArmor enabled now. All back to green. Thanks a lot! I wonder

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

2013-01-02 Thread Guido Günther
Hi, On Wed, Jan 02, 2013 at 11:20:08AM -0700, Eric Blake wrote: On 01/02/2013 10:29 AM, Jenkins CI wrote: See http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes Changes: [eblake] maint: update to latest gnulib CCLD libvirt_security_manager.la CCLD libvirt.la

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

2013-01-02 Thread Guido Günther
Hi Eric, On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: Hello Jenkins folks, On the libvirt list, we came across a case where a broken commit was detected, but where the information available in the failure report was insufficient (for at least me) to reproduce the failure

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

2013-01-02 Thread Guido Günther
On Wed, Jan 02, 2013 at 11:12:31PM +0100, Guido Günther wrote: Hi Eric, On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: Hello Jenkins folks, On the libvirt list, we came across a case where a broken commit was detected, but where the information available in the failure

Re: [libvirt] [PATCH] build: fix build with optimization enabled

2013-01-03 Thread Guido Günther
On Thu, Jan 03, 2013 at 10:15:06AM -0700, Eric Blake wrote: Build failure detected by Jenkins autobuilder: http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes * .gnulib: Update to latest, for stdio.h rpl_fwrite fix. That fixed it. Thanks a lot! As of the latest update I'm seeing

[libvirt] [PATCH] Install virtlockd.{socket, service} non executable

2013-01-03 Thread Guido Günther
since they're not scripts but systemd service files. --- src/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index f7a9b91..0cfc1ed 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1687,9 +1687,9 @@ DISTCLEANFILES +=

Re: [libvirt] [PATCH] Install virtlockd.{socket, service} non executable

2013-01-04 Thread Guido Günther
On Thu, Jan 03, 2013 at 04:37:51PM -0700, Eric Blake wrote: On 01/03/2013 03:05 PM, Guido Günther wrote: since they're not scripts but systemd service files. --- src/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK. Pushed. Thanks, -- Guido diff

[libvirt] [PATCH] No need to use a .in file for virtlockd.socket

2013-01-05 Thread Guido Günther
since there are no substitutions in it. --- src/Makefile.am | 10 +- src/locking/virtlockd.socket|8 src/locking/virtlockd.socket.in |8 3 files changed, 13 insertions(+), 13 deletions(-) create mode 100644 src/locking/virtlockd.socket

Re: [libvirt] [PATCH 2/4] build: properly substitute virtlockd.socket

2013-01-06 Thread Guido Günther
On Fri, Jan 04, 2013 at 03:36:46PM -0700, Eric Blake wrote: virtlockd.service could be installed to a configurable root, but virtlockd.socket was hardcoded to installation into a distro. * src/Makefile.am (virtlockd.service, virtlockd.socket): Drop unused substitutions. *

Re: [libvirt] [PATCH 3/4] build: .service files don't need to be executable

2013-01-06 Thread Guido Günther
On Fri, Jan 04, 2013 at 03:36:47PM -0700, Eric Blake wrote: See also commit 66ff2dd, where we avoided installing these files as executables. * daemon/Makefile.am (libvirtd.service): Drop chmod. * tools/Makefile.am (libvirt-guests.service): Likewise. * src/Makefile.am (virtlockd.service,

Re: [libvirt] [PATCH 1/4] build: use common .in replacement mechanism

2013-01-06 Thread Guido Günther
On Fri, Jan 04, 2013 at 03:36:45PM -0700, Eric Blake wrote: We had several different styles of .in conversion in our Makefiles: ALLCAPS, @ALLCAPS@, @lower@, ::lower:: Canonicalize on one form, to make it easier to copy and paste between .in files. Also, we were using some non-portable sed

[libvirt] [PATCH] Add missing flags to migrate documentation

2013-01-07 Thread Guido Günther
--- src/libvirt.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 6d1da12..83aeb23 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -5121,10 +5121,15 @@ virDomainMigrateDirect(virDomainPtr domain, * VIR_MIGRATE_UNDEFINE_SOURCE

Re: [libvirt] [PATCH] Add missing flags to migrate documentation

2013-01-07 Thread Guido Günther
On Mon, Jan 07, 2013 at 04:57:14PM -0700, Eric Blake wrote: On 01/07/2013 08:04 AM, Guido Günther wrote: --- src/libvirt.c | 22 ++ 1 file changed, 22 insertions(+) ACK. Pushed. Thanks, -- Guido -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-11 Thread Guido Günther
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1

[libvirt] [PATCH] Don't try to include xattr.h if not available

2013-01-14 Thread Guido Günther
--- tests/securityselinuxhelper.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c index abe4d7c..bd5ea87 100644 --- a/tests/securityselinuxhelper.c +++ b/tests/securityselinuxhelper.c @@ -24,7 +24,9 @@

[libvirt] [PATCH] Fix typo in variable name

2013-01-16 Thread Guido Günther
Hi, I pushed that under the build breaker rule: that broke the build like: CC libvirt_conf_la-domain_conf.lo conf/domain_conf.c: In function 'virDomainVcpuPinAdd': conf/domain_conf.c:11920:29: error: 'vpcupin' undeclared (first use in this function) conf/domain_conf.c:11920:29:

[libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes

2013-01-25 Thread Guido Günther
--- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 712918f..4bd3c3e 100644 --- a/configure.ac +++ b/configure.ac @@ -1810,7 +1810,7 @@ dnl check for (ESX) dnl if test $with_curl != yes ; then - if test $with_esx = check;

Re: [libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes

2013-01-25 Thread Guido Günther
On Fri, Jan 25, 2013 at 02:22:01PM -0700, Eric Blake wrote: On 01/25/2013 02:14 PM, Guido Günther wrote: --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 712918f..4bd3c3e 100644 --- a/configure.ac +++ b

Re: [libvirt] [PATCH] Make python objects inherit from 'object' base class

2013-01-26 Thread Guido Günther
Hi, On Thu, Jan 24, 2013 at 01:17:32PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com As of python = 2.2, it is recommended that all objects inherit from the 'object' base class. We already require python = 2.3 for libvirt for thread macro support, so we should

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-01-29 Thread Guido Günther
Hi, On Mon, Jan 28, 2013 at 07:35:38PM +0100, Peter Krempa wrote: When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still present in the queue

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

2013-02-03 Thread Guido Günther
Hi Eric, On Tue, Jan 29, 2013 at 02:21:30PM -0700, Eric Blake wrote: On 01/29/2013 01:22 PM, Guido Günther wrote: Hi, On Mon, Jan 28, 2013 at 07:35:38PM +0100, Peter Krempa wrote: When reading and dispatching of a message failed the message was freed but wasn't removed from the message

[libvirt] [PATCH] Cosmetics: Remove semicolons

2013-02-06 Thread Guido Günther
It's Python, not C --- python/libvirt-override.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/libvirt-override.py b/python/libvirt-override.py index 8427eab..82d7dcb 100644 --- a/python/libvirt-override.py +++ b/python/libvirt-override.py @@ -107,9 +107,9

Re: [libvirt] [PATCH] Cosmetics: Remove semicolons

2013-02-06 Thread Guido Günther
On Wed, Feb 06, 2013 at 01:26:14PM -0700, Eric Blake wrote: On 02/06/2013 01:07 PM, Guido Günther wrote: It's Python, not C --- python/libvirt-override.py |8 1 file changed, 4 insertions(+), 4 deletions(-) ACK. Pushed. Thanks. -- Guido -- Eric Blake eblake

[libvirt] [PATCH 1/2] Remove more trailing semicolons in Python files

2013-02-07 Thread Guido Günther
--- docs/apibuild.py | 56 docs/index.py | 32 ++--- examples/domain-events/events-python/event-test.py | 24 ++-- python/generator.py| 146 ++--

[libvirt] [PATCH 2/2] Add syntax-check to make sure Python files don't contain trailing semicolon

2013-02-07 Thread Guido Günther
We allow for a trailing semicolon in full line comments since docs/index.py has some SQL statements in it. --- cfg.mk |7 +++ 1 file changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 2dfde01..b92ae85 100644 --- a/cfg.mk +++ b/cfg.mk @@ -702,6 +702,13 @@

Re: [libvirt] [PATCH 2/2] Add syntax-check to make sure Python files don't contain trailing semicolon

2013-02-07 Thread Guido Günther
On Thu, Feb 07, 2013 at 12:39:07PM +, Daniel P. Berrange wrote: On Thu, Feb 07, 2013 at 09:23:01AM +0100, Guido Günther wrote: We allow for a trailing semicolon in full line comments since docs/index.py has some SQL statements in it. --- cfg.mk |7 +++ 1 file changed, 7

[libvirt] [PATCH] Check if classes are derived from object

2013-02-11 Thread Guido Günther
This makes sure we don't regress to old style classes --- Just a minor addition that came up while verifying if the corresponding Debian bug is fixed. python/sanitytest.py | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/python/sanitytest.py

Re: [libvirt] [PATCH] Check if classes are derived from object

2013-02-11 Thread Guido Günther
On Mon, Feb 11, 2013 at 04:24:15PM +, Daniel P. Berrange wrote: On Mon, Feb 11, 2013 at 05:20:31PM +0100, Guido Günther wrote: This makes sure we don't regress to old style classes --- Just a minor addition that came up while verifying if the corresponding Debian bug is fixed

[libvirt] [PATCH] Avoid cast to unit64_t on 32bit platform

2013-02-11 Thread Guido Günther
Fixes compilation on 32bit platforms: xen/xen_hypervisor.c: In function 'virXen_setvcpumap': xen/xen_hypervisor.c:1785:35: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] xen/xen_hypervisor.c:1785:22: error: cast to pointer from integer of different size

[libvirt] [PATCH] qemu: pass -1 as uid/gid for unprivileged qemu

2013-02-17 Thread Guido Günther
so we don't try to change uid/git to 0 when probing capabilities. --- On Fri, Feb 15, 2013 at 11:20:17PM -0600, Doug Goldstein wrote: The following error bisect's down to this commit when running out of my local checkout for testing. 2013-02-16 05:16:55.102+: 29992: error :

Re: [libvirt] [PATCHv2 13/15] util: virSetUIDGIDWithCaps - change uid while keeping caps

2013-02-18 Thread Guido Günther
On Sat, Feb 16, 2013 at 05:53:05PM -0500, Laine Stump wrote: On 02/16/2013 12:20 AM, Doug Goldstein wrote: On Tue, Feb 12, 2013 at 2:15 PM, Laine Stump la...@laine.org wrote: Normally when a process' uid is changed to non-0, all the capabilities bits are cleared, even those explicitly set

[libvirt] [PATCHv2 4/4] Use virParseScaledValue in virDomainParseMemory

2012-05-11 Thread Guido Günther
--- src/conf/domain_conf.c | 37 - 1 file changed, 4 insertions(+), 33 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5e01a8..6073dcf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7706,53 +7706,24 @@

Re: [libvirt] [PATCH] Add support for RAM filesystems for LXC

2012-05-11 Thread Guido Günther
On Wed, May 09, 2012 at 10:00:47AM -0600, Eric Blake wrote: On 05/09/2012 09:49 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a new syntax for filesystems to allow use of a RAM filesystem filesystem type='ram' source usage='1024'/

[libvirt] [PATCHv2 2/4] openvz: support file system quota reporting

2012-05-11 Thread Guido Günther
--- src/openvz/openvz_conf.c| 16 tests/domainschemadata/domain-openvz-simple.xml |2 ++ 2 files changed, 18 insertions(+) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 5f107ed..44637d8 100644 --- a/src/openvz/openvz_conf.c

[libvirt] [PATCHv2 3/4] openvz: add quota argument when creating container

2012-05-11 Thread Guido Günther
--- src/openvz/openvz_driver.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c6d25d7..45ab262 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c

[libvirt] [PATCHv2 1/4] Introduce filesystem limits to virDomainFSDef

2012-05-11 Thread Guido Günther
--- docs/formatdomain.html.in | 12 ++ docs/schemas/domaincommon.rng | 12 ++ src/conf/domain_conf.c| 88 +++-- src/conf/domain_conf.h|2 + 4 files changed, 111 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCHv2 0/4] Filesystem limits for containers

2012-05-11 Thread Guido Günther
This isn't meant for 0.9.12. Guido Günther (4): Introduce filesystem limits to virDomainFSDef openvz: support file system quota reporting openvz: add quota argument when creating container Use virParseScaledValue in virDomainParseMemory docs/formatdomain.html.in | 12

Re: [libvirt] [PATCH] openvz: determine kb/pages only once

2012-05-15 Thread Guido Günther
On Thu, May 10, 2012 at 04:54:59PM -0600, Eric Blake wrote: On 05/08/2012 02:12 PM, Guido Günther wrote: to safe some syscalls (as suggested by Eric Blake) s/safe/save/ --- I've moved the code into an extra module since there's some more code to come that should be shared between

Re: [libvirt] [PATCHv2 0/4] Filesystem limits for containers

2012-05-21 Thread Guido Günther
Hi, On Fri, May 11, 2012 at 11:14:08PM +0200, Guido Günther wrote: Hi, the following patches are a second stab at filesystem limits for containers. With these patches space limits in openvz containers are printed in the domain config as: filesystem type='template' accessmode='passthrough

[libvirt] [PATCHv3 1/4] Introduce virDomainParseScaledValue

2012-05-23 Thread Guido Günther
and use it for virDomainParseMemory. This allows to parse arbitrary scaled value, not only memory related values as needed for the filesystem limits code following later in this series. --- src/conf/domain_conf.c | 94 +++- 1 file changed, 61

[libvirt] [PATCHv3 0/4] Support filesystem limits for containers

2012-05-23 Thread Guido Günther
') * openvz: Check for overflow when parsing DISKSPACE out of the container config * openvz: Fix logic that only sets the hard limit when no soft limit is given and rejects config that only specify a soft limit Cheers, -- Guido Guido Günther (4): Introduce virDomainParseScaledValue

[libvirt] [PATCHv3 3/4] openvz: support file system quota reporting

2012-05-23 Thread Guido Günther
--- src/conf/domain_conf.c |4 ++-- src/openvz/openvz_conf.c| 24 +++ tests/domainschemadata/domain-openvz-simple.xml |2 ++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCHv3 2/4] Introduce filesystem limits to virDomainFSDef

2012-05-23 Thread Guido Günther
--- docs/formatdomain.html.in | 14 ++ docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 30 +++--- src/conf/domain_conf.h|2 ++ 4 files changed, 55 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCHv3 4/4] openvz: add quota argument when creating container

2012-05-23 Thread Guido Günther
--- src/openvz/openvz_driver.c | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c6d25d7..fb72cde 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c

Re: [libvirt] [PATCHv3 4/4] openvz: add quota argument when creating container

2012-05-24 Thread Guido Günther
On Wed, May 23, 2012 at 01:58:30PM -0600, Eric Blake wrote: On 05/23/2012 09:10 AM, Guido Günther wrote: --- src/openvz/openvz_driver.c | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/src/openvz/openvz_driver.c b/src

Re: [libvirt] [PATCHv3 2/4] Introduce filesystem limits to virDomainFSDef

2012-05-24 Thread Guido Günther
On Wed, May 23, 2012 at 01:53:53PM -0600, Eric Blake wrote: On 05/23/2012 09:10 AM, Guido Günther wrote: --- docs/formatdomain.html.in | 14 ++ docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 30 +++--- src

[libvirt] [PATCH 0/3] openvz: allow for runtime quota updates

2012-06-03 Thread Guido Günther
persistent) diverging values due to openvz calls without the --save option but that's part of another patch. Cheers, -- Guido Guido Günther (3): Introduce virDomainFSIndexByName openvz: add persist parameter to openvzSetDiskQuota openvz: wire up domainUpdateDeviceFlags src/conf

[libvirt] [PATCH 3/3] openvz: wire up domainUpdateDeviceFlags

2012-06-03 Thread Guido Günther
so we can update file system quota --- src/openvz/openvz_driver.c | 95 1 file changed, 95 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 02a0133..8a1fb9a 100644 --- a/src/openvz/openvz_driver.c +++

[libvirt] [PATCH 2/3] openvz: add persist parameter to openvzSetDiskQuota

2012-06-03 Thread Guido Günther
with persist=false the domain config file will not be updated. --- src/openvz/openvz_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index fb72cde..02a0133 100644 --- a/src/openvz/openvz_driver.c +++

[libvirt] [PATCH] Only check for cluster fs if we're using a filesystem

2012-06-08 Thread Guido Günther
otherwise migration fails for e.g. network filesystems like sheepdog with: error: Invalid relative path 'virt-name': Invalid argument while we should fail with: Migration may lead to data corruption if disks use cache != none References:

[libvirt] [PATCH] msg_buf_size is unsigned long not size_t

2012-06-09 Thread Guido Günther
This fixes the build on 32bit systems which otherwise fails with: virnetmessagetest.c: In function 'testMessageHeaderEncode': virnetmessagetest.c:75:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type 'long unsigned int' [-Werror=format] --- Probably o.k. to push

Re: [libvirt] [PATCH] Only check for cluster fs if we're using a filesystem

2012-06-09 Thread Guido Günther
On Fri, Jun 08, 2012 at 03:34:41PM +0100, Daniel P. Berrange wrote: On Fri, Jun 08, 2012 at 02:19:08PM +0200, Guido Günther wrote: otherwise migration fails for e.g. network filesystems like sheepdog with: error: Invalid relative path 'virt-name': Invalid argument while we should

Re: [libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-10 Thread Guido Günther
On Thu, Jun 07, 2012 at 01:28:44PM -0600, Eric Blake wrote: Eric Blake and Guido Günther were guests during this week's FLOSS Weekly podcast, giving insights into libvirt as a Free Software project. * docs/relatedlinks.html.in: Add link. --- I'm not sure if I picked the best place on our

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-10 Thread Guido Günther
On Fri, Jun 08, 2012 at 11:13:53AM +0200, Michal Privoznik wrote: On 08.06.2012 11:02, Alex Jia wrote: On 06/08/2012 04:04 PM, Michal Privoznik wrote: This feature has been requested for a very long time. However, I'm very glad to see this patch :-) we had to wait for guest agent to

Re: [libvirt] [PATCH] msg_buf_size is unsigned long not size_t

2012-06-10 Thread Guido Günther
On Sat, Jun 09, 2012 at 07:07:01PM -0600, Eric Blake wrote: On 06/09/2012 01:12 PM, Guido Günther wrote: This fixes the build on 32bit systems which otherwise fails with: virnetmessagetest.c: In function 'testMessageHeaderEncode': virnetmessagetest.c:75:9: error: format '%zu' expects

Re: [libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-10 Thread Guido Günther
On Sat, Jun 09, 2012 at 09:31:54PM +0200, Guido Günther wrote: On Thu, Jun 07, 2012 at 01:28:44PM -0600, Eric Blake wrote: Eric Blake and Guido Günther were guests during this week's FLOSS Weekly podcast, giving insights into libvirt as a Free Software project. * docs

Re: [libvirt] [PATCHv2] docs: link to FLOSS Weekly podcast, virt blogs

2012-06-11 Thread Guido Günther
On Mon, Jun 11, 2012 at 09:14:58AM -0600, Eric Blake wrote: Eric Blake and Guido Günther were guests during this week's FLOSS Weekly podcast, giving insights into libvirt as a Free Software project. Also, there are several useful blogs on virt-related topics. * docs/relatedlinks.html.in

[libvirt] [PATCHv2 3/3] openvz: wire up domainUpdateDeviceFlags

2012-06-11 Thread Guido Günther
so we can update file system quota --- src/openvz/openvz_driver.c | 106 1 file changed, 106 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 02a0133..2014072 100644 --- a/src/openvz/openvz_driver.c +++

[libvirt] [PATCHv2 1/3] Introduce virDomainFSIndexByName

2012-06-11 Thread Guido Günther
for containers matching virDomainDiskIndexByName. --- src/conf/domain_conf.c | 16 src/conf/domain_conf.h |1 + src/libvirt_private.syms |1 + 3 files changed, 18 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index bd7b520..c34ce26

[libvirt] [PATCHv2 0/3] openvz: allow for runtime quota updates

2012-06-11 Thread Guido Günther
persistent) diverging values due to openvz calls without the --save option but that's part of another patch. Changes since last time: * add virDomainFSIndexByName to libvirt_private.syms * check for unallowed updates in openvzUpdateDevice Cheers, -- Guido Guido Günther (3

[libvirt] [PATCHv2 2/3] openvz: add persist parameter to openvzSetDiskQuota

2012-06-11 Thread Guido Günther
with persist=false the domain config file will not be updated. --- src/openvz/openvz_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index fb72cde..02a0133 100644 --- a/src/openvz/openvz_driver.c +++

Re: [libvirt] [PATCHv2 3/3] openvz: wire up domainUpdateDeviceFlags

2012-06-11 Thread Guido Günther
On Mon, Jun 11, 2012 at 10:57:07PM +0200, Guido Günther wrote: [..snip..] @@ -2002,6 +2107,7 @@ static virDriver openvzDriver = { .domainIsPersistent = openvzDomainIsPersistent, /* 0.7.3 */ .domainIsUpdated = openvzDomainIsUpdated, /* 0.8.6 */ .isAlive = openvzIsAlive, /* 0.9.8

Re: [libvirt] [PATCHv2 0/3] openvz: allow for runtime quota updates

2012-06-12 Thread Guido Günther
On Tue, Jun 12, 2012 at 11:22:58AM +0200, Michal Privoznik wrote: On 11.06.2012 22:57, Guido Günther wrote: Hi, attached patches allow to change disk quota at runtime. This can later be extended to update network configuration as well. The patch revealed a problem of the openvz driver

[libvirt] [PATCH] openvz: Fix wordsize on 64 bit architectures

2012-06-17 Thread Guido Günther
The word size there is 64 bit not 8. --- Came across this while browsing the source. O.k. to apply? -- Guido src/openvz/openvz_conf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index ad4ed74..007f9fe 100644 ---

Re: [libvirt] [PATCH] openvz: Fix wordsize on 64 bit architectures

2012-06-18 Thread Guido Günther
On Mon, Jun 18, 2012 at 08:25:32AM +0200, Michal Privoznik wrote: On 17.06.2012 19:18, Guido Günther wrote: The word size there is 64 bit not 8. --- Came across this while browsing the source. O.k. to apply? -- Guido src/openvz/openvz_conf.c |2 +- 1 file changed, 1 insertion

[libvirt] [PATCH] Don't install systemd service files executable

2012-06-26 Thread Guido Günther
since they aren't. Detected by Debian's lintian. --- daemon/Makefile.am |2 +- tools/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index fbb0ae1..473fa98 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am

[libvirt] [PATCHv2] Don't install systemd service files executable

2012-06-26 Thread Guido Günther
since they aren't. Detected by Debian's lintian. --- Changes since last version: use INSTALL_DATA instead of -m0644 daemon/Makefile.am |2 +- tools/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index

[libvirt] [PATCH] Add /tools/libvirt-guests.service to .gitignore

2012-06-26 Thread Guido Günther
since it's an autogenerated file --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index cd978d2..e5d5db9 100644 --- a/.gitignore +++ b/.gitignore @@ -160,6 +160,7 @@ /tests/xmconfigtest /tools/*.[18] /tools/libvirt-guests.init

Re: [libvirt] [PATCHv2] Don't install systemd service files executable

2012-06-26 Thread Guido Günther
On Tue, Jun 26, 2012 at 02:40:09PM +0100, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 03:34:47PM +0200, Guido Günther wrote: since they aren't. Detected by Debian's lintian. --- Changes since last version: use INSTALL_DATA instead of -m0644 daemon/Makefile.am |2 +- tools

Re: [libvirt] [PATCH] Add /tools/libvirt-guests.service to .gitignore

2012-06-26 Thread Guido Günther
On Tue, Jun 26, 2012 at 05:29:33PM +0100, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 06:15:31PM +0200, Guido Günther wrote: since it's an autogenerated file --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index cd978d2..e5d5db9

[libvirt] Libvirt on Ohloh

2012-06-26 Thread Guido Günther
Hi, I just noticed that ohloh tracks both libvirt-glib and libvirt under libvirt: https://www.ohloh.net/p/libvirt/enlistments Any objections to removing libvirt-glib from there (it's a separate project on ohloh as well). Cheers, -- Guido -- libvir-list mailing list

Re: [libvirt] Libvirt on Ohloh

2012-06-26 Thread Guido Günther
On Tue, Jun 26, 2012 at 09:44:33PM +0100, Daniel P. Berrange wrote: On Tue, Jun 26, 2012 at 09:53:42PM +0200, Guido Günther wrote: Hi, I just noticed that ohloh tracks both libvirt-glib and libvirt under libvirt: https://www.ohloh.net/p/libvirt/enlistments Any objections

Re: [libvirt] Entering freeze for libvirt-0.9.13

2012-06-29 Thread Guido Günther
On Mon, Jun 25, 2012 at 07:20:59PM +0800, Daniel Veillard wrote: I just tagged the git tree and I pushed the tarball for rc1: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz the rpms I build are coming along soon. Please give it a try, the basic seems okay to me (kvm driver seems

Re: [libvirt] [PATCH] build: use correct limit for unsigned long long

2012-06-30 Thread Guido Günther
On Fri, Jun 29, 2012 at 03:11:41PM -0600, Eric Blake wrote: Reported by Jason Helfman as a build-breaker on FreeBSD. * src/conf/domain_conf.c (virDomainFSDefParseXML): Use POSIX spelling. * src/openvz/openvz_conf.c (openvzReadFSConf): Likewise. --- Pushing under the build-breaker rule.

[libvirt] [PATCH] openvz: Handle domain obj hash map errors

2012-07-09 Thread Guido Günther
This makes the driver fail with a clear error message in case of uuid collisions (for example if somebody copied a container configuration without updating the UUID). OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is only used by libvirt. --- src/openvz/openvz_conf.c |

[libvirt] [PATCHv2] openvz: Handle domain obj hash map errors

2012-07-10 Thread Guido Günther
This makes the driver fail with a clear error message in case of UUID collisions (for example if somebody copied a container configuration without updating the UUID) and also raises an error on other hash map failures. OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is

[libvirt] [PATCH 1/5] Add virGetHostname

2012-07-10 Thread Guido Günther
to query a guests's hostname. Containers like LXC and OpenVZ allow to set a hostname different from the hosts name and QEMU's guest agent could provide similar functionality. --- include/libvirt/libvirt.h.in |2 ++ src/driver.h |6 ++ src/libvirt.c|

[libvirt] [PATCH 5/5] virsh: allow to print hostname in domain listings

2012-07-10 Thread Guido Günther
--- tools/virsh.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 591a1ce..2c0446c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1292,6 +1292,7 @@ static const vshCmdOptDef opts_list[] = { {managed-save,

[libvirt] [PATCH 2/5] virsh: Add domhostname

2012-07-10 Thread Guido Günther
to query the guest's hostname. --- tools/virsh.c | 44 tools/virsh.pod |4 2 files changed, 48 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index 85b1185..591a1ce 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -14131,6

[libvirt] [PATCH 3/5] openvz: Add openvzVEGetStringParam

2012-07-10 Thread Guido Günther
to retrieve a VEs config parameters as a single string. This will be used by the upcoming domainGetHostname implementation. --- src/libvirt_openvz.syms |2 +- src/openvz/openvz_util.c | 31 +++ src/openvz/openvz_util.h |1 + 3 files changed, 33

[libvirt] [PATCH 0/5] Allow to query a guest's hostname

2012-07-10 Thread Guido Günther
The following patches allow to query a guest's hostname. The last patch might be debatable since it adds yet another option to virsh list but I hope the rest of the serious looks sane. Cheers, -- Guido Guido Günther (5): Add virGetHostname virsh: Add domhostname openvz: Add

[libvirt] [PATCH 4/5] openvz: Implement domainGetHostname

2012-07-10 Thread Guido Günther
If the container doesn't have the hostname parameter set an empty string () is returned. --- src/openvz/openvz_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c9150e0..469d043 100644 ---

[libvirt] [PATCH] virsh: remove extra space between function name and opening brace

2012-07-11 Thread Guido Günther
to match our CodingStyle. --- This avoids c'n'p problems as seen in my recent domhostname patch. Cheers, -- Guido tools/virsh.c | 186 - 1 file changed, 93 insertions(+), 93 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index

<    1   2   3   4   5   6   7   8   9   10   >