Re: [libvirt] [PATCH] Add support for RAM filesystems for LXC

On Wed, Jun 20, 2012 at 02:41:20PM +0100, Daniel P. Berrange wrote: > On Fri, May 11, 2012 at 11:16:42PM +0200, Guido Günther wrote: > > On Wed, May 09, 2012 at 10:00:47AM -0600, Eric Blake wrote: > > > On 05/09/2012 09:49 AM, Daniel P. Berrange wrote: > > >

[libvirt] [PATCH] Don't install systemd service files executable

since they aren't. Detected by Debian's lintian. --- daemon/Makefile.am |2 +- tools/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index fbb0ae1..473fa98 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@

[libvirt] [PATCHv2] Don't install systemd service files executable

since they aren't. Detected by Debian's lintian. --- Changes since last version: use INSTALL_DATA instead of -m0644 daemon/Makefile.am |2 +- tools/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index fbb0ae1..71e

[libvirt] [PATCH] Add /tools/libvirt-guests.service to .gitignore

since it's an autogenerated file --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index cd978d2..e5d5db9 100644 --- a/.gitignore +++ b/.gitignore @@ -160,6 +160,7 @@ /tests/xmconfigtest /tools/*.[18] /tools/libvirt-guests.init +/tools/libvirt-guests.

Re: [libvirt] [PATCHv2] Don't install systemd service files executable

On Tue, Jun 26, 2012 at 02:40:09PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 26, 2012 at 03:34:47PM +0200, Guido Günther wrote: > > since they aren't. Detected by Debian's lintian. > > --- > > Changes since last version: use INSTALL_DATA instead of -m0644 >

Re: [libvirt] [PATCH] Add /tools/libvirt-guests.service to .gitignore

On Tue, Jun 26, 2012 at 05:29:33PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 26, 2012 at 06:15:31PM +0200, Guido Günther wrote: > > since it's an autogenerated file > > --- > > .gitignore |1 + > > 1 file changed, 1 insertion(+) > > > > di

[libvirt] Libvirt on Ohloh

Hi, I just noticed that ohloh tracks both libvirt-glib and libvirt under libvirt: https://www.ohloh.net/p/libvirt/enlistments Any objections to removing libvirt-glib from there (it's a separate project on ohloh as well). Cheers, -- Guido -- libvir-list mailing list libvir-list@redhat.co

Re: [libvirt] Libvirt on Ohloh

On Tue, Jun 26, 2012 at 09:44:33PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 26, 2012 at 09:53:42PM +0200, Guido Günther wrote: > > Hi, > > I just noticed that ohloh tracks both libvirt-glib and libvirt under > > libvirt: > > > > https://www.ohloh.net/p

Re: [libvirt] Entering freeze for libvirt-0.9.13

On Mon, Jun 25, 2012 at 07:20:59PM +0800, Daniel Veillard wrote: > I just tagged the git tree and I pushed the tarball for rc1: > ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz > > the rpms I build are coming along soon. > Please give it a try, the basic seems okay to me (kvm driver s

Re: [libvirt] [PATCH] build: use correct limit for unsigned long long

On Fri, Jun 29, 2012 at 03:11:41PM -0600, Eric Blake wrote: > Reported by Jason Helfman as a build-breaker on FreeBSD. > > * src/conf/domain_conf.c (virDomainFSDefParseXML): Use POSIX > spelling. > * src/openvz/openvz_conf.c (openvzReadFSConf): Likewise. > --- > > Pushing under the build-breaker

[libvirt] [PATCH] openvz: Handle domain obj hash map errors

This makes the driver fail with a clear error message in case of uuid collisions (for example if somebody copied a container configuration without updating the UUID). OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is only used by libvirt. --- src/openvz/openvz_conf.c |

[libvirt] [PATCHv2] openvz: Handle domain obj hash map errors

This makes the driver fail with a clear error message in case of UUID collisions (for example if somebody copied a container configuration without updating the UUID) and also raises an error on other hash map failures. OpenVZ itself doesn't complain about duplicate UUIDs since this parameter is on

[libvirt] [PATCH 1/5] Add virGetHostname

to query a guests's hostname. Containers like LXC and OpenVZ allow to set a hostname different from the hosts name and QEMU's guest agent could provide similar functionality. --- include/libvirt/libvirt.h.in |2 ++ src/driver.h |6 ++ src/libvirt.c| 42

[libvirt] [PATCH 5/5] virsh: allow to print hostname in domain listings

--- tools/virsh.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 591a1ce..2c0446c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1292,6 +1292,7 @@ static const vshCmdOptDef opts_list[] = { {"managed-save", VSH_O

[libvirt] [PATCH 2/5] virsh: Add domhostname

to query the guest's hostname. --- tools/virsh.c | 44 tools/virsh.pod |4 2 files changed, 48 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index 85b1185..591a1ce 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -14131,6 +1413

[libvirt] [PATCH 3/5] openvz: Add openvzVEGetStringParam

to retrieve a VEs config parameters as a single string. This will be used by the upcoming domainGetHostname implementation. --- src/libvirt_openvz.syms |2 +- src/openvz/openvz_util.c | 31 +++ src/openvz/openvz_util.h |1 + 3 files changed, 33 insertions(+),

[libvirt] [PATCH 0/5] Allow to query a guest's hostname

The following patches allow to query a guest's hostname. The last patch might be debatable since it adds yet another option to virsh list but I hope the rest of the serious looks sane. Cheers, -- Guido Guido Günther (5): Add virGetHostname virsh: Add domhostname openvz

[libvirt] [PATCH 4/5] openvz: Implement domainGetHostname

If the container doesn't have the hostname parameter set an empty string ("") is returned. --- src/openvz/openvz_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c9150e0..469d043 100644 --- a/

[libvirt] [PATCH] virsh: remove extra space between function name and opening brace

to match our CodingStyle. --- This avoids c'n'p problems as seen in my recent domhostname patch. Cheers, -- Guido tools/virsh.c | 186 - 1 file changed, 93 insertions(+), 93 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2c

Re: [libvirt] [PATCHv2] openvz: Handle domain obj hash map errors

On Tue, Jul 10, 2012 at 05:31:27PM -0600, Eric Blake wrote: > On 07/10/2012 12:54 PM, Guido Günther wrote: > > This makes the driver fail with a clear error message in case of UUID > > collisions (for example if somebody copied a container configuration > > without updati

Re: [libvirt] [PATCH] virsh: remove extra space between function name and opening brace

On Wed, Jul 11, 2012 at 11:11:46AM +0200, Peter Krempa wrote: > On 07/11/12 10:39, Guido Günther wrote: > >to match our CodingStyle. > >--- > >This avoids c'n'p problems as seen in my recent domhostname patch. > >Cheers, > &

Re: [libvirt] [PATCH 5/5] virsh: allow to print hostname in domain listings

On Tue, Jul 10, 2012 at 03:18:19PM -0600, Eric Blake wrote: > On 07/10/2012 02:46 PM, Guido Günther wrote: > > --- > > tools/virsh.c | 18 +- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/tools/virsh.c b/tools/virsh.c

[libvirt] [PATCHv2 4/5] openvz: Add openvzVEGetStringParam

to retrieve a VEs config parameters as a single string. This will be used by the upcoming domainGetHostname implementation. --- src/libvirt_openvz.syms |2 +- src/openvz/openvz_util.c | 32 src/openvz/openvz_util.h |1 + 3 files changed, 34 insertions(+)

[libvirt] [PATCHv2 2/5] virsh: Add domhostname

to query the guest's hostname. --- tools/virsh.c | 44 tools/virsh.pod |4 2 files changed, 48 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index f9fe4b1..7c20202 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -14133,6 +1413

[libvirt] [PATCHv2 3/5] remote: Provide RPC call for domainGetHostname

--- src/remote/remote_driver.c |1 + src/remote/remote_protocol.x | 12 +++- src/remote_protocol-structs |8 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 3314f80..5d1ce4d 100644 --- a/src/

[libvirt] [PATCHv2 5/5] openvz: Implement domainGetHostname

--- src/openvz/openvz_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c9150e0..6046a60 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -234,6 +234,47

[libvirt] [PATCHv2 0/5] Allow to query a guest's hostname

* Don't return empty hostnames but raise VIR_ERR_OPERATION_FAILED instead Cheers, -- Guido Guido Günther (5): Add virDomainGetHostname virsh: Add domhostname remote: Provide RPC call for domainGetHostname openvz: Add openvzVEGetStringParam openvz: Implement domainGetHostname include

[libvirt] [PATCHv2 1/5] Add virDomainGetHostname

to query a guests's hostname. Containers like LXC and OpenVZ allow to set a hostname different from the hosts name and QEMU's guest agent could provide similar functionality. --- include/libvirt/libvirt.h.in |2 ++ src/driver.h |6 ++ src/libvirt.c| 45

Re: [libvirt] New application

On Mon, Jul 16, 2012 at 12:17:49PM +0200, Maciej Nabożny wrote: > Hello, > I'm developer of CC1 project in Institute of Nuclear Physics in > Cracow. We are creating cloud computing system based on Libvirt. Is > it possible to add link to our project at yours website in > applications section? > >

Re: [libvirt] [PATCH 2/2] apparmor: Improve profiles

On Mon, Jan 27, 2014 at 11:49:45AM -0600, Jamie Strandboge wrote: > On 01/26/2014 03:47 PM, Felix Geyer wrote: > > Tested on Debian unstable. > > The profile updates are partly taken from the Ubuntu trusty libvirt package. > > Thanks for these updates! :) Comments inline. > > > --- > > examples/

Re: [libvirt] [libvirt-java] [PATCH 01/65] Fix warnings about using raw types

Hi, On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote: > Eclipse generates this kind of warning: > > org/libvirt/jna/virConnectCredential.java:20: > List is a raw type. References to generic type List should be parameterized > > Signed-off-by: Claudio Bley > --- > src/main/java/org/

Re: [libvirt] [libvirt-java] [PATCH 05/65] test: ensure that exceptions are thrown when expected

On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/test/java/org/libvirt/TestJavaBindings.java |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/test/java/org/libvirt/TestJavaBindings.java > b/src/test/java/org/libvirt/Test

Re: [libvirt] [libvirt-java] [PATCH 03/65] Fix typos in Error.java

On Thu, Feb 13, 2014 at 04:22:11PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Error.java |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/main/java/org/libvirt/Error.java > b/src/main/java/org/libvirt/Error.

Re: [libvirt] [libvirt-java] [PATCH 06/65] Make comments proper javadoc comments for enum constants

On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Error.java | 397 > ++ > 1 file changed, 262 insertions(+), 135 deletions(-) > > diff --git a/src/main/java/org/libvirt/Error.java >

Re: [libvirt] [libvirt-java] [PATCH 07/65] Ignore editor backup files

On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > .gitignore |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.gitignore b/.gitignore > index b02fd55..28ddc6e 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,3 +1,5 @@ > +*~ >

Re: [libvirt] [libvirt-java] [PATCH 02/65] Fix warnings about accessing static methods

On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote: > java/org/libvirt/Error.java:217: > The static method wrap(int) from the type Error.ErrorDomain should be > accessed in a static way > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Error.java |6 +++--- > 1 file

Re: [libvirt] [PATCH 3/4] Cache result of QEMU capabilities extraction

Hi Daniel, On Wed, Mar 05, 2014 at 05:53:53PM +, Daniel P. Berrange wrote: [..snip..] > +/* Discard if cache is older that QEMU binary */ > +/* XXX must also compare to libvirtd timestamp */ > +if (sb.st_mtime < qemuCaps->mtime) { I think looking at the mtime isn't sufficent here.

Re: [libvirt] [PATCH] virt-aa-helper: handle 9pfs

Hi, On Sun, Mar 09, 2014 at 04:03:20PM +0100, Felix Geyer wrote: > Make virt-aa-helper create rules to allow VMs access to filesystem > mounts from the host. > > Signed-off-by: Felix Geyer > Signed-off-by: Hiroshi Miura > Signed-off-by: Serge Hallyn > --- > src/security/virt-aa-helper.c | 32 +

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: > A bunch of tests currently attempt to kickstart a full Fedora > OS image install. Everytime I try to update this kickstart to > a new version of Fedora it causes no end of pain. Switch the > tests over to use Richard Jones' virt-

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

Hi Daniel, On Fri, Mar 28, 2014 at 02:48:41PM +, Daniel P. Berrange wrote: > On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote: > > On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: > > > A bunch of tests currently attempt to kickstart a full Fed

[libvirt] [PATCH 3/3] tests: link agains libxml2

to avoid CCLD storagevolxml2argvtest /usr/bin/ld: ../src/.libs/libvirt_driver_storage_impl.a(libvirt_driver_storage_impl_la-storage_backend.o): undefined reference to symbol 'xmlFreeDoc@@LIBXML2_2.4.30' //usr/lib/x86_64-linux-gnu/libxml2.so.2: error adding symbols: DSO missing from command

[libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists

When building packages in a clean chroot the QEMU_USER and QEMU_GROUP don't exist making VirQemuDriverConfigNew fail with privileged=true. Avoid that by not requiring priviliged mode and skipping tests that need it. --- tests/qemuxml2argvtest.c | 24 1 file changed, 16 in

[libvirt] [PATCH 1/3] tests: Don't crash when creating the config object fails

As observed when building in a chroot and QEMU_USER doesn't exist --- tests/qemuargv2xmltest.c | 3 +++ tests/qemuxml2argvtest.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index 6d7e23e..4cc3749 100644 --- a/tests/qemuargv2xmltest.c

[libvirt] [PATCH] libvirt-guests: avoid bashism

At least Debian uses dash to run the init scripts --- tools/libvirt-guests.sh.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 4bbd4e4..a158b62 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.

Re: [libvirt] [PATCH] libvirt-guests: avoid bashism

On Mon, Apr 07, 2014 at 11:25:07AM +0200, Peter Krempa wrote: > On 04/07/14 11:20, Guido Günther wrote: > > At least Debian uses dash to run the init scripts > > --- > > tools/libvirt-guests.sh.in | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [libvirt] [PATCH 1/3] tests: Don't crash when creating the config object fails

On Mon, Apr 07, 2014 at 04:34:57PM -0600, Eric Blake wrote: > On 04/07/2014 02:02 AM, Guido Günther wrote: > > As observed when building in a chroot and QEMU_USER doesn't exist > > --- > > tests/qemuargv2xmltest.c | 3 +++ > > tests/qemuxml2argvtest.c | 3 +++ &g

Re: [libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists

On Tue, Apr 08, 2014 at 10:09:59AM +0100, Daniel P. Berrange wrote: > On Mon, Apr 07, 2014 at 04:40:24PM -0600, Eric Blake wrote: > > On 04/07/2014 02:02 AM, Guido Günther wrote: > > > When building packages in a clean chroot the QEMU_USER and QEMU_GROUP > &

Re: [libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists

On Tue, Apr 08, 2014 at 03:03:55PM +0200, Martin Kletzander wrote: > On Tue, Apr 08, 2014 at 12:52:36PM +0100, Daniel P. Berrange wrote: > >On Tue, Apr 08, 2014 at 01:47:14PM +0200, Martin Kletzander wrote: > >>On Tue, Apr 08, 2014 at 12:49:25PM +0200, Guido Günther wrote: &

Re: [libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists

On Tue, Apr 08, 2014 at 07:27:06AM -0600, Eric Blake wrote: > On 04/08/2014 07:06 AM, Guido Günther wrote: > > >>> What about passing 'false' to ConfigNew() but then manually > >>> set 'cfg->privileged = true' on the object we get back. >

Re: [libvirt] [PATCH 05/10] apparmor, virt-aa-helper: Explicit denies for host devices

On Mon, May 15, 2017 at 03:23:14PM +0200, Stefan Bader wrote: > From: Felix Geyer > > Add explicit denies for disk devices to avoid cluttering dmesg with > (acceptable) denials. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/usr.lib.libvirt.virt-

Re: [libvirt] [PATCH 04/10] apparmor, virt-aa-helper: Allow access to libnl-3 config files

On Mon, May 15, 2017 at 03:23:13PM +0200, Stefan Bader wrote: > From: Felix Geyer > > Allow access to libnl-3 config files > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

On Mon, May 15, 2017 at 03:23:10PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Just because a disk element only requests read access doesn't mean > there may not be another readwrite request. > > Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bugs/1554031 The URL is wrong (drop the "ubun

Re: [libvirt] [PATCH 06/10] apparmor, virt-aa-helper: Additional explicit denies for host devices

On Mon, May 15, 2017 at 03:23:15PM +0200, Stefan Bader wrote: > From: Christian Ehrhardt > > This adds further explicit denies for host devices to silence > (acceptable) denial warnings. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/usr.lib.libv

Re: [libvirt] [PATCH 02/10] apparmor, virt-aa-helper: allow /usr/share/OVMF/ too

On Mon, May 15, 2017 at 03:23:11PM +0200, Stefan Bader wrote: > From: Simon McVittie > > The split firmware and variables files introduced by > https://bugs.debian.org/764918 are in a different directory for some reason. > Let the virtual machine read both. > > Extended by Christian Ehrhardt to

Re: [libvirt] [PATCH 08/10] apparmor: provide local override templates

On Mon, May 15, 2017 at 03:23:17PM +0200, Stefan Bader wrote: > Local overrides is a feature Debian/Ubuntu libvirt provided for a while. > This allows the user to have a non-conffile that he can use to extend the > package delivered rules with extra content matching his special case. > > This chan

Re: [libvirt] [PATCH 03/10] apparmor, virt-aa-helper: Allow aarch64 UEFI.

On Mon, May 15, 2017 at 03:23:12PM +0200, Stefan Bader wrote: > From: William Grant > > Allow access to aarch64 UEFI images. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/libvirt-qemu | 2 ++ > src/security/virt-aa-helper.c | 4 +++- > tests/vi

Re: [libvirt] [PATCH 09/10] appmor, virt-aa-helper: Add 9p support

On Mon, May 15, 2017 at 03:23:18PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Add fowner and fsetid to libvirt-qemu profile and add link > to 9p file options in virt-aa-helper. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1378434 > > Signed-off-by: Christian Ehrhardt > Signed-off-b

Re: [libvirt] [PATCH 7/8] appmor, libvirt-qemu: Add 9p support

On Thu, May 18, 2017 at 11:21:54AM -0500, Serge E. Hallyn wrote: > Mind you I'm not crazy about this. If this could be toggled with a > default-off config option that would seem better than always giving > these caps to libvirt-qemu. virt-aa-helper could add these if it detects a 9pfs file system

Re: [libvirt] [PATCH 2/8] apparmor, virt-aa-helper: allow /usr/share/OVMF/ too

other one (attributed to Simon). Cheers, -- Guido > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > Acked-by: Guido Günther > --- > examples/apparmor/libvirt-qemu | 1 + > src/security/virt-aa-helper.c | 1 + > tests/virt-aa-helper-test | 24

Re: [libvirt] [PATCH 4/8] apparmor, virt-aa-helper: Allow access to libnl-3 config files

On Thu, May 18, 2017 at 10:53:42AM +0200, Stefan Bader wrote: > From: Felix Geyer > > Allow access to libnl-3 config files > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > Acked-by: Guido Günther > --- > examples/apparmor/usr.lib.libvirt.virt

Re: [libvirt] [PATCH 5/8] apparmor, virt-aa-helper: Explicit denies for host devices

hrhardt > Signed-off-by: Stefan Bader > Acked-by: Guido Günther > --- > examples/apparmor/usr.lib.libvirt.virt-aa-helper | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper > b/examples/apparmor/usr.lib.li

Re: [libvirt] [PATCH 8/8] apparmor, libvirt-qemu: Add ppc64el related changes

On Thu, May 18, 2017 at 10:53:46AM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Updates profile to allow running on ppc64el. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1374554 > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/libvirt-qe

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

On Mon, May 15, 2017 at 06:07:12PM +0200, Stefan Bader wrote: > On 15.05.2017 17:48, Guido Günther wrote: > > On Mon, May 15, 2017 at 03:23:10PM +0200, Stefan Bader wrote: > >> From: Serge Hallyn > >> > >> Just because a disk element only requests read acces

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

Hi Christian, On Fri, May 19, 2017 at 11:18:18AM +0200, Christian Ehrhardt wrote: > On Fri, May 19, 2017 at 10:03 AM, Guido Günther wrote: > > > But if we aim for a profile replace on blockcommit [1] the would't matter > > since the whole profile would get replaced, woul

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

On Fri, May 19, 2017 at 11:18:18AM +0200, Christian Ehrhardt wrote: > On Fri, May 19, 2017 at 10:03 AM, Guido Günther wrote: > > > But if we aim for a profile replace on blockcommit [1] the would't matter > > since the whole profile would get replaced, wouldn't it?

[libvirt] [libvirt-sandbox PATCH] mkinitrd: Add missing fscrypto module

--- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-sandbox/libvirt-sandbox-builder-machine.c b/libvirt-sandbox/libvirt-sandbox-builder-machine.c index bdec490..7204f71 100644 --- a/libvirt-sandbox/libvirt-sandbox-builder-machine.c +++

[libvirt] [libvirt-sandbox PATCH] Drop library/ from template name and image path

If one pastes from the output of virt-sansbox-image $ virt-sandbox-image list docker:/library/ubuntu?tag=17.04 docker:/library/debian?tag=latest verbatim $ virt-sandbox-image run -c qemu:///session docker:/library/debian?tag=latest This fails like /home//.local/share/libvirt/images/l

[libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors

--- libvirt-sandbox/image/sources/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/image/sources/docker.py b/libvirt-sandbox/image/sources/docker.py index 43e9c32..aa5675e 100755 --- a/libvirt-sandbox/image/sources/docker.py +++ b/libvirt-sandbox/image

Re: [libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors

On Mon, May 29, 2017 at 11:43:53AM +0200, Cedric Bosdonnat wrote: > On Sat, 2017-05-27 at 18:30 +0200, Guido Günther wrote: > > --- > >  libvirt-sandbox/image/sources/docker.py | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libvir

Re: [libvirt] [libvirt-sandbox PATCH] mkinitrd: Add missing fscrypto module

On Mon, May 29, 2017 at 11:42:09AM +0200, Cedric Bosdonnat wrote: > On Sat, 2017-05-27 at 13:04 +0200, Guido Günther wrote: > > --- > >  libvirt-sandbox/libvirt-sandbox-builder-machine.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/libvir

Re: [libvirt] [PATCH 02/10] virt-aa-helper: Generalize test for firmware paths

On Tue, May 23, 2017 at 06:22:40PM +0200, Stefan Bader wrote: > From: Christian Ehrhardt > > This replaces individual tests for firmware locations by > a generic function which will simplify having additional > locations in the future. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stef

Re: [libvirt] [PATCH 01/10] virt-aa-helper, apparmor: allow /usr/share/OVMF/ too

On Tue, May 23, 2017 at 06:22:39PM +0200, Stefan Bader wrote: > From: Simon McVittie > > The split firmware and variables files introduced by > https://bugs.debian.org/764918 are in a different directory for > some reason. Let the virtual machine read both. > > Signed-off-by: Christian Ehrhardt

Re: [libvirt] [PATCH 08/10] apparmor, libvirt-qemu: Allow macvtap access

On Tue, May 23, 2017 at 06:22:46PM +0200, Stefan Bader wrote: > From: Guilhem Lettron > > Add rule to allow access to /dev/tap* used by macvtap. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/921870 > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmo

Re: [libvirt] [PATCH 07/10] apparmor, libvirt-qemu: Allow access to ceph config

On Tue, May 23, 2017 at 06:22:45PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/libvirt-qemu | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/apparmor/libvirt-qemu b/examples/a

Re: [libvirt] [PATCH 06/10] apparmor, libvirtd: Allow libxl-save-helper to run on Debian/Ubuntu

On Tue, May 23, 2017 at 06:22:44PM +0200, Stefan Bader wrote: > On Debian/Ubuntu the libxl-save-helper (used when saving/restoring > a domain through libxl) is located under /usr/lib/xen-/bin. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1334195 > > Signed-off-by: Christian Ehrhardt > Signed-

Re: [libvirt] [PATCH 10/10] apparmor, libvirt-qemu: Allow access to certificates used by libvirt-vnc

On Tue, May 23, 2017 at 06:22:48PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > When setting up VncTLS according to the official Libvirt documentation, > only one certificate for libvirt/libvirt-vnc is used. The document > indicates to use the following directories : > > /etc/pki/CA > /

Re: [libvirt] [PATCH 04/10] apparmor, libvirt-qemu: Add ppc64el related changes

On Tue, May 23, 2017 at 06:22:42PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Updates profile to allow running on ppc64el. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1374554 > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- > examples/apparmor/libvirt-qe

[libvirt] [libvirt-sandbox PATCH 2/2] Sanitize domain name

If one pastes from the output of virt-sansbox-image $ virt-sandbox-image list docker:/library/ubuntu?tag=17.04 docker:/library/debian?tag=latest verbatim $ virt-sandbox-image run -c qemu:///session docker:/library/debian?tag=latest This fails like Unable to start sandbox: Failed to c

[libvirt] [libvirt-sandbox PATCH 1/2] Drop library/ from image path

If one pastes from the output of virt-sansbox-image $ virt-sandbox-image list docker:/library/ubuntu?tag=17.04 docker:/library/debian?tag=latest verbatim $ virt-sandbox-image run -c qemu:///session docker:/library/debian?tag=latest This fails like /home//.local/share/libvirt/images/l

[libvirt] [libvirt-sandbox PATCH 0/2] virt-sandbox-image: unbreak start from library

This is basically a V2 of "Drop library/ from template name and image path" with Dan's comment implemented. Guido Günther (2): Drop library/ from image path Sanitize domain name libvirt-sandbox/image/cli.py| 8 ++-- libvirt-sandbox/image/sources/docker.py

Re: [libvirt] [PATCH 07/10] apparmor, libvirt-qemu: Allow access to ceph config

On Wed, Jun 07, 2017 at 10:44:59AM -0600, Christian Ehrhardt wrote: > On Fri, Jun 2, 2017 at 12:57 PM, Guido Günther wrote: > > > Shouldn't this only be added when ceph is in use? > > Cheers, > > -- Guido > > > > Yeah it is part of a category of rules

Re: [libvirt] [PATCH 04/10] apparmor, libvirt-qemu: Add ppc64el related changes

On Sun, Jun 04, 2017 at 04:41:58PM +0200, Guido Günther wrote: > On Tue, May 23, 2017 at 06:22:42PM +0200, Stefan Bader wrote: > > From: Serge Hallyn > > > > Updates profile to allow running on ppc64el. > > > > Bug-Ubuntu: https://bugs.launchpad.net/bu

Re: [libvirt] [PATCH 01/10] virt-aa-helper, apparmor: allow /usr/share/OVMF/ too

On Fri, Jun 02, 2017 at 08:46:26PM +0200, Guido Günther wrote: > On Tue, May 23, 2017 at 06:22:39PM +0200, Stefan Bader wrote: > > From: Simon McVittie > > > > The split firmware and variables files introduced by > > https://bugs.debian.org/764918 are in a different di

Re: [libvirt] [PATCH 10/10] apparmor, libvirt-qemu: Allow access to certificates used by libvirt-vnc

On Fri, Jun 02, 2017 at 09:01:49PM +0200, Guido Günther wrote: > On Tue, May 23, 2017 at 06:22:48PM +0200, Stefan Bader wrote: > > From: Serge Hallyn > > > > When setting up VncTLS according to the official Libvirt documentation, > > only one certificate for libvi

Re: [libvirt] [PATCH 06/10] apparmor, libvirtd: Allow libxl-save-helper to run on Debian/Ubuntu

On Fri, Jun 02, 2017 at 08:58:57PM +0200, Guido Günther wrote: > On Tue, May 23, 2017 at 06:22:44PM +0200, Stefan Bader wrote: > > On Debian/Ubuntu the libxl-save-helper (used when saving/restoring > > a domain through libxl) is located under /usr/lib/xen-/bin. > >

Re: [libvirt] [PATCH 02/10] virt-aa-helper: Generalize test for firmware paths

On Fri, Jun 02, 2017 at 08:46:42PM +0200, Guido Günther wrote: > On Tue, May 23, 2017 at 06:22:40PM +0200, Stefan Bader wrote: > > From: Christian Ehrhardt > > > > This replaces individual tests for firmware locations by > > a generic function which will simplify havi

Re: [libvirt] [PATCH 07/10] apparmor, libvirt-qemu: Allow access to ceph config

On Wed, Jun 07, 2017 at 07:00:56PM +0200, Guido Günther wrote: > On Wed, Jun 07, 2017 at 10:44:59AM -0600, Christian Ehrhardt wrote: > > On Fri, Jun 2, 2017 at 12:57 PM, Guido Günther wrote: > > > > > Shouldn't this only be added when ceph is in use?

Re: [libvirt] [PATCH 03/10] apparmor, virt-aa-helper: Allow aarch64 UEFI.

On Tue, May 23, 2017 at 06:22:41PM +0200, Stefan Bader wrote: > From: William Grant > > Allow access to aarch64 UEFI images. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > Acked-by: Guido Günther Pushed. Thanks. -- Guido > --- > example

Re: [libvirt] [libvirt-sandbox PATCH 0/2] virt-sandbox-image: unbreak start from library

On Wed, Jun 07, 2017 at 08:02:03AM +0200, Guido Günther wrote: > This is basically a V2 of "Drop library/ from template name and image path" > with Dan's comment implemented. Ping? -- Guido > > Guido Günther (2): > Drop library/ from image path > Sanitize

Re: [libvirt] Entering freeze for libvirt-3.5.0

On Mon, Jul 03, 2017 at 10:49:46AM +0200, Ján Tomko wrote: > [cc: Guido] > > On Sat, Jul 01, 2017 at 02:18:58PM +0400, Roman Bogorodskiy wrote: > > Andrea Bolognani wrote: > > > virnetsockettest also fails pretty often for me, certainly > > > more than your figure; even if that wasn't the case, 1

Re: [libvirt] Entering freeze for libvirt-3.5.0

On Tue, Jul 04, 2017 at 12:27:19PM +0200, Andrea Bolognani wrote: > On Mon, 2017-07-03 at 18:47 +0200, Guido Günther wrote: > > > > Anyway, I'll try to find a way to debug what's going on with > > > > virnetsockettest. > > >  > > > IIRC Debian

[libvirt] [PATCH] virt-aa-helper: Make help output match option name

--- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index bdead57..49e12b9 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -107,7 +107,7 @@ vah_usage(vo

[libvirt] [PATCH 1/2] qemu: attempt to delete disk when SCSI attach failed

We have a qemuMonitorDriveDel now so use it --- src/qemu/qemu_hotplug.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e8a30d5..6232a0e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -678,1

[libvirt] [PATCH 0/2] Invoke drive_del on failute to attach disks

There is a drive_del in QEMU so we should use it. Guido Günther (2): qemu: attempt to delete disk when SCSI attach failed qemu: attempt to delete disk when USB mass storage attach failed src/qemu/qemu_hotplug.c | 24 1 file changed, 16 insertions(+), 8 deletions

[libvirt] [PATCH 2/2] qemu: attempt to delete disk when USB mass storage attach failed

We have a qemuMonitorDriveDel now so use it --- src/qemu/qemu_hotplug.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6232a0e..87c208b 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @

Re: [libvirt] [PATCH 1/2] qemu: attempt to delete disk when SCSI attach failed

On Fri, Jul 22, 2016 at 01:42:44PM +0200, Peter Krempa wrote: > On Fri, Jul 22, 2016 at 12:08:45 +0200, Guido Günther wrote: > > We have a qemuMonitorDriveDel now so use it > > --- > > src/qemu/qemu_hotplug.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletio

[libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

In contrast to libvirt itself all get_* methods need to prefetch the corresponding information first so document this. --- libvirt-gobject/libvirt-gobject-connection.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobje

Re: [libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

On Wed, Jul 27, 2016 at 10:27:17AM +0200, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau > > (I'm assuming you can push to libvirt-glib, let me know if that's not > the case). Pushed. Thanks! -- Guido > > Christophe > > On Wed, Jul 27, 20

Re: [libvirt] Drop support for old libvirt versions?

On Fri, Aug 12, 2016 at 06:25:16PM +0200, Andrea Bolognani wrote: > A while ago, we agreed to drop support for QEMU versions older > than 0.12.0, with the rationale that we should focus on > operating systems that are still supported by the respective > vendors, eg. RHEL/CentOS 6, Ubuntu 12.04 and

Re: [libvirt] problem with rbd auth after switch to secret objects

On Wed, Aug 10, 2016 at 04:01:11PM -0600, Jim Fehlig wrote: > Hi John, > > I've been having problems with rbd auth since the change to using qemu's > secret > objects. E.g. when hotplugging disk config > > > >name="volumes/volume-f9c33a0a-5313-44fc-9624-c3b09ed21a57"> > > > >

<    4   5   6   7   8   9   10   11   12   >