[libvirt PATCH 1/7] cputestdata: Add test data for Snowridge

Signed-off-by: Tim Wiederhake --- ...64-cpuid-Atom-P5362-processor-disabled.xml |8 + ..._64-cpuid-Atom-P5362-processor-enabled.xml | 10 + .../x86_64-cpuid-Atom-P5362-processor.json| 2415 + .../x86_64-cpuid-Atom-P5362-processor.xml | 61 + 4 files changed, 2494

[libvirt PATCH 2/7] cpu_map: Add support for fsrm CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1 + 3 files changed, 5 insertions(+) diff --git a/src/cpu_map

[libvirt PATCH 6/7] cputestdata: Snowridge: Update with split-lock-detect feature

Signed-off-by: Tim Wiederhake --- tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml b/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml index

[libvirt PATCH 4/7] cputestdata: Snowridge: Update with core-capability CPU feature

Signed-off-by: Tim Wiederhake --- .../cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor-disabled.xml b/tests/cputestdata/x86_64-cpuid-Atom-P5362-processor

[libvirt PATCH 3/7] cpu_map: Add support for core-capability CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b0bf22d916..a5a987deba 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -357,6

[libvirt PATCH 5/7] cpu_map: Add support for split-lock-detect CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index a5a987deba..4836595a8c 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -581,4

[libvirt PATCH 7/7] cpu_map: Define and enable Snowridge model

Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_Snowridge.xml | 71 +++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata

[libvirt PATCH v2] qemuDomainChangeNet: Check changed virtio network driver options

Changes to a virtio network device such as ... were quietly dismissed by `virsh update-device ... --live`. Signed-off-by: Tim Wiederhake Reviewed-by: Daniel P. Berrangé --- src/qemu/qemu_hotplug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu

Re: [libvirt PATCH 0/3] Small tweaks to cpu-gather.py script

src/cpu_map/x86_features.xml | 5 ++--- > tests/cputestdata/{cpu-gather.py => cpu-data.py} | 4 ++-- > 2 files changed, 4 insertions(+), 5 deletions(-) > rename tests/cputestdata/{cpu-gather.py => cpu-data.py} (99%) > Reviewed-by: Tim Wiederhake

[libvirt PATCH] cpu-data: Pretend to always run on logical processor #0

masks the occurences of the local apic id with 0x00, so that two consecutive runs of "./cpu-data.py gather" produce identical results. Signed-off-by: Tim Wiederhake --- tests/cputestdata/cpu-data.py | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/cpu

[libvirt PATCH] qemu_validate: Allow kvm hint-dedicated on non-passthrough VMs

A VM defined similar to: ... ... is currently invalid, as hint-dedicated is only allowed if cpu mode is host-passthrough. This restriction is unnecessary, see https://bugzilla.redhat.com/show_bug.cgi?id=1857671. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_validate.c | 11

[libvirt PATCH 1/3] xenParseHypervisorFeatures: Fix memory leak

Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..ad5a3de116 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -567,6 +567,7

[libvirt PATCH 0/3] Fix some memory leaks

These memory leaks were found by llvm's address sanitizer asan. Tim Wiederhake (3): xenParseHypervisorFeatures: Fix memory leak virDomainFeaturesDefParse: Fix memory leak virQEMUCapsSetHostModel: Fix memory leak src/conf/domain_conf.c | 2 +- src/libxl/xen_common.c | 1 +

[libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 029f2d8d9c..5591681283 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18994,12 +18994,12

[libvirt PATCH 3/3] virQEMUCapsSetHostModel: Fix memory leak

virQEMUCapsSetHostModel is called by virQEMUCapsInitHostCPUModel, which in turn is typically called twice (for KVM and QEMU), e.g. in virQEMUCapsLoadCache and virQEMUCapsNewForBinaryInternal. The second call leaks memory pointed to by "reported", "migratable" and "f

Re: [PATCH 00/21] Refactoring conf to use XPath

On Thu, 2021-04-15 at 16:26 +0200, Kristina Hanicova wrote: > This series reworks the outdated way of parsing XML to parsing by > XPath, > which is more obvious and saves a few lines of code. > > Kristina Hanicova (21): > conf: Propagate xmlXPathContextPtr into > virDomainHostdevSubsysUSBDef

[libvirt PATCH v6 1/8] virxml: Add virXMLPropTristateBool

Convenience function to return the value of a yes / no XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 44 src/util/virxml.h| 12 +++ 3 files changed

[libvirt PATCH v6 0/8] Refactor XML parsing boilerplate code

April/msg00232.html Changes since V5: * Applied changes requested in https://listman.redhat.com/archives/libvir-list/2021-April/msg00658.html Cheers, Tim Tim Wiederhake (8): virxml: Add virXMLPropTristateBool virxml: Add virXMLPropTristateSwitch virxml: Add virXMLPropInt virxml: Add virXM

[libvirt PATCH v6 3/8] virxml: Add virXMLPropInt

Convenience function to return the value of an integer XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 53 src/util/virxml.h| 8 ++ 3 files changed, 62

[libvirt PATCH v6 5/8] virxml: Add virXMLPropEnum

Convenience function to return the value of an enum XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 48 src/util/virxml.h| 8 +++ 3 files changed, 57

[libvirt PATCH v6 4/8] virxml: Add virXMLPropUInt

Convenience function to return the value of an unsigned integer XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 60 src/util/virxml.h| 8 ++ 3 files

[libvirt PATCH v6 2/8] virxml: Add virXMLPropTristateSwitch

Convenience function to return the value of an on / off XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 44 src/util/virxml.h| 6 ++ 3 files changed, 51

[libvirt PATCH v6 6/8] virNetworkForwardNatDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/network_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index f0f5ef6f42..17835ac8d3 100644 --- a/src/conf/network_conf.c +++ b/src

[libvirt PATCH v6 8/8] virCPUDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/cpu_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index c095ab0e89..c7bea8ae00 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c

[libvirt PATCH v6 7/8] virDomainIOThreadIDDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a0fb7731d9..858ef5db9d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

Re: [PATCH 0/5] util: xml: cleanup virxml.h and virXMLParseHelper

27; > virXMLParseHelper: Rework error reporting > virXMLParseHelper: Refactor cleanup > > src/util/virxml.c | 45 ++- > src/util/virxml.h | 193 +++- > -- > 2 files changed, 137 insertions(+), 101 deletions(-) > Reviewed-by: Tim Wiederhake

[libvirt PATCH 01/10] virDomainBackupDiskDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 40 ++-- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 2de77a59c0..859609946f 100644 --- a/src/conf/backup_conf.c +++ b/src/conf

[libvirt PATCH 06/10] virDomainDeviceDriveAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 621ff1b476..5a98cd8c0f 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH 08/10] virDomainDeviceCcidAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 587f966398..f7bf2de6f1 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -362,24

[libvirt PATCH 07/10] virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 5a98cd8c0f..587f966398 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c

[libvirt PATCH 04/10] virPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 47 +++--- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 8d3d012e4a..951b7a348e 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH 09/10] virDomainDeviceUSBAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index f7bf2de6f1..1ce31e9234 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -403,19 +403,16

[libvirt PATCH 05/10] virDomainDeviceCCWAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 51 +- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 951b7a348e..621ff1b476 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH 03/10] virZPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 6a4b14cfda..8d3d012e4a 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainBackupDiskDefParseXML: Use virXMLProp* virDomainBackupDefParse: Use virXMLProp* virZPCIDeviceAddressParseXML: Use virXMLProp* virPCIDeviceAddressParseXML: Use

[libvirt PATCH 02/10] virDomainBackupDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 859609946f..898725aac7 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -222,8

Re: [PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

rDomainDiskTray > conf: domain: Convert virDomainDiskDef's 'startupPolicy' to > virDomainStartupPolicy > > src/conf/domain_conf.c | 31 +++ > src/conf/domain_conf.h | 4 ++-- > 2 files changed, 9 insertions(+), 26 deletions(-) > Reviewed-by: Tim Wiederhake

[libvirt PATCH 10/10] virInterfaceLinkParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 1ce31e9234..a2893fec6f 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c

[libvirt PATCH v2 0/5] Fix some memory leaks

Fix memory leak", I will address this issue seperately * Added fixes for two more memory leaks and one issue found by ubsan (passing NULL to qsort) Tim Wiederhake (5): xenParseHypervisorFeatures: Fix memory leak virDomainFeaturesDefParse: Fix memory leak cmdCheckpointL

[libvirt PATCH v2 1/5] xenParseHypervisorFeatures: Fix memory leak

Fixes:b523e22521afe733165869c9e1ae18e88536acd6 Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..6fa69fbdf0 100644 --- a/src

[libvirt PATCH v2 2/5] virDomainFeaturesDefParse: Fix memory leak

Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4 Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17bbeddec6..356398294e 100644 --- a/src

[libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 20a02b0b02..afe849dd16 100644 --- a/tools/virsh-checkpoint.c

[libvirt PATCH v2 4/5] cmdSnapshotList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 2bec722c61..e64117785c 100644 --- a/tools/virsh-snapshot.c +++ b

[libvirt PATCH v2 5/5] virshCheckpointListCollect: Do not pass NULL to qsort

Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index afe849dd16..e88f9ffb47 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -628,7 +628,8

[libvirt PATCH 1/4] virxml: Fix schema validation of individual nodes

xmlDocSetRootElement removes the node from its previous document tree, effectively removing the "" node from "" in virCPUDefParseXML. Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 3 +-- src/util/virxml.c | 13 ++--- src/util/virxml.h | 1 - 3 files c

[libvirt PATCH 4/4] testUpdateQEMUCaps: Fix memory leak

testUpdateQEMUCaps is called multiple times. Use virQEMUCapsUpdateHostCPUModel instead of virQEMUCapsInitHostCPUModel to not overwrite (and leak) the pointers in qemuCaps->kvm.hostCPU and qemuCaps->tcg.hostCPU. Signed-off-by: Tim Wiederhake --- tests/qemuxml2argvtest.c | 8

[libvirt PATCH 3/4] qemu: Introduce virQEMUCapsUpdateHostCPUModel

Function will be used by next patch. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capspriv.h | 4 2 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 030779902d..7971a9c557

[libvirt PATCH 2/4] xenParseHypervisorFeatures: Remove superfluous VIR_FREE

Fixes: 4eb7c621985dad4de911ec394ac628bd1a5b29ab Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 6fa69fbdf0..aeb94e12ad 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl

[libvirt PATCH 0/4] Some memory leaks related fixes

/2021-April/msg00643.html Cheers, Tim Tim Wiederhake (4): virxml: Fix schema validation of individual nodes xenParseHypervisorFeatures: Remove superfluous VIR_FREE qemu: Introduce virQEMUCapsUpdateHostCPUModel testUpdateQEMUCaps: Fix memory leak src/conf/cpu_conf.c | 3 +-- src

[libvirt PATCH v2 01/10] virDomainBackupDiskDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/backup_conf.c | 40 ++-- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 7f54a25ff6..e4464b91a0 100644 --- a/src/conf

[libvirt PATCH v2 07/10] virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 66b7af109f..5360fb301f 100644 --- a/src/conf/device_conf.c +++ b

[libvirt PATCH v2 02/10] virDomainBackupDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/backup_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index e4464b91a0..7f176b783f 100644 --- a/src/conf/backup_conf.c +++ b/src

[libvirt PATCH v2 10/10] virInterfaceLinkParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `speed`, which does not make sense for a value measured in Mbits per second. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 25

[libvirt PATCH v2 03/10] virZPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 6a4b14cfda..9abbd5ebb7 100644 --- a/src/conf

[libvirt PATCH v2 05/10] virDomainDeviceCCWAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 53 ++ 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 801552a9cf..e527899d7d 100644 --- a/src/conf

[libvirt PATCH v2 04/10] virPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 47 +++--- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 9abbd5ebb7..801552a9cf 100644 --- a/src/conf

[libvirt PATCH v2 06/10] virDomainDeviceDriveAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index e527899d7d..66b7af109f 100644 --- a/src/conf

[libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Changes since V1: * Rebased * s/VIR_XML_PROP_OPTIONAL/VIR_XML_PROP_NONE/ * Declare variables 1 / line * Commented on strictening of parser in patch #10 Tim Wiederhake (10

[libvirt PATCH v2 09/10] virDomainDeviceUSBAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index dbe30b05c1..9b0b81b2cb 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH v2 08/10] virDomainDeviceCcidAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 5360fb301f..dbe30b05c1 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainVirtioOptionsParseXML: Use virXMLProp* virDomainDeviceBootParseXML: Use virXMLProp* virDomainDeviceISAAddressParseXML: Use virXMLProp* virDomainDiskSourceNVMeParse

[libvirt PATCH 04/10] virDomainDiskSourceNVMeParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b28265cf4f..6ea347e05b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8453,7

[libvirt PATCH 08/10] virDomainVideoResolutionDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ec7d48b40e..9e968c087d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 02/10] virDomainDeviceBootParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c13d9946c..9113993bce 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6465,22

[libvirt PATCH 10/10] virDomainLoaderDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 47 ++ 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1878d9ed9d..4c88a124bc 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 05/10] virDomainChrSourceDefParseFile: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6ea347e05b..d10d697884 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11678,20

[libvirt PATCH 01/10] virDomainVirtioOptionsParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a0d1f9285..5c13d9946c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 03/10] virDomainDeviceISAAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9113993bce..b28265cf4f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 07/10] virDomainAudioJackParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c97a062d1f..ec7d48b40e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13806,19

[libvirt PATCH 09/10] virDomainVsockDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 48 -- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9e968c087d..1878d9ed9d 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 06/10] virDomainChrSourceDefParseLog: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d10d697884..c97a062d1f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11713,20

[libvirt PATCH 02/10] virDomainKeyWrapDef: Make members virTristateSwitch

With the last usage of `aes` and `dea` as int gone, these two can become virTristateSwitch. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 4d1826362f

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part III

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainKeyWrapCipherDefParseXML: Use virXMLProp* virDomainKeyWrapDef: Make members virTristateSwitch qemuAppendKeyWrapMachineParm: Stricten parameter types virxml: Add

[libvirt PATCH 04/10] virxml: Add virXMLPropULongLong

Convenience function to return the value of an unsigned long long XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 56 src/util/virxml.h| 8 ++ 3 files changed, 65 insertions

[libvirt PATCH 07/10] virStorageEncryptionInfoParseCipher: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/storage_encryption_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_encryption_conf.c b/src/conf/storage_encryption_conf.c index c2c7c1dd43..9112b96cc7 100644 --- a/src/conf

[libvirt PATCH 05/10] virDomainDeviceDimmAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cc0bdeed56..c1ed206119 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 10/10] virDomainMemorytuneDefParseMemory: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 113f4123d7..c53ed60bae 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 08/10] virDomainDeviceInfoParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index eaa1398de1..367258bf7a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 01/10] virDomainKeyWrapCipherDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 40 +++- 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0a00be4e80..cc0bdeed56 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 03/10] qemuAppendKeyWrapMachineParm: Stricten parameter types

Follow up to the last patch. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2ceff15512..be93182092 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu

[libvirt PATCH 06/10] virDomainHostdevSubsysSCSIHostDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c1ed206119..eaa1398de1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 09/10] virDomainDiskSourceNetworkParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 55 -- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 367258bf7a..113f4123d7 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 03/10] virDomainDiskDef: Change type of rerror_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- src/conf/domain_conf.h | 2 +- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4a0358831b..0b12ec61f9 100644 --- a/src/conf/domain_conf.c +++ b

[libvirt PATCH 02/10] virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33c6412642..4a0358831b 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainDiskDef: Change type of cachemode to virDomainDiskCache virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy virDomainDiskDef: Change type of

[libvirt PATCH 05/10] virDomainDiskDef: Change type of discard to virDomainDiskDiscard

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 72664bd72b..9a4252099e 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 07/10] virDomainDiskDefDriverParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 150 +++-- 1 file changed, 39 insertions(+), 111 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 60f961c2b9..1bbf907596 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 09/10] domain_conf: Remove function virDomainChrSourceDefParseMode

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cdc32e52dd..447fc7dfcb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 10/10] virDomainChrSourceDefParseTCP: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 447fc7dfcb..24c0943d62 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 01/10] virDomainDiskDef: Change type of cachemode to virDomainDiskCache

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 720d56cf69..33c6412642 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 08/10] domain_conf: Introduce function virDomainChrSouceModeTypeFromString

Preparatory step to remove virDomainChrSourceDefParseMode. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1bbf907596..cdc32e52dd

[libvirt PATCH 06/10] virDomainDiskDef: Change type of detect_zeroes to virDomainDiskDetectZeroes

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a4252099e..60f961c2b9 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 04/10] virDomainDiskDef: Change type of iomode to virDomainDiskInfo

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b12ec61f9..72664bd72b 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH] vahDeinit: Fix memory leak

Calling VIR_FREE on a virDomainDef* does not free its various contained pointers. Signed-off-by: Tim Wiederhake --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 68ac817f47

[libvirt PATCH 01/10] virXMLPropEnum: Fix return value

Function incorrectly returns 0 when property was successfully read. Fixes: ab5d2776c925ec45eb54ec5432f5645cebb80c85 Signed-off-by: Tim Wiederhake --- src/util/virxml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index b79050db35

[libvirt PATCH 04/10] virDomainControllerDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 281 +++-- 1 file changed, 103 insertions(+), 178 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33e79b20e6..152b4b8813 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 03/10] virDomainPCIControllerOpts: Change type of modelName to virDomainControllerPCIModelName

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 +--- src/conf/domain_conf.h | 2 +- src/qemu/qemu_domain_address.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4ed7c0ef83

[libvirt PATCH 06/10] virDomainActualNetDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 57 ++ 1 file changed, 19 insertions(+), 38 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 554efe0aea..3051a5d56d 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 05/10] virDomainActualNetDef: Change type of type to virDomainNetType

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 2 +- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 152b4b8813..554efe0aea 100644 --- a/src/conf

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part V

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virXMLPropEnum: Fix return value virDomainControllerDef: Change type of ioeventfd to virTristateSwitch virDomainPCIControllerOpts: Change type of modelName to

<    1   2   3   4   5   6   7   8   9   10   >