[libvirt PATCH 09/10] virNWFilterIPAddrMapInit: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_ipaddrmap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index d6facd749e..bc21c80536 100644 --- a/src/conf/nwfilter_ipaddrmap.c +++ b/src/conf/nwfilter_ipaddrmap.c

[libvirt PATCH 06/10] virNWFilterParseParamAttributes: Simplify loop body

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 0b1676e25f..63ab7e7150 100644 --- a/src/conf/nwfilter_params.c

[libvirt PATCH 03/10] virNWFilterParseParamAttributes: Iterate over "element" children

"xmlNextElementSibling()" skips attribute nodes, making the explicit check for the type of `cur` redundant. This prepares for the removal of this check in the next commit. Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt PATCH 04/10] virNWFilterParseParamAttributes: Remove tautological `if`

`cur` is guaranteed to be of type `XML_ELEMENT_NODE` by using `xmlFirstElementChild()` and `xmlNextElementSibling()`. Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 57 +++--- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/src

[libvirt PATCH 02/10] virNWFilterParseParamAttributes: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index aeed0cff1f..c94e9679f8 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -702,8 +702,6

[libvirt PATCH 00/10] virHashNew refactorings - part V

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue virNWFilterParseParamAttributes: `virHashNew` cannot r

[libvirt PATCH 01/10] conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/nwfilter_params.h b/src/conf/nwfilter_params.h index d11b533958..f9f7f68ff3 100644 --- a/src/conf/nwfilter_params.h +++ b/src/conf/nwfilter_params.h @@ -51,6 +51,8

Re: [PATCH 0/7] Various fixes

_block.c  |  8 ++ >  src/qemu/qemu_domain.c | 57 ++-- > -- >  src/util/virhash.h |  2 +- >  6 files changed, 39 insertions(+), 61 deletions(-) > LGTM. Series: Reviewed-by: Tim Wiederhake

[libvirt PATCH 0/3] virHashNew refactorings - part VIII

e_t` typed variables. Tim Wiederhake (3): virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL virNWFilterParseParamAttributes: Simplify loop src/conf/nwfilter_params.c | 7 ++- src/conf/virstorageobj.c | 7 ++-

[libvirt PATCH 1/3] virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index edf2ec907f..46bd922f35 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -293,8 +293,7

[libvirt PATCH 3/3] virNWFilterParseParamAttributes: Simplify loop

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 35ea0256c3..ca7b62874c 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c

[libvirt PATCH 2/3] WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 32ed55ff8b..18a7718de9 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -398,11

[libvirt PATCH] docs: Fix two spelling mistakes

Signed-off-by: Tim Wiederhake --- docs/kbase/qemu-core-dump.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/qemu-core-dump.rst b/docs/kbase/qemu-core-dump.rst index 44fd40fc52..5c3781cf90 100644 --- a/docs/kbase/qemu-core-dump.rst +++ b/docs/kbase/qemu-core

[libvirt PATCH] AUTHORS: Add myself to the list of commiters

Signed-off-by: Tim Wiederhake --- AUTHORS.rst.in | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in index a580359c0e..e8a560b780 100644 --- a/AUTHORS.rst.in +++ b/AUTHORS.rst.in @@ -31,6 +31,7 @@ The primary maintainers and people with commit access rights

[libvirt PATCH 12/14] virInterfaceDefParseIfAdressing: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 8be439a2a1..8f8e8871cb 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

[libvirt PATCH 04/14] conf: interface: Preparation for g_auto

These changes make the g_auto-ification in the next commit clearer. Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 150616bda9..cbe6aad957

[libvirt PATCH 13/14] virInterfaceDefParseXML: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 8f8e8871cb..7c2a0f162c 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

[libvirt PATCH 14/14] virInterfaceDefParse: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 7c2a0f162c..305a312327 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c

[libvirt PATCH 09/14] virInterfaceDefParseDhcp: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 0b3e5716f3..bfeb69e664 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

[libvirt PATCH 02/14] virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5f1eb5014c..f8db6fd370 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu

[libvirt PATCH 03/14] virInterfaceDefDevFormat: Add missing error handling

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index f2b3804bec..150616bda9 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c

[libvirt PATCH 06/14] conf: interface: Remove ret and goto

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 129 +++--- 1 file changed, 49 insertions(+), 80 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 4b464bdf4f..47f9da797d 100644 --- a/src/conf/interface_conf.c

[libvirt PATCH 07/14] virInterfaceDefParseXML: Inline trivial virInterfaceDefParseName

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 47f9da797d..f3fc47bd69 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

[libvirt PATCH 05/14] conf: interface: Use g_auto

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 67 --- 1 file changed, 20 insertions(+), 47 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index cbe6aad957..4b464bdf4f 100644 --- a/src/conf/interface_conf.c

[libvirt PATCH 00/14] Random fixes and improvements

A collection of drive-by fixes and improvements that quickly derailed into the g_auto-ification of src/conf/interface_conf.c. Tim Wiederhake (14): docs: coding-style: Clarify on virXXXPtr types virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage virInterfaceDefDevFormat: Add missing

[libvirt PATCH 01/14] docs: coding-style: Clarify on virXXXPtr types

Signed-off-by: Tim Wiederhake --- docs/coding-style.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 470c61860f..ab7634dc14 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -54,6 +54,7 @@ Struct type names

[libvirt PATCH 10/14] virInterfaceDefParseProtoIPv4: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index bfeb69e664..c41eecac29 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c

[libvirt PATCH 11/14] virInterfaceDefParseProtoIPv6: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index c41eecac29..8be439a2a1 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

[libvirt PATCH 08/14] virInterfaceDefParseIP: Simplify and cleanup

Signed-off-by: Tim Wiederhake --- src/conf/interface_conf.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index f3fc47bd69..0b3e5716f3 100644 --- a/src/conf/interface_conf.c +++ b/src/conf

Re: [libvirt PATCH 00/14] Random fixes and improvements

On Wed, 2022-01-12 at 15:36 +0100, Michal Prívozník wrote: > On 1/12/22 14:10, Tim Wiederhake wrote: > > A collection of drive-by fixes and improvements that quickly > > derailed > > into the g_auto-ification of src/conf/interface_conf.c. > > > > Tim Wiederha

[libvirt PATCH v2 3/3] Fix some typos

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_cgroup.c| 2 +- tests/qemucapabilitiesnumbering.c | 2 +- tests/qemucapabilitiestest.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 308be5b00f

[libvirt PATCH v2 2/3] ci: Add spell checking

Allow failure to not have false-positives fail the builds. Signed-off-by: Tim Wiederhake --- .gitlab-ci.yml | 12 1 file changed, 12 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6ba11a0431..5e46f3dcb8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -87,6

[libvirt PATCH v2 0/3] ci: Check spelling

not mark patch #2 as already reviewed. Regards, Tim Tim Wiederhake (3): scripts: Check spelling ci: Add spell checking Fix some typos .gitlab-ci.yml| 12 +++ scripts/check-spelling.py | 119 ++ src/qemu/qemu_cgroup.c| 2

[libvirt PATCH v2 1/3] scripts: Check spelling

of per-directory ignore lists and some oddities regarding capitalization in ignore lists. [1] (https://github.com/codespell-project/codespell/) Signed-off-by: Tim Wiederhake --- scripts/check-spelling.py | 119 ++ 1 file changed, 119 insertions(+) create mode

[libvirt PATCH v2 2/2] docs: coding-style: One variable declaration per line

This was not mentioned before. Signed-off-by: Tim Wiederhake --- docs/coding-style.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index ee4d551805..01f1e25127 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst

[libvirt PATCH v2 0/2] Code style documentation

not for private types * patches 2 and 3: Pushed * patch 4 (now 2): Rewritten examples as requested Tim Wiederhake (2): docs: coding-style: Clarify on virXXXPtr types docs: coding-style: One variable declaration per line docs/coding-style.rst | 20 +++- 1 file changed, 19

[libvirt PATCH v2 1/2] docs: coding-style: Clarify on virXXXPtr types

This partially reverts commit 9ccbed6afb. Signed-off-by: Tim Wiederhake --- docs/coding-style.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 37e6009db4..ee4d551805 100644 --- a/docs/coding-style.rst +++ b/docs

Re: [libvirt PATCH v2 1/2] docs: coding-style: Clarify on virXXXPtr types

On Mon, 2022-01-17 at 11:40 +0100, Peter Krempa wrote: > On Mon, Jan 17, 2022 at 11:19:02 +0100, Tim Wiederhake wrote: > > This partially reverts commit 9ccbed6afb. > > > > Signed-off-by: Tim Wiederhake > > --- > >  docs/coding-style.rst | 7 ++- > &

[libvirt PATCH v2 01/10] test: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/test/test_driver.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4eca5c4a65..34e4652375 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1386,16

[libvirt PATCH v2 03/10] remote_daemon_dispatch: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/remote/remote_daemon_dispatch.c | 187 +--- 1 file changed, 58 insertions(+), 129 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index 510856024c..1a73976831 100644 --- a/src

[libvirt PATCH v2 06/10] admin: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/admin/admin_server_dispatch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/admin/admin_server_dispatch.c b/src/admin/admin_server_dispatch.c index f533fcf539..893c7f1de2 100644 --- a/src/admin/admin_server_dispatch.c +++ b/src

[libvirt PATCH v2 08/10] esx_vi: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/esx/esx_vi.c | 109 --- 1 file changed, 47 insertions(+), 62 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 36e9dc1d2c..b56d84fc43 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c

[libvirt PATCH v2 00/10] Automatic mutex management - part 3

of working around the issue of the lifetime of the mutex. Tim Wiederhake (10): test: Use automatic mutex management openvz: Use automatic mutex management remote_daemon_dispatch: Use automatic mutex management netdev: Use automatic mutex management nodesuspend: Use automatic mutex management

[libvirt PATCH v2 04/10] netdev: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/util/virnetdev.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index fcf679ec37..5df48af60c 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3568,12

[libvirt PATCH v2 09/10] storage: Removing mutex locking in initialization and cleanup

These functions are only ever called in a single threaded environment and the mutex would not have prevented concurrent access anyway. Signed-off-by: Tim Wiederhake --- src/storage/storage_driver.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/storage/storage_driver.c b/src

[libvirt PATCH v2 10/10] storage: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/storage/storage_driver.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ee710f6b76..e3e1604311 100644 --- a/src/storage/storage_driver.c +++ b

[libvirt PATCH v2 05/10] nodesuspend: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/util/virnodesuspend.c | 54 +-- 1 file changed, 18 insertions(+), 36 deletions(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index e1167605ca..5feef79c43 100644 --- a/src/util/virnodesuspend.c

[libvirt PATCH v2 07/10] esx_stream: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/esx/esx_stream.c | 65 ++-- 1 file changed, 21 insertions(+), 44 deletions(-) diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index 5b20804bb1..2b49c8dd12 100644 --- a/src/esx/esx_stream.c +++ b/src/esx

[libvirt PATCH v2 02/10] openvz: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/openvz/openvz_driver.c | 91 -- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index aa1db09540..d8e4dd7f8b 100644 --- a/src/openvz/openvz_driver.c

Re: [libvirt PATCH v2 00/10] Automatic mutex management - part 3

ping On Fri, 2022-03-04 at 18:28 +0100, Tim Wiederhake wrote: > Use the recently implemented VIR_LOCK_GUARD and > VIR_WITH_MUTEX_LOCK_GUARD > to simplify mutex management. > > v1: > https://listman.redhat.com/archives/libvir-list/2022-February/msg00674.html > > Chang

Re: [libvirt PATCH v2 07/10] esx_stream: Use automatic mutex management

On Thu, 2022-03-17 at 10:44 +0100, Pavel Hrdina wrote: > On Fri, Mar 04, 2022 at 06:28:37PM +0100, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > >  src/esx/esx_stream.c | 65 ++-- > > > >  1 file change

[libvirt PATCH] esx_stream: Fix NULL dereferences

A wrong reordering caused "priv" to be derefenced before the NULL-check in esxStreamSend and esxStreamRecvFlags. Fixes: 12e19f172d2a908eec2a4557202ff764cdbb951e Signed-off-by: Tim Wiederhake --- src/esx/esx_stream.c | 102 +++ 1 file c

[libvirt PATCH v2 10/13] virNetlinkEventAddClient: Remove goto

Signed-off-by: Tim Wiederhake --- src/util/virnetlink.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 3216765492..c6c8c33c7c 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c

[libvirt PATCH v2 13/13] qemu_conf: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_conf.c | 70 ++-- 1 file changed, 29 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 81449b8b77..4b5f75b694 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu

[libvirt PATCH v2 09/13] nwfilter_ipaddrmap: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_ipaddrmap.c | 80 ++- 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index e2f123b9d9..4090cc2769 100644 --- a/src/conf

[libvirt PATCH v2 12/13] remote_daemon_stream: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/remote/remote_daemon_stream.c | 34 +-- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index eb7ed5edf3..a6d2c915e6 100644 --- a/src/remote

[libvirt PATCH v2 01/13] nwfilter_driver: Statically initialize mutex

This enables a later patch to simplify locking during initialization and cleanup of virNWFilterDriverState. Signed-off-by: Tim Wiederhake --- src/conf/virnwfilterobj.h | 1 - src/nwfilter/nwfilter_driver.c | 11 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git

[libvirt PATCH v2 02/13] nwfilter_driver: Split up nwfilterStateCleanup

This allows nwfilterStateCleanupLocked to be used in nwfilterStateInitialize in a later patch. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_driver.c | 89 +- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c

[libvirt PATCH v2 07/13] nwfilter_dhcpsnoop: Replace virNWFilterSnoopReqLock functions

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 277 ++ 1 file changed, 95 insertions(+), 182 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH v2 04/13] nwfilter_gentech: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 33 +- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 7bbf1e12fb..a8c0c6aa22 100644 --- a/src

[libvirt PATCH v2 06/13] nwfilter_dhcpsnoop: Replace virNWFilterSnoopLock macros

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 89 +++ 1 file changed, 30 insertions(+), 59 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH v2 03/13] nwfilter_driver: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_driver.c | 83 ++ 1 file changed, 34 insertions(+), 49 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index eefb2b0fff..bfda96b7ed 100644 --- a/src/nwfilter

[libvirt PATCH v2 08/13] nwfilter_learnipaddr: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_learnipaddr.c | 83 + 1 file changed, 24 insertions(+), 59 deletions(-) diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index 99bffdc4fb..2c85972012 100644 --- a/src

[libvirt PATCH v2 11/13] virnetlink: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/virnetlink.c | 222 +++--- 1 file changed, 101 insertions(+), 121 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index c6c8c33c7c..04a39a905b 100644 --- a/src/util/virnetlink.c +++ b/src/util

[libvirt PATCH v2 00/13] Automatic mutex management - part 4

to be initialized with NULL (i.e. referencing no mutex). Tim Wiederhake (13): nwfilter_driver: Statically initialize mutex nwfilter_driver: Split up nwfilterStateCleanup nwfilter_driver: Use automatic mutex management nwfilter_gentech: Use automatic mutex management nwfilter_dhcpsnoop: Replace

[libvirt PATCH v2 05/13] nwfilter_dhcpsnoop: Replace virNWFilterSnoopActiveLock macros

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 42 --- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH v3 0/2] Automatic mutex management - part 4

virQEMUDriverGetCapabilities, thanks Michal! * Added VIR_WITH_MUTEX_LOCK_GUARD to nwfilterConnectNumOfNWFilters * Other patches were reviewed and pushed. Tim Wiederhake (2): nwfilter_driver: Use automatic mutex management qemu_conf: Use automatic memory management src/nwfilter/nwfilter_driver.c | 94

[libvirt PATCH v3 2/2] qemu_conf: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_conf.c | 63 +++- 1 file changed, 21 insertions(+), 42 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 81449b8b77..c22cf79cbe 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu

[libvirt PATCH v3 1/2] nwfilter_driver: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_driver.c | 94 +++--- 1 file changed, 40 insertions(+), 54 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index c5f0169623..cac73c50e5 100644 --- a/src/nwfilter

[libvirt PATCH 10/12] virnetlink: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/virnetlink.c | 101 -- 1 file changed, 39 insertions(+), 62 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 3216765492..f15bb68b02 100644 --- a/src/util/virnetlink.c +++ b/src/util

[libvirt PATCH 09/12] nwfilter_ipaddrmap: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_ipaddrmap.c | 80 ++- 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index e2f123b9d9..4090cc2769 100644 --- a/src/conf

[libvirt PATCH 11/12] remote_daemon_stream: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/remote/remote_daemon_stream.c | 34 +-- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index eb7ed5edf3..a6d2c915e6 100644 --- a/src/remote

[libvirt PATCH 12/12] qemu_conf: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_conf.c | 70 ++-- 1 file changed, 29 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 81449b8b77..4b5f75b694 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu

[libvirt PATCH 02/12] nwfilter_driver: Split up nwfilterStateCleanup

This allows nwfilterStateCleanupLocked to be used in nwfilterStateInitialize in a later patch. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_driver.c | 89 +- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c

[libvirt PATCH 03/12] nwfilter_driver: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_driver.c | 83 +- 1 file changed, 32 insertions(+), 51 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 8eea9e5805..12bbbc661f 100644 --- a/src/nwfilter

[libvirt PATCH 05/12] nwfilter_dhcpsnoop: Replace virNWFilterSnoopActiveLock macros

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 42 --- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH 08/12] nwfilter_learnipaddr: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_learnipaddr.c | 83 + 1 file changed, 24 insertions(+), 59 deletions(-) diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index 99bffdc4fb..2c85972012 100644 --- a/src

[libvirt PATCH 06/12] nwfilter_dhcpsnoop: Replace virNWFilterSnoopLock macros

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 90 +++ 1 file changed, 30 insertions(+), 60 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH 00/12] Automatic mutex management - part 4

Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD to simplify mutex management. Tim Wiederhake (12): nwfilter_driver: Statically initialize mutex nwfilter_driver: Split up nwfilterStateCleanup nwfilter_driver: Use automatic mutex management nwfilter_gentech: Use

[libvirt PATCH 01/12] nwfilter_driver: Statically initialize mutex

This enables a later patch to simplify locking during initialization and cleanup of virNWFilterDriverState. Signed-off-by: Tim Wiederhake --- src/conf/virnwfilterobj.h | 1 - src/nwfilter/nwfilter_driver.c | 11 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git

[libvirt PATCH 04/12] nwfilter_gentech: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 34 +- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 7bbf1e12fb..3f888ce873 100644 --- a/src

[libvirt PATCH 07/12] nwfilter_dhcpsnoop: Replace virNWFilterSnoopReqLock functions

Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 273 +++--- 1 file changed, 95 insertions(+), 178 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH 08/11] esx_vi: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/esx/esx_vi.c | 109 --- 1 file changed, 47 insertions(+), 62 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 36e9dc1d2c..b56d84fc43 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c

[libvirt PATCH 03/11] remote_daemon_dispatch: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/remote/remote_daemon_dispatch.c | 187 +--- 1 file changed, 58 insertions(+), 129 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index 587cc0b3a5..c0577b07b7 100644 --- a/src

[libvirt PATCH 07/11] esx_stream: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/esx/esx_stream.c | 65 ++-- 1 file changed, 21 insertions(+), 44 deletions(-) diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index 5b20804bb1..2b49c8dd12 100644 --- a/src/esx/esx_stream.c +++ b/src/esx

[libvirt PATCH 09/11] storage: Statically initialize mutex

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.h | 2 -- src/storage/storage_driver.c | 11 --- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/conf/virstorageobj.h b/src/conf/virstorageobj.h index 523bdec244..ad6005f153 100644 --- a/src/conf

[libvirt PATCH 10/11] storage: Move and split up storateStateCleanup

Signed-off-by: Tim Wiederhake --- src/storage/storage_driver.c | 71 +++- 1 file changed, 37 insertions(+), 34 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 05675a5539..3bd5d07efb 100644 --- a/src/storage

[libvirt PATCH 11/11] storage: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/storage/storage_driver.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 3bd5d07efb..74c03b4cbf 100644 --- a/src/storage/storage_driver.c +++ b/src

[libvirt PATCH 04/11] netdev: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/util/virnetdev.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index fcf679ec37..5df48af60c 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3568,12

[libvirt PATCH 01/11] test: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/test/test_driver.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 03c41ca192..0ee53a8469 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1386,16

[libvirt PATCH 05/11] nodesuspend: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/util/virnodesuspend.c | 54 +-- 1 file changed, 18 insertions(+), 36 deletions(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index e1167605ca..5feef79c43 100644 --- a/src/util/virnodesuspend.c

[libvirt PATCH 06/11] admin: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/admin/admin_server_dispatch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/admin/admin_server_dispatch.c b/src/admin/admin_server_dispatch.c index f533fcf539..893c7f1de2 100644 --- a/src/admin/admin_server_dispatch.c +++ b/src

[libvirt PATCH 02/11] openvz: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/openvz/openvz_driver.c | 91 -- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index b2589059c8..8cfde6a96e 100644 --- a/src/openvz/openvz_driver.c

[libvirt PATCH 00/11] Automatic mutex management - part 3

Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD to simplify mutex management. Tim Wiederhake (11): test: Use automatic mutex management openvz: Use automatic mutex management remote_daemon_dispatch: Use automatic mutex management netdev: Use automatic mutex

[libvirt PATCH][merged][trivial] Fix typo in NEWS

Signed-off-by: Tim Wiederhake --- NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index b684416909..cc5666fa91 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,7 +32,7 @@ v8.1.0 (unreleased) either of the following 3 options: ``page-sampling

Re: [libvirt PATCH 09/11] storage: Statically initialize mutex

On Thu, 2022-02-17 at 13:15 +, Daniel P. Berrangé wrote: > On Thu, Feb 17, 2022 at 02:01:01PM +0100, Tim Wiederhake wrote: > > Really should be giving an explanation of why this change > is required. > Added locally to commit message: Making the mutex static

[libvirt PATCH][merged][trivial] Fix typo in NEWS

Signed-off-by: Tim Wiederhake --- NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 14c4aaf185..a5b6106bc2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -77,7 +77,7 @@ v8.1.0 (2022-03-01) * Remove unix sockets from filesystem when disabling

[libvirt PATCH 06/10] qemu_agent: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_agent.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 4909fb336f..4156cb0dca 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c

[libvirt PATCH 03/10] node_device_driver: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/node_device/node_device_driver.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 130c1d4023..1eb452b989 100644 --- a/src/node_device

[libvirt PATCH 07/10] vbox_common: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/vbox/vbox_common.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index acd18494d3..03f55f2f1e 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox

<    7   8   9   10   11   12   13   14   15   >