[libvirt PATCH 10/12] virnetlink: Use automatic memory management

2022-03-09 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/util/virnetlink.c | 101 -- 1 file changed, 39 insertions(+), 62 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 3216765492..f15bb68b02 100644 --- a/src/util/virnetlink.c +++ b/src/util

[libvirt PATCH 09/12] nwfilter_ipaddrmap: Use automatic mutex management

2022-03-09 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_ipaddrmap.c | 80 ++- 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index e2f123b9d9..4090cc2769 100644 --- a/src/conf

[libvirt PATCH 11/12] remote_daemon_stream: Use automatic memory management

2022-03-09 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/remote/remote_daemon_stream.c | 34 +-- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index eb7ed5edf3..a6d2c915e6 100644 --- a/src/remote

[libvirt PATCH 12/12] qemu_conf: Use automatic memory management

2022-03-09 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/qemu/qemu_conf.c | 70 ++-- 1 file changed, 29 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 81449b8b77..4b5f75b694 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu

[libvirt PATCH 07/12] nwfilter_dhcpsnoop: Replace virNWFilterSnoopReqLock functions

2022-03-09 Thread Tim Wiederhake
Use automatic mutex management instead. Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_dhcpsnoop.c | 273 +++--- 1 file changed, 95 insertions(+), 178 deletions(-) diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c index

[libvirt PATCH 05/15] cpu_map: Add missing feature "avx-ne-convert"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 76ffd2d142..01b07808d8 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -432,6

[libvirt PATCH 09/15] cpu_map: Add missing feature "flush-l1d"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-Atom-P5362-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-Atom-P5362-guest.xml| 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362

[libvirt PATCH 07/15] cpu_map: Add missing feature "cmpccxadd"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index f5270bedb7..5309ea00ec 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -416,6

[libvirt PATCH 00/15] Sync cpu features with qemu

2023-05-24 Thread Tim Wiederhake
This brings libvirt in sync qith qemu commit 886c0453cbf10eebd42a9ccf89c3e46eb389c357. Tim Wiederhake (15): cpu_map: Add missing feature "amd-psfd" cpu_map: Add missing feature "amx-fp16" cpu_map: Add missing feature "auto-ibrs" cpu_map: Add missing fea

[libvirt PATCH 02/15] cpu_map: Add missing feature "amx-fp16"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index a40262807a..fa28656d4c 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -425,6

[libvirt PATCH 12/15] cpu_map: Add missing feature "null-sel-clr-base"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 7bfefbf5bc..e14d023fca 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -712,6

[libvirt PATCH 10/15] cpu_map: Add missing feature "lfence-always-serializing"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index e4056ef1a0..75bfa81925 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -706,6

[libvirt PATCH 08/15] cpu_map: Add missing feature "fb-clear"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 5309ea00ec..c0f6a3c6d0 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -735,6

[libvirt PATCH 01/15] cpu_map: Add missing feature "amd-psfd"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 0c4d0ebdb3..a40262807a 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -633,6

[libvirt PATCH 06/15] cpu_map: Add missing feature "avx-vnni-int8"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 01b07808d8..f5270bedb7 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -432,6

[libvirt PATCH 11/15] cpu_map: Add missing feature "no-nested-data-bp"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 75bfa81925..7bfefbf5bc 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -706,6

[libvirt PATCH 03/15] cpu_map: Add missing feature "auto-ibrs"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index fa28656d4c..69b13cb957 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -689,6

[libvirt PATCH 04/15] cpu_map: Add missing feature "avx-ifma"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 69b13cb957..76ffd2d142 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -428,6

[libvirt PATCH 13/15] cpu_map: Add missing feature "prefetchiti"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index e14d023fca..ff591e83e2 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -444,6

[libvirt PATCH 14/15] cpu_map: Add missing feature "stibp-always-on"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index ff591e83e2..057dc1b055 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -646,6

[libvirt PATCH 15/15] cpu_map: Add missing feature "vnmi"

2023-05-24 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 057dc1b055..3a90a4c9de 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -707,6

Re: [libvirt 1/2] cpu_map: Add SapphireRapids CPU model

2023-05-24 Thread Tim Wiederhake
On Wed, 2023-05-17 at 17:30 -0700, Lin Yang wrote: > Introduced in QEMU by commit v8.0.0-7eb061b06e. > > Signed-off-by: Lin Yang > --- >  src/cpu_map/index.xml  |   1 + >  src/cpu_map/meson.build    |   1 + >  src/cpu_map/x86_SapphireRapids.xml | 116 >

[libvirt PATCH 2/2] sync_qemu_models_i386.py: Add missing features

2023-05-24 Thread Tim Wiederhake
This brings the tool's list of features in sync with qemu commit 886c0453cbf10eebd42a9ccf89c3e46eb389c357. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_models_i386.py | 8 1 file changed, 8 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cp

[libvirt PATCH 1/2] sync_qemu_models_i386.py: Fix complaint from flake8

2023-05-24 Thread Tim Wiederhake
Line was too long. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_models_i386.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cpu_map/sync_qemu_models_i386.py index 37bbe6d09e..4974b30b43 100755 --- a/src/cpu_map

[libvirt PATCH 6/6] sync_qemu_models_i386.py: Add missing features

2023-07-13 Thread Tim Wiederhake
This brings the tool's list of features in sync with qemu commit 6f05a92ddc73ac8aa16cfd6188f907b30b0501e3. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_models_i386.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cp

[libvirt PATCH 3/6] cpu_map: Add missing feature "fbsdp-no"

2023-07-13 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index ebc43be8ce..3352e6a83c 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -763,6

[libvirt PATCH 0/6] Sync cpu features with qemu

2023-07-13 Thread Tim Wiederhake
This brings libvirt in sync qith qemu commit 6f05a92ddc73ac8aa16cfd6188f907b30b0501e3. Tim Wiederhake (6): cpu_map: Add missing feature "mcdt-no" cpu_map: Add missing feature "sbdr-ssdp-no" cpu_map: Add missing feature "fbsdp-no" cpu_map: Add missing fe

[libvirt PATCH 1/6] cpu_map: Add missing feature "mcdt-no"

2023-07-13 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 3a90a4c9de..8c89de3344 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -448,6

[libvirt PATCH 5/6] cpu_map: Add missing feature "pbrsb-no"

2023-07-13 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b871059c99..5845a2331b 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -772,6

[libvirt PATCH 2/6] cpu_map: Add missing feature "sbdr-ssdp-no"

2023-07-13 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 8c89de3344..ebc43be8ce 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -760,6

[libvirt PATCH 4/6] cpu_map: Add missing feature "psdp-no"

2023-07-13 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 3352e6a83c..b871059c99 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -766,6

[libvirt PATCH 0/5] Simplify x86 cpu feature synchronization with qemu

2023-07-25 Thread Tim Wiederhake
branch is required. [1] https://gitlab.com/twiederh/libcpuinfo Tim Wiederhake (5): cpu_map: Sort cpu features cpu_map: Format register values uniformly cpu_map: Format comments cpu_map: Remove unused alias information cpu_map: Generate x86 feature map from libcpuinfo src/cpu_map/x86_f

[libvirt PATCH 4/5] cpu_map: Remove unused alias information

2023-07-25 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 25 - 1 file changed, 25 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 33e24f145f..2b770818ff 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH 2/5] cpu_map: Format register values uniformly

2023-07-25 Thread Tim Wiederhake
Use "0x%08x" as format for all values: sed -e "s/'0x\(..\)'/'0x00\\1'/g" -e "s/'0x\(...\)'/'0x0\\1'/g" Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 348 +-- 1 file

[libvirt PATCH 3/5] cpu_map: Format comments

2023-07-25 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 40 +--- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index f53ec0d835..33e24f145f 100644 --- a/src/cpu_map

[libvirt PATCH 5/5] cpu_map: Generate x86 feature map from libcpuinfo

2023-07-25 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.py | 119 1 file changed, 119 insertions(+) create mode 100755 src/cpu_map/x86_features.py diff --git a/src/cpu_map/x86_features.py b/src/cpu_map/x86_features.py new file mode 100755 index

[libvirt PATCH 1/5] cpu_map: Sort cpu features

2023-07-25 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 259 ++- 1 file changed, 130 insertions(+), 129 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 5845a2331b..8f46549e76 100644 --- a/src/cpu_map

[libvirt PATCH 2/2] cpu_map: Add cpu model EPYC Genoa

2023-09-06 Thread Tim Wiederhake
This was added in qemu commit 166b174188. No additional features had to be added to libvirt. Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_EPYC-Genoa.xml| 115

[libvirt PATCH 0/2] Add cpu model for EPYC Genoa

2023-09-06 Thread Tim Wiederhake
Plus one drive-by improvement to sync_qemu_features_i386.py. Tim Wiederhake (2): cpu_map: Ignore all vmx-* features in sync_qemu_features_i386.py cpu_map: Add cpu model EPYC Genoa src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1

[libvirt PATCH 1/2] cpu_map: Ignore all vmx-* features in sync_qemu_features_i386.py

2023-09-06 Thread Tim Wiederhake
The script that synchronizes cpu models from qemu, sync_qemu_models_i386.py, ignores all features that begin with "vmx-". Do the same for synchronizing cpu features so we do not have to track irrelevant features individually. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_fea

[merged][libvirt PATCH] docs: Fix typos

2022-07-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- docs/drvqemu.rst | 2 +- docs/testing.rst | 2 +- docs/testtck.rst | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index c9f2432268..c33706ccea 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst

Re: [libvirt PATCH 0/9] [RFC] Dynamic CPU models

2022-07-18 Thread Tim Wiederhake
See below. What do the more experienced libvirt developers think, is this going in the right direction? Thanks, Tim On Tue, 2022-06-28 at 18:09 +0200, Tim Wiederhake wrote: > libvirt and qemu cpu models are out of sync. libvirt cpu models are > considered static and never changing, wherea

Re: [PATCH 0/2] Two simple virBuffer*() usage fixes

2022-07-19 Thread Tim Wiederhake
pabilities.c | 2 +- >  2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Tim Wiederhake

Re: [PATCH 0/7] Refactor closecallback use in LXC

2022-07-19 Thread Tim Wiederhake
_process.c  | 141 +++ > -- >  src/lxc/lxc_process.h      |   8 +- >  6 files changed, 69 insertions(+), 125 deletions(-) > Reviewed-by: Tim Wiederhake

[libvirt PATCH] schema: Add maxphysaddr element to hostcpu

2022-08-09 Thread Tim Wiederhake
The output of "virsh capabilities" was not conformant to the capability.rng schema. Add the missing element to the schema. Fixes: c647bf29afb9890c792172ecf7db2c9c27babbb6 Signed-off-by: Tim Wiederhake --- src/conf/schemas/cputypes.rng | 3 +++ 1 file changed, 3 insertions(+) diff -

Re: [libvirt PATCH] schema: Add maxphysaddr element to hostcpu

2022-08-10 Thread Tim Wiederhake
On Tue, 2022-08-09 at 17:35 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 09, 2022 at 06:22:12PM +0200, Tim Wiederhake wrote: > > The output of "virsh capabilities" was not conformant to the > > capability.rng schema. Add the missing element to the schema. > > Th

[libvirt PATCH] cputestdata: Fix test data for EPYC 7502

2022-10-19 Thread Tim Wiederhake
Commit 5c17a7ba41 introduced a new feature (ibrs) but did not update existing cputestdata. Signed-off-by: Tim Wiederhake --- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[libvirt PATCH 02/28] cpu_x86: Ignore alias names

2022-10-19 Thread Tim Wiederhake
A later patch will add alias names to the feature map. Ignore them for now. Signed-off-by: Tim Wiederhake --- src/cpu/cpu_x86.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 4d2379803c..d2560de497 100644 --- a/src/cpu

[libvirt PATCH 01/28] cpu-data.py: Allow for more than child in feature nodes

2022-10-19 Thread Tim Wiederhake
cpu-data.py assumes that all "feature" nodes have exactly one child. This assumption will no longer be true when the cpumap includes alias- names for features. Signed-off-by: Tim Wiederhake --- tests/cputestdata/cpu-data.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletion

[libvirt PATCH 00/28] Synchronize x86 cpu features from qemu

2022-10-19 Thread Tim Wiederhake
were already proposed on the list[1]. [1] https://listman.redhat.com/archives/libvir-list/2022-September/234292.html Tim Wiederhake (28): cpu-data.py: Allow for more than child in feature nodes cpu_x86: Ignore alias names cpu: make x86 feature alias names machine readable cpu_map: Add s

[libvirt PATCH 05/28] cpu_map: Rename sync_qemu_i386.py

2022-10-19 Thread Tim Wiederhake
This makes the naming more consistent beween the two scripts synching the feature list and the model list. Signed-off-by: Tim Wiederhake --- src/cpu_map/{sync_qemu_i386.py => sync_qemu_models_i386.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename src/cpu_map/{sync_qemu_i386

[libvirt PATCH 06/28] cpu_map: Add missing x86 feature alias names

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 90d0f43fc6..5f17255a56 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -555,15

[libvirt PATCH 08/28] cpu_map: Add missing x86 feature "sgxlc"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-8700-disabled.xml| 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-8700-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-Core-i7-8700-host.xml

[libvirt PATCH 10/28] cpu_map: Add missing x86 feature "sgx1"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 5b9e61a3d0..aa3d6958bf 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -415,6

[libvirt PATCH 03/28] cpu: make x86 feature alias names machine readable

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 55 +--- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4cf3ff0804..90d0f43fc6 100644 --- a/src/cpu_map

[libvirt PATCH 14/28] cpu_map: Add missing x86 feature "sgx-provisionkey"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4568c0246b..34c28e9135 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -429,6

[libvirt PATCH 18/28] cpu_map: Add missing x86 feature "pks"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0-tcg.x86_64

[libvirt PATCH 11/28] cpu_map: Add missing x86 feature "sgx2"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index aa3d6958bf..f3e53eebc9 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -418,6

[libvirt PATCH 13/28] cpu_map: Add missing x86 feature "sgx-mode64"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index f18bc634ac..4568c0246b 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -426,6

[libvirt PATCH 07/28] cpu_map: Add missing x86 feature "sgx"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-7600U-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-7600U-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-Core-i7-7600U-host.xml

[libvirt PATCH 12/28] cpu_map: Add missing x86 feature "sgx-debug"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index f3e53eebc9..f18bc634ac 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -422,6

[libvirt PATCH 20/28] cpu_map: Add missing x86 feature "avx512-fp16"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 8557fe8825..5d90075da7 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -372,6

[libvirt PATCH 21/28] cpu_map: Add missing x86 feature "serialize"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 5d90075da7..67c9cdc3fe 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -369,6

[libvirt PATCH 22/28] cpu_map: Add missing x86 feature "tsx-ldtrk"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 67c9cdc3fe..a8fafdd592 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -372,6

[libvirt PATCH 19/28] cpu_map: Add missing x86 feature "avx512-vp2intersect"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4228091d1c..8557fe8825 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -362,6

[libvirt PATCH 26/28] cpu_map: Add missing x86 feature "avic"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[libvirt PATCH 28/28] cpu_map: Add missing x86 feature "vgif"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[libvirt PATCH 27/28] cpu_map: Add missing x86 feature "v-vmsave-vmload"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[libvirt PATCH 24/28] cpu_map: Add missing x86 feature "xfd"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 36641ca118..c05c4ac3a9 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -422,6

[libvirt PATCH 15/28] cpu_map: Add missing x86 feature "sgx-tokenkey"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 34c28e9135..2cbad9cdc7 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -432,6

[libvirt PATCH 17/28] cpu_map: Add missing x86 feature "bus-lock-detect"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index e59c134844..e5e82e6018 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -334,6

[libvirt PATCH 16/28] cpu_map: Add missing x86 feature "sgx-kss"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 2cbad9cdc7..e59c134844 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -435,6

[libvirt PATCH 09/28] cpu_map: Add missing x86 feature "sgx-exinfo"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c89bc2d112..5b9e61a3d0 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -410,6

[libvirt PATCH 23/28] cpu_map: Add missing x86 feature "arch-lbr"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index a8fafdd592..36641ca118 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -378,6

[libvirt PATCH 25/28] cpu_map: Add missing x86 feature "intel-pt-lip"

2022-10-19 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + tests/cputestdata/x86_64-cpuid-Atom-P5362-disabled.xml | 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-guest.xml| 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-host.xml | 1 + 4 files

[libvirt PATCH 04/28] cpu_map: Add script to sync from QEMU i386 cpu features

2022-10-19 Thread Tim Wiederhake
This script is intended to help in synchronizing i386 QEMU cpu feature definitions with libvirt. QEMU's attribute list for the "max-x86_64-cpu" contains non-cpu-feature items and needs to be filtered before being useful. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_f

[libvirt PATCH v2 01/24] cpu-data.py: Allow for more than child in feature nodes

2022-10-28 Thread Tim Wiederhake
cpu-data.py assumes that all "feature" nodes have exactly one child. This assumption will no longer be true when the cpumap includes alias- names for features. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- tests/cputestdata/cpu-data.py | 11 +++ 1 file

[libvirt PATCH v2 04/24] cpu_map: Add script to sync from QEMU i386 cpu features

2022-10-28 Thread Tim Wiederhake
This script is intended to help in synchronizing i386 QEMU cpu feature definitions with libvirt. QEMU's attribute list for the "max-x86_64-cpu" contains non-cpu-feature items and needs to be filtered before being useful. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_f

[libvirt PATCH v2 00/24] Synchronize x86 cpu features from qemu

2022-10-28 Thread Tim Wiederhake
s in the XML > would just make such XMLs unnecessarily incompatible with older libvirt > releases)? I am planning on using this information in virQEMUCapsCPUFeatureTranslate. Would be nice if we could deduplicate the information of how to translate qemu feature names into libvirt names. I

[libvirt PATCH v2 05/24] cpu_map: Rename sync_qemu_i386.py

2022-10-28 Thread Tim Wiederhake
This makes the naming more consistent beween the two scripts synching the feature list and the model list. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/{sync_qemu_i386.py => sync_qemu_models_i386.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename

[libvirt PATCH v2 10/24] cpu_map: Add missing x86 feature "sgx1"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 5b9e61a3d0..bdada7757d 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -411,6

[libvirt PATCH v2 12/24] cpu_map: Add missing x86 features "sgx-..."

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 273812a5d0..7275ceb097 100644 --- a/src/cpu_map/x86_features.xml

[libvirt PATCH v2 02/24] cpu_x86: Ignore alias names

2022-10-28 Thread Tim Wiederhake
A later patch will add alias names to the feature map. Ignore them for now. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 4d2379803c

[libvirt PATCH v2 09/24] cpu_map: Add missing x86 feature "sgx-exinfo"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c89bc2d112..5b9e61a3d0 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 06/24] cpu_map: Add missing x86 feature alias names

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 90d0f43fc6..5f17255a56 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 15/24] cpu_map: Add missing x86 feature "avx512-vp2intersect"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4d77f4e595..194a414fdd 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 08/24] cpu_map: Add missing x86 feature "sgxlc"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-8700-disabled.xml| 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-8700-guest.xml | 1 + tests/cputestdata/x86_64-cpuid

[libvirt PATCH v2 22/24] cpu_map: Add missing x86 feature "avic"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata

[libvirt PATCH v2 13/24] cpu_map: Add missing x86 feature "bus-lock-detect"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 7275ceb097..f3c503c42e 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 07/24] cpu_map: Add missing x86 feature "sgx"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-7600U-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-7600U-guest.xml | 1 + tests/cputestdata/x86_64-cpuid

[libvirt PATCH v2 11/24] cpu_map: Add missing x86 feature "sgx2"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index bdada7757d..273812a5d0 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -414,6

[libvirt PATCH v2 21/24] cpu_map: Add missing x86 feature "intel-pt-lip"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + tests/cputestdata/x86_64-cpuid-Atom-P5362-disabled.xml | 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-guest.xml| 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362

[libvirt PATCH v2 23/24] cpu_map: Add missing x86 feature "v-vmsave-vmload"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata

[libvirt PATCH v2 16/24] cpu_map: Add missing x86 feature "avx512-fp16"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 194a414fdd..0db2c6a995 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 20/24] cpu_map: Add missing x86 feature "xfd"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c017b8ca3d..4bbd096f71 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 14/24] cpu_map: Add missing x86 feature "pks"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 + tests

[libvirt PATCH v2 17/24] cpu_map: Add missing x86 feature "serialize"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 0db2c6a995..fd4d34bc78 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 19/24] cpu_map: Add missing x86 feature "arch-lbr"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c00308268e..c017b8ca3d 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

[libvirt PATCH v2 24/24] cpu_map: Add missing x86 feature "vgif"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata

[libvirt PATCH v2 18/24] cpu_map: Add missing x86 feature "tsx-ldtrk"

2022-10-28 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index fd4d34bc78..c00308268e 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map

<    9   10   11   12   13   14   15   >