[libvirt PATCH v2 0/1] qemuProcessUpdateGuestCPU: Check host cpu for forbidden features

V1: https://listman.redhat.com/archives/libvir-list/2021-February/msg01275.ht= ml Changes since V1: * Only check for forbidden features * Check if `check` !=3D none * Renamed patch Tim Wiederhake (1): qemuProcessUpdateGuestCPU: Check host cpu for forbidden features src/qemu/qemu_process.c

[libvirt PATCH v2 1/1] qemuProcessUpdateGuestCPU: Check host cpu for forbidden features

See https://bugzilla.redhat.com/show_bug.cgi?id=1840770 Signed-off-by: Tim Wiederhake --- src/qemu/qemu_process.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index bfa742577f..cecf606312 100644 --- a/src/qemu

Re: [libvirt PATCH] cpu_map: Fix spelling of svme-addr-chk feature

On Thu, 2021-03-04 at 08:44 +0100, Jiri Denemark wrote: > Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this > feature > with an incorrect "svme-addr-check" spelling. > > Signed-off-by: Jiri Denemark My bad. Reviewed-by: Tim Wiederhake > --- > src

[libvirt PATCH 4/5] domain_conf: Add missing break in switch

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4bc82b69fc..48fd078b90 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18449,6 +18449,7

[libvirt PATCH 0/5] Some fixes in domain_conf.c: virDomainFeaturesDefParse

Patches 1-4 are minor cleanups, patch 5 is the actual one that I want out of the way before continuing down my rabbit hole of the week. Tim Wiederhake (5): domain_conf: Reduce scope of tmp in virDomainFeaturesDefParse domain_conf: Reduce scope of gic_version in virDomainFeaturesDefParse

[libvirt PATCH 1/5] domain_conf: Reduce scope of tmp in virDomainFeaturesDefParse

Variables using `g_autofree` should not be manually VIR_FREE'd and reused. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f194909b13

[libvirt PATCH 2/5] domain_conf: Reduce scope of gic_version in virDomainFeaturesDefParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1d0ef17318..f73814f3c7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18157,7 +18157,6

[libvirt PATCH 5/5] domain_conf: Fix check for hyperv stimer

return 0 if that tag does not exist. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 48fd078b90..05b6cb3000 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domai

[libvirt PATCH 3/5] domain_conf: Reduce scope of node in virDomainFeaturesDefParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f73814f3c7..4bc82b69fc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18156,7 +18156,6

[libvirt PATCH] qemuProcessUpdateGuestCPU: Check cpu if check=full is set

libvirt performs cpu checking if "check" is set to "partial", but skips checking the cpu if "check" is set to "full". See https://bugzilla.redhat.com/show_bug.cgi?id=1840770 Signed-off-by: Tim Wiederhake --- src/qemu/qemu_process.c | 8 1 f

[libvirt PATCH] Remove references to deleted Makefile.am

Signed-off-by: Tim Wiederhake --- src/admin/libvirt_admin_private.syms | 2 +- src/libvirt_private.syms | 2 +- src/libvirt_remote.syms | 2 +- src/vbox/vbox_tmpl.c | 4 tests/testutils.h| 4 ++-- tools/wireshark/README.rst

[libvirt PATCH v4 2/8] virxml: Add virXMLPropTristateSwitch

Convenience function to return the value of an on / off XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 49 src/util/virxml.h| 4 3 files changed, 54 insertions(+) diff --git

[libvirt PATCH v4 6/8] virNetworkForwardNatDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 4cf4aa4840..19b84cbdd1 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c

[libvirt PATCH v4 3/8] virxml: Add virXMLPropInt

Convenience function to return the value of an integer XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 51 src/util/virxml.h| 6 + 3 files changed, 58 insertions(+) diff --git

[libvirt PATCH v4 0/8] Refactor XML parsing boilerplate code

ost of the actual refactoring to get feedback on the new functions' signatures first Cheers, Tim Tim Wiederhake (8): virxml: Add virXMLPropTristateBool virxml: Add virXMLPropTristateSwitch virxml: Add virXMLPropInt virxml: Add virXMLPropUInt virxml: Add virXMLPropEnum virNetworkForwardN

[libvirt PATCH v4 7/8] virDomainIOThreadIDDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e72171586..fb22695dd3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18180,21

[libvirt PATCH v4 5/8] virxml: Add virXMLPropEnum

Convenience function to return the value of an enum XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 51 src/util/virxml.h| 5 3 files changed, 57 insertions(+) diff --git a/src

[libvirt PATCH v4 4/8] virxml: Add virXMLPropUInt

Convenience function to return the value of an unsigned integer XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 55 src/util/virxml.h| 6 + 3 files changed, 62 insertions(+) diff

[libvirt PATCH v4 1/8] virxml: Add virXMLPropTristateBool

Convenience function to return the value of a yes / no XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 49 src/util/virxml.h| 10 3 files changed, 60 insertions(+) diff --git

[libvirt PATCH v4 8/8] virCPUDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 43629068c3..ee7feb1186 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -423,7 +423,6

[libvirt PATCH v2] Remove references to deleted Makefile.am

Signed-off-by: Tim Wiederhake Reviewed-by: Pavel Hrdina --- src/admin/libvirt_admin_private.syms | 2 +- src/libvirt_private.syms | 2 +- src/libvirt_remote.syms | 2 +- src/vbox/vbox_tmpl.c | 4 tests/testutils.h| 4 ++-- tools

[libvirt PATCH v2 0/2] Fix some typos and spelling mistakes

quot;purposedly->purposely" from patch #2 Tim Wiederhake (2): Fix spelling virlog: Remove stray "todo" in comment NEWS.rst | 10 +- docs/formatdomain.rst | 6 +++--- docs/kbase/launch_security_sev.rst | 2 +- docs/ma

[libvirt PATCH v2 1/2] Fix spelling

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- NEWS.rst | 10 +- docs/formatdomain.rst | 6 +++--- docs/kbase/launch_security_sev.rst | 2 +- docs/manpages/virtproxyd.rst | 2 +- docs/pci-addresses.rst | 2 +- src

[libvirt PATCH v2 2/2] virlog: Remove stray "todo" in comment

Fixes: 8fe30b2167b5b56461b11dbf02aca83030070caf Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 7778724d58..73a2d6734f 100644 --- a/src/util/virlog.c +++ b

Re: [libvirt PATCH 00/14] Use virTristateXXX for more struct members

polite ping On Wed, 2021-04-07 at 13:48 +0200, Tim Wiederhake wrote: > This is a preparation step for some refactoring of the XML parser, > see > https://listman.redhat.com/archives/libvir-list/2021-March/msg01066.html > > Many libvirt structs have members that are of type `in

[libvirt PATCH 0/2] Always validate XML for (hypervisor-)cpu-compare

. This series fixes a bug in the validation code and logs the schema validation error to libvirtd's log file. User facing behaviour stays unchanged. See this conversation for more background: https://listman.redhat.com/archives/libvir-list/2021-March/msg01214.html Tim Wiederhake (2): virxml: Fix schema

[libvirt PATCH 2/2] virCPUDefParseXML: Log schema validation errors

Schema validation was only performed if the "validateXML" flag was set. Make invalid XML visible in the logs by always validating, but only treat validation errors as errors if said flag is set. Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 16 +++- 1 file

[libvirt PATCH 1/2] virxml: Fix schema validation of individual nodes

xmlDocSetRootElement removes the node from its previous document tree, effectively removing the "" node from "" in virCPUDefParseXML. Signed-off-by: Tim Wiederhake --- src/util/virxml.c | 13 ++--- src/util/virxml.h | 1 - 2 files changed, 6 insertions(+), 8 dele

Re: [libvirt PATCH v5 0/8] Refactor XML parsing boilerplate code

polite ping On Thu, 2021-04-08 at 13:19 +0200, Tim Wiederhake wrote: > This series lays the groundwork for replacing some recurring > boilerplate code > in src/conf/ regarding the extraction of XML attribute values. > > For an on / off attribute, the boilerplate code loo

Re: [PATCH 00/21] Refactoring conf to use XPath

On Thu, 2021-04-15 at 16:26 +0200, Kristina Hanicova wrote: > This series reworks the outdated way of parsing XML to parsing by > XPath, > which is more obvious and saves a few lines of code. > > Kristina Hanicova (21): > conf: Propagate xmlXPathContextPtr into >

[libvirt PATCH 1/3] xenParseHypervisorFeatures: Fix memory leak

Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..ad5a3de116 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -567,6 +567,7

[libvirt PATCH 0/3] Fix some memory leaks

These memory leaks were found by llvm's address sanitizer asan. Tim Wiederhake (3): xenParseHypervisorFeatures: Fix memory leak virDomainFeaturesDefParse: Fix memory leak virQEMUCapsSetHostModel: Fix memory leak src/conf/domain_conf.c | 2 +- src/libxl/xen_common.c | 1 + src

[libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 029f2d8d9c..5591681283 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18994,12 +18994,12

[libvirt PATCH 3/3] virQEMUCapsSetHostModel: Fix memory leak

virQEMUCapsSetHostModel is called by virQEMUCapsInitHostCPUModel, which in turn is typically called twice (for KVM and QEMU), e.g. in virQEMUCapsLoadCache and virQEMUCapsNewForBinaryInternal. The second call leaks memory pointed to by "reported", "migratable" and "f

[libvirt PATCH v2 0/5] Fix some memory leaks

leak", I will address this issue seperately * Added fixes for two more memory leaks and one issue found by ubsan (passing NULL to qsort) Tim Wiederhake (5): xenParseHypervisorFeatures: Fix memory leak virDomainFeaturesDefParse: Fix memory leak cmdCheckpointList: Fix m

[libvirt PATCH v2 2/5] virDomainFeaturesDefParse: Fix memory leak

Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4 Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17bbeddec6..356398294e 100644 --- a/src

[libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 20a02b0b02..afe849dd16 100644 --- a/tools/virsh-checkpoint.c

[libvirt PATCH v2 1/5] xenParseHypervisorFeatures: Fix memory leak

Fixes:b523e22521afe733165869c9e1ae18e88536acd6 Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..6fa69fbdf0 100644 --- a/src

[libvirt PATCH v2 4/5] cmdSnapshotList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 2bec722c61..e64117785c 100644 --- a/tools/virsh-snapshot.c +++ b

[libvirt PATCH v2 5/5] virshCheckpointListCollect: Do not pass NULL to qsort

Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index afe849dd16..e88f9ffb47 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -628,7 +628,8

Re: [PATCH 0/5] util: xml: cleanup virxml.h and virXMLParseHelper

virXMLParseHelper: Rework error reporting > virXMLParseHelper: Refactor cleanup > > src/util/virxml.c | 45 ++- > src/util/virxml.h | 193 +++- > -- > 2 files changed, 137 insertions(+), 101 deletions(-) > Reviewed-by: Tim Wiederhake

[libvirt PATCH v6 1/8] virxml: Add virXMLPropTristateBool

Convenience function to return the value of a yes / no XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 44 src/util/virxml.h| 12 +++ 3 files changed

[libvirt PATCH v6 0/8] Refactor XML parsing boilerplate code

00232.html Changes since V5: * Applied changes requested in https://listman.redhat.com/archives/libvir-list/2021-April/msg00658.html Cheers, Tim Tim Wiederhake (8): virxml: Add virXMLPropTristateBool virxml: Add virXMLPropTristateSwitch virxml: Add virXMLPropInt virxml: Add virXMLPropUInt virxml:

[libvirt PATCH v6 5/8] virxml: Add virXMLPropEnum

Convenience function to return the value of an enum XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 48 src/util/virxml.h| 8 +++ 3 files changed, 57

[libvirt PATCH v6 4/8] virxml: Add virXMLPropUInt

Convenience function to return the value of an unsigned integer XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 60 src/util/virxml.h| 8 ++ 3 files

[libvirt PATCH v6 2/8] virxml: Add virXMLPropTristateSwitch

Convenience function to return the value of an on / off XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 44 src/util/virxml.h| 6 ++ 3 files changed, 51

[libvirt PATCH v6 6/8] virNetworkForwardNatDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/network_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index f0f5ef6f42..17835ac8d3 100644 --- a/src/conf/network_conf.c +++ b/src

[libvirt PATCH v6 8/8] virCPUDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/cpu_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index c095ab0e89..c7bea8ae00 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c

[libvirt PATCH v6 7/8] virDomainIOThreadIDDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a0fb7731d9..858ef5db9d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH v6 3/8] virxml: Add virXMLPropInt

Convenience function to return the value of an integer XML attribute. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 53 src/util/virxml.h| 8 ++ 3 files changed, 62

[libvirt PATCH 0/2] Fix some typos and spelling mistakes

] https://github.com/codespell-project/codespell/issues/1860 Tim Wiederhake (2): Fix spelling virlog: Remove stray "todo" in comment NEWS.rst | 12 ++-- docs/formatdomain.rst | 6 +++--- docs/glib-adoption.rst | 2 +-

[libvirt PATCH 1/2] Fix spelling

Signed-off-by: Tim Wiederhake --- NEWS.rst | 12 ++-- docs/formatdomain.rst | 6 +++--- docs/glib-adoption.rst | 2 +- docs/kbase/launch_security_sev.rst | 2 +- docs/manpages/virtproxyd.rst | 2 +- docs/pci-addresses.rst

[libvirt PATCH 2/2] virlog: Remove stray "todo" in comment

Signed-off-by: Tim Wiederhake --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 7778724d58..73a2d6734f 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1315,7 +1315,7 @@ virLogFilterNew(const char

[libvirt PATCH 4/4] testUpdateQEMUCaps: Fix memory leak

testUpdateQEMUCaps is called multiple times. Use virQEMUCapsUpdateHostCPUModel instead of virQEMUCapsInitHostCPUModel to not overwrite (and leak) the pointers in qemuCaps->kvm.hostCPU and qemuCaps->tcg.hostCPU. Signed-off-by: Tim Wiederhake --- tests/qemuxml2argvtest.c | 8

[libvirt PATCH 3/4] qemu: Introduce virQEMUCapsUpdateHostCPUModel

Function will be used by next patch. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capspriv.h | 4 2 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 030779902d..7971a9c557

[libvirt PATCH 2/4] xenParseHypervisorFeatures: Remove superfluous VIR_FREE

Fixes: 4eb7c621985dad4de911ec394ac628bd1a5b29ab Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 6fa69fbdf0..aeb94e12ad 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl

[libvirt PATCH 1/4] virxml: Fix schema validation of individual nodes

xmlDocSetRootElement removes the node from its previous document tree, effectively removing the "" node from "" in virCPUDefParseXML. Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 3 +-- src/util/virxml.c | 13 ++--- src/util/virxml.h | 1 - 3 files c

[libvirt PATCH 0/4] Some memory leaks related fixes

/2021-April/msg00643.html Cheers, Tim Tim Wiederhake (4): virxml: Fix schema validation of individual nodes xenParseHypervisorFeatures: Remove superfluous VIR_FREE qemu: Introduce virQEMUCapsUpdateHostCPUModel testUpdateQEMUCaps: Fix memory leak src/conf/cpu_conf.c | 3 +-- src

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainVirtioOptionsParseXML: Use virXMLProp* virDomainDeviceBootParseXML: Use virXMLProp* virDomainDeviceISAAddressParseXML: Use virXMLProp* virDomainDiskSourceNVMeParse

[libvirt PATCH 05/10] virDomainChrSourceDefParseFile: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6ea347e05b..d10d697884 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11678,20

[libvirt PATCH 01/10] virDomainVirtioOptionsParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a0d1f9285..5c13d9946c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 08/10] virDomainVideoResolutionDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ec7d48b40e..9e968c087d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 02/10] virDomainDeviceBootParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c13d9946c..9113993bce 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6465,22

[libvirt PATCH 10/10] virDomainLoaderDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 47 ++ 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1878d9ed9d..4c88a124bc 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 03/10] virDomainDeviceISAAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9113993bce..b28265cf4f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 04/10] virDomainDiskSourceNVMeParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b28265cf4f..6ea347e05b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8453,7

[libvirt PATCH 07/10] virDomainAudioJackParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c97a062d1f..ec7d48b40e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13806,19

[libvirt PATCH 09/10] virDomainVsockDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 48 -- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9e968c087d..1878d9ed9d 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 06/10] virDomainChrSourceDefParseLog: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d10d697884..c97a062d1f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11713,20

[libvirt PATCH v2 08/10] virDomainDeviceCcidAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 5360fb301f..dbe30b05c1 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH v2 07/10] virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 66b7af109f..5360fb301f 100644 --- a/src/conf/device_conf.c +++ b

[libvirt PATCH v2 02/10] virDomainBackupDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/backup_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index e4464b91a0..7f176b783f 100644 --- a/src/conf/backup_conf.c +++ b/src

[libvirt PATCH v2 06/10] virDomainDeviceDriveAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index e527899d7d..66b7af109f 100644 --- a/src/conf

[libvirt PATCH v2 10/10] virInterfaceLinkParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `speed`, which does not make sense for a value measured in Mbits per second. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 25

[libvirt PATCH v2 03/10] virZPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 34 -- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 6a4b14cfda..9abbd5ebb7 100644 --- a/src/conf

[libvirt PATCH v2 05/10] virDomainDeviceCCWAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 53 ++ 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 801552a9cf..e527899d7d 100644 --- a/src/conf

[libvirt PATCH v2 04/10] virPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 47 +++--- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 9abbd5ebb7..801552a9cf 100644 --- a/src/conf

[libvirt PATCH v2 01/10] virDomainBackupDiskDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/backup_conf.c | 40 ++-- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 7f54a25ff6..e4464b91a0 100644 --- a/src/conf

[libvirt PATCH v2 09/10] virDomainDeviceUSBAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index dbe30b05c1..9b0b81b2cb 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Changes since V1: * Rebased * s/VIR_XML_PROP_OPTIONAL/VIR_XML_PROP_NONE/ * Declare variables 1 / line * Commented on strictening of parser in patch #10 Tim Wiederhake (10

[libvirt PATCH 02/10] virDomainBackupDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 859609946f..898725aac7 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -222,8

[libvirt PATCH 07/10] virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 5a98cd8c0f..587f966398 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c

[libvirt PATCH 04/10] virPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 47 +++--- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 8d3d012e4a..951b7a348e 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH 09/10] virDomainDeviceUSBAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index f7bf2de6f1..1ce31e9234 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -403,19 +403,16

[libvirt PATCH 05/10] virDomainDeviceCCWAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 51 +- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 951b7a348e..621ff1b476 100644 --- a/src/conf/device_conf.c +++ b/src

[libvirt PATCH 03/10] virZPCIDeviceAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 6a4b14cfda..8d3d012e4a 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainBackupDiskDefParseXML: Use virXMLProp* virDomainBackupDefParse: Use virXMLProp* virZPCIDeviceAddressParseXML: Use virXMLProp* virPCIDeviceAddressParseXML: Use

[libvirt PATCH 10/10] virInterfaceLinkParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 1ce31e9234..a2893fec6f 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c

Re: [PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

conf: domain: Convert virDomainDiskDef's 'startupPolicy' to > virDomainStartupPolicy > > src/conf/domain_conf.c | 31 +++ > src/conf/domain_conf.h | 4 ++-- > 2 files changed, 9 insertions(+), 26 deletions(-) > Reviewed-by: Tim Wiederhake

[libvirt PATCH 01/10] virDomainBackupDiskDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 40 ++-- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 2de77a59c0..859609946f 100644 --- a/src/conf/backup_conf.c +++ b/src/conf

[libvirt PATCH 08/10] virDomainDeviceCcidAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 587f966398..f7bf2de6f1 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -362,24

[libvirt PATCH 06/10] virDomainDeviceDriveAddressParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 621ff1b476..5a98cd8c0f 100644 --- a/src/conf/device_conf.c +++ b/src/conf

[libvirt PATCH v5 0/8] Refactor XML parsing boilerplate code

ttribute value is 0 and VIR_XML_PROP_NONZERO is specified. Cheers, Tim Tim Wiederhake (8): virxml: Add virXMLPropTristateBool virxml: Add virXMLPropTristateSwitch virxml: Add virXMLPropInt virxml: Add virXMLPropUInt virxml: Add virXMLPropEnum virNetworkForwardNatDefParseX

[libvirt PATCH v5 4/8] virxml: Add virXMLPropUInt

Convenience function to return the value of an unsigned integer XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 61 src/util/virxml.h| 6 3 files changed, 68 insertions(+) diff

[libvirt PATCH v5 3/8] virxml: Add virXMLPropInt

Convenience function to return the value of an integer XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 57 src/util/virxml.h| 6 + 3 files changed, 64 insertions(+) diff --git

[libvirt PATCH v5 5/8] virxml: Add virXMLPropEnum

Convenience function to return the value of an enum XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 51 src/util/virxml.h| 5 3 files changed, 57 insertions(+) diff --git a/src

[libvirt PATCH v5 6/8] virNetworkForwardNatDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 4cf4aa4840..19b84cbdd1 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c

[libvirt PATCH v5 8/8] virCPUDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 43629068c3..ee7feb1186 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -423,7 +423,6

[libvirt PATCH v5 7/8] virDomainIOThreadIDDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e72171586..fb22695dd3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18180,21

[libvirt PATCH v5 2/8] virxml: Add virXMLPropTristateSwitch

Convenience function to return the value of an on / off XML attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 49 src/util/virxml.h| 4 3 files changed, 54 insertions(+) diff --git

<    3   4   5   6   7   8   9   10   11   12   >