Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-07 Thread Gionatan Danti
Il 07-01-2020 08:31 Peter Krempa ha scritto: blockdev is the new way to specify disks on qemu command line. It required quite a lot of internal changes, some of which probably fixed the block job cooperation with virtlockd. (leaking locks of images). Blockdev is used starting from libvirt-5.10 a

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-06 Thread Peter Krempa
On Mon, Jan 06, 2020 at 18:44:31 +0100, Gionatan Danti wrote: > Il 06-01-2020 10:06 Peter Krempa ha scritto: > > On Fri, Jan 03, 2020 at 14:08:03 +, Daniel Berrange wrote: > > > As above, QEMU's locking is good enough to rely on for file based > > > images. > > Hi Daniel, thank you for the dir

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-06 Thread Gionatan Danti
Il 06-01-2020 10:06 Peter Krempa ha scritto: On Fri, Jan 03, 2020 at 14:08:03 +, Daniel Berrange wrote: As above, QEMU's locking is good enough to rely on for file based images. Hi Daniel, thank you for the direct confirmation. The flaws I mention with libvirt might actually finally be so

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-06 Thread Peter Krempa
On Fri, Jan 03, 2020 at 14:08:03 +, Daniel Berrange wrote: > On Fri, Jan 03, 2020 at 02:56:50PM +0100, Gionatan Danti wrote: > > Il 03-01-2020 11:26 Daniel P. Berrangé ha scritto: [...] > > > There are some issues with libvirt's locking though where we haven't > > > always released/re-acquire

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-03 Thread Daniel P . Berrangé
On Fri, Jan 03, 2020 at 02:56:50PM +0100, Gionatan Danti wrote: > Il 03-01-2020 11:26 Daniel P. Berrangé ha scritto: > > virtlockd also uses fcntl(), however, it doesn't have to acquire locks > > on > > the file/block device directly. It can use a look-aside file for > > locking. > > For example a

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-03 Thread Gionatan Danti
Il 03-01-2020 11:26 Daniel P. Berrangé ha scritto: virtlockd also uses fcntl(), however, it doesn't have to acquire locks on the file/block device directly. It can use a look-aside file for locking. For example a path under /var/lib/libvirt/lock. This means that locks on block devices for /dev

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-03 Thread Daniel P . Berrangé
On Sat, Dec 28, 2019 at 02:36:27PM +0100, Gionatan Danti wrote: > Il 28-12-2019 01:39 Gionatan Danti ha scritto: > > Hi list, > > I would like to ask a clarification about how locking works. My test > > system is CentOS 7.7 with libvirt-4.5.0-23.el7_7.1.x86_64 > > > > Is was understanding that, by

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2020-01-03 Thread Gionatan Danti
Il 28-12-2019 14:36 Gionatan Danti ha scritto: Il 28-12-2019 01:39 Gionatan Danti ha scritto: Hi list, I would like to ask a clarification about how locking works. My test system is CentOS 7.7 with libvirt-4.5.0-23.el7_7.1.x86_64 Is was understanding that, by default, libvirt does not use any l

Re: [libvirt-users] Locking without virtlockd (nor sanlock)?

2019-12-28 Thread Gionatan Danti
Il 28-12-2019 01:39 Gionatan Danti ha scritto: Hi list, I would like to ask a clarification about how locking works. My test system is CentOS 7.7 with libvirt-4.5.0-23.el7_7.1.x86_64 Is was understanding that, by default, libvirt does not use any locks. From here [1]: "The out of the box configu

[libvirt-users] Locking without virtlockd (nor sanlock)?

2019-12-27 Thread Gionatan Danti
Hi list, I would like to ask a clarification about how locking works. My test system is CentOS 7.7 with libvirt-4.5.0-23.el7_7.1.x86_64 Is was understanding that, by default, libvirt does not use any locks. From here [1]: "The out of the box configuration, however, currently uses the nop lock