Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread John Snow
On 2/3/20 11:27 AM, Eric Blake wrote: > [adding Markus] > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >>> On 1/31/20 4:38 AM, Peter Luo wrote: >>> error: internal error: cannot parse json {"execute": "block-commit",

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > [adding Markus] >> > >> > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >> >>> On 1/31/20 4:38 AM,

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20 4:38 AM, Peter Luo wrote: > >>> > error:

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20 4:38 AM, Peter Luo wrote: > >>> > error:

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Markus Armbruster
Eric Blake writes: > [adding Markus] > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >>> On 1/31/20 4:38 AM, Peter Luo wrote: >>> error: internal error: cannot parse json {"execute": "block-commit", "arguments": {

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-03 Thread Eric Blake
[adding Markus] On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: On 1/31/20 4:38 AM, Peter Luo wrote: error: internal error: cannot parse json {"execute": "block-commit", "arguments": { "device": "drive-virtio-disk2", "job-id":

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-03 Thread Daniel P . Berrangé
On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > On 1/31/20 4:38 AM, Peter Luo wrote: > > > error: internal error: cannot parse json {"execute": "block-commit", > > "arguments": { "device": "drive-virtio-disk2", "job-id": "job100", > >

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-01-31 Thread Eric Blake
On 1/31/20 4:38 AM, Peter Luo wrote: error: internal error: cannot parse json {"execute": "block-commit", "arguments": { "device": "drive-virtio-disk2", "job-id": "job100",

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-01-31 Thread Peter Krempa
On Fri, Jan 31, 2020 at 19:14:46 +0800, Peter Luo wrote: > > Hi Peter Krempa, Hi, please don't top-post on techincal mailing lists. > Thanks for your quick response, yes, I know since libvirt 5.8, the -blockdev > is used for disk by default. > However we have to maintain the old releases for

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-01-31 Thread Peter Luo
Hi Peter Krempa, Thanks for your quick response, yes, I know since libvirt 5.8, the -blockdev is used for disk by default. However we have to maintain the old releases for the production environment for a while, so I still need use the old way to create the disk. >"base" argument must

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-01-31 Thread Peter Krempa
On Fri, Jan 31, 2020 at 18:38:33 +0800, Peter Luo wrote: > Hi All, > > > > I’m using qmp command via “virsh qemu-monitor-command” to perform block > related jobs. > > And in my case, I execute block-commit to commit the changes in the top image > to the base image which is encrypted. >