Re: [libxml-devel] Version and library bugs

2008-03-26 Thread Luc Heinrich
On 26 mars 08, at 13:58, Luc Heinrich wrote: > 2. in lib/libxml.rb, XML::Attr#to_h is wrong: it should return the > hash (to_a methods work because Array#<< returns the array itself, > hash insertions return the inserted value). Er, sorry, the previous patch was completely bogus, this is the co

Re: [libxml-devel] Version and library bugs

2008-03-26 Thread Sean Chittenden
>> On the topic... I have forgotten... What is version.h being used for? > > It is used in ext/libxml/ruby_xml_parser.c to provide the > XML::Parser::VERSION and XML::Parser::VERNUM constants. Why these > constants are in the XML::Parser class and not in the XML module, that > I don't know... :)

Re: [libxml-devel] Version and library bugs

2008-03-26 Thread Luc Heinrich
On 26 mars 08, at 15:02, Trans wrote: > On the topic... I have forgotten... What is version.h being used for? It is used in ext/libxml/ruby_xml_parser.c to provide the XML::Parser::VERSION and XML::Parser::VERNUM constants. Why these constants are in the XML::Parser class and not in the XML m

Re: [libxml-devel] Version and library bugs

2008-03-26 Thread Trans
On Mar 26, 8:58 am, Luc Heinrich <[EMAIL PROTECTED]> wrote: > Greetings, > > Just saw the mention of 0.5.4 in another post and thought I'd take a > look. I noticed to obvious problems: > > 1. in ext/libxml/version.h, the version is still 0.5.2.2. Thanks for the report. I fixed this and just re-r

[libxml-devel] Version and library bugs

2008-03-26 Thread Luc Heinrich
Greetings, Just saw the mention of 0.5.4 in another post and thought I'd take a look. I noticed to obvious problems: 1. in ext/libxml/version.h, the version is still 0.5.2.2. 2. in lib/libxml.rb, XML::Attr#to_h is wrong: it should return the hash (to_a methods work because Array#<< returns t