As Props.userName is public, it would be good if it didn't include a trailing "." in the return value. I see why it does for use in toTry but as a user of Lift it was a surprise to ask for Props.userName and see the "." on the end.
The same applies for Props.hostName (even though there's S.hostName) and maybe Props.modeName. This came about because I was customizing a logging environment to use the SMTP Appender and I wanted to include a username and hostname as the sender of the SMTP error message. I was happy to spot Props.userName (thank you IDE code completion) but confused to get a value of "richard." not "richard" as my username. It is, of course trivial to get the values without the "." on the end, but just as a principle of least surprise it might be an idea to drop the trailing "." on these methods. Or make them private? :-O Cheers Richard --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~----------~----~----~----~------~----~------~--~---
