Re: [Lift] ProtoUser i18n

2010-02-03 Thread Indrajit Raychaudhuri
Thanks Adam, I'll take this one up :) - Indrajit On 03/02/10 12:48 PM, Adam Warski wrote: Sure: (a) http://github.com/dpp/liftweb/issues/issue/320 (b) http://gist.github.com/293435 I've also updated the wiki. On Feb 2, 2010, at 8:10 PM, Indrajit Raychaudhuri wrote: Adam, can you please

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Jeppe Nejsum Madsen
Adam Warski a...@warski.org writes: We'll accept a patch for this issue. Here's the patch. Note that this will break all existing translations. While having a complete list of keys that can be translated is great, I don't really think there's a reason to change the keys. E.g. First\ Name

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Adam Warski
Hmm right, although e.g. password already exists as a key and it wouldn't be good to duplicate it as Password. Same about Email. On Feb 2, 2010, at 1:08 PM, Jeppe Nejsum Madsen wrote: Adam Warski a...@warski.org writes: We'll accept a patch for this issue. Here's the patch. Note

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Jeppe Nejsum Madsen
Adam Warski a...@warski.org writes: Hmm right, although e.g. password already exists as a key and it wouldn't be good to duplicate it as Password. Same about Email. Good point. Also, the spaces in keys seem to confuse people, so maybe this is breakage that is worth it /Jeppe -- You

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Adam Warski
Hmm right, although e.g. password already exists as a key and it wouldn't be good to duplicate it as Password. Same about Email. Good point. Also, the spaces in keys seem to confuse people, so maybe this is breakage that is worth it I guess I'll leave the decision up to David ;) --

Re: [Lift] ProtoUser i18n

2010-02-02 Thread David Pollak
On Tue, Feb 2, 2010 at 6:53 AM, Adam Warski a...@warski.org wrote: Hmm right, although e.g. password already exists as a key and it wouldn't be good to duplicate it as Password. Same about Email. Good point. Also, the spaces in keys seem to confuse people, so maybe this is breakage

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Indrajit Raychaudhuri
Adam, can you please (a) open a ticket and (b) create a gist (http://gist.github.com/) of the patch and refer to it from the ticket? We'll take it up from there. Tim, +1 on not having spaces in properties. Cheers, Indrajit On 02/02/10 10:41 PM, Timothy Perrett wrote: Sure - one of us will

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Timothy Perrett
Indrajit, I think you just volunteered to take this on good chap ;-) Cheers, Tim On 2 Feb 2010, at 19:10, Indrajit Raychaudhuri wrote: Adam, can you please (a) open a ticket and (b) create a gist (http://gist.github.com/) of the patch and refer to it from the ticket? We'll take it up from

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Indrajit Raychaudhuri
Yep, I did ;) Cheers, Indrajit On 03/02/10 1:21 AM, Timothy Perrett wrote: Indrajit, I think you just volunteered to take this on good chap ;-) Cheers, Tim On 2 Feb 2010, at 19:10, Indrajit Raychaudhuri wrote: Adam, can you please (a) open a ticket and (b) create a gist

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Jeppe Nejsum Madsen
Indrajit Raychaudhuri indraj...@gmail.com writes: Yep, I did ;) Awesome ;-) /Jeppe Cheers, Indrajit On 03/02/10 1:21 AM, Timothy Perrett wrote: Indrajit, I think you just volunteered to take this on good chap ;-) Cheers, Tim -- You received this message because you are subscribed to

Re: [Lift] ProtoUser i18n

2010-02-02 Thread Adam Warski
Sure: (a) http://github.com/dpp/liftweb/issues/issue/320 (b) http://gist.github.com/293435 I've also updated the wiki. On Feb 2, 2010, at 8:10 PM, Indrajit Raychaudhuri wrote: Adam, can you please (a) open a ticket and (b) create a gist (http://gist.github.com/) of the patch and refer to it

[Lift] ProtoUser i18n

2010-02-01 Thread Adam Warski
Hello, I'm using ProtoUser and all strings in the user menu, login, forgot password forms are localized except the Sign Up and Edit user forms. The problem is that in ProtoUser, the display names are defined as: def firstNameDisplayName = ??(First Name) instead using e.g. first.name.

Re: [Lift] ProtoUser i18n

2010-02-01 Thread David Pollak
We'll accept a patch for this issue. On Mon, Feb 1, 2010 at 8:07 AM, Adam Warski a...@warski.org wrote: Hello, I'm using ProtoUser and all strings in the user menu, login, forgot password forms are localized except the Sign Up and Edit user forms. The problem is that in ProtoUser, the